Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - update-desktop-database is invoked when required Note: desktop file(s) in kdenetwork-fileshare-samba, kdenetwork-kdnssd See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop - Large documentation must go in a -doc subpackage. Note: Documentation size is 3328000 bytes in 111 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kdenetwork- common , kdenetwork-devel , kdenetwork-fileshare-samba , kdenetwork- kdnssd , kdenetwork-kget-libs , kdenetwork-kopete-libs , kdenetwork- kopete-devel , kdenetwork-krdc-libs , kdenetwork-krdc-devel , kdenetwork- krfb-libs [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 10772480 bytes in /usr/share 20480 kdenetwork-kdnssd-4.9.98-1.fc19.x86_64.rpm 860160 kdenetwork- krdc-4.9.98-1.fc19.x86_64.rpm 1955840 kdenetwork- kppp-4.9.98-1.fc19.x86_64.rpm 389120 kdenetwork- krfb-4.9.98-1.fc19.x86_64.rpm 6451200 kdenetwork- kopete-4.9.98-1.fc19.x86_64.rpm 20480 kdenetwork-fileshare- samba-4.9.98-1.fc19.x86_64.rpm 1075200 kdenetwork- kget-4.9.98-1.fc19.x86_64.rpm Rpmlint ------- Checking: kdenetwork-4.9.98-1.fc19.x86_64.rpm kdenetwork-common-4.9.98-1.fc19.noarch.rpm kdenetwork-devel-4.9.98-1.fc19.noarch.rpm kdenetwork-fileshare-samba-4.9.98-1.fc19.x86_64.rpm kdenetwork-kdnssd-4.9.98-1.fc19.x86_64.rpm kdenetwork-kget-libs-4.9.98-1.fc19.x86_64.rpm kdenetwork-kopete-libs-4.9.98-1.fc19.x86_64.rpm kdenetwork-kopete-devel-4.9.98-1.fc19.x86_64.rpm kdenetwork-krdc-libs-4.9.98-1.fc19.x86_64.rpm kdenetwork-krdc-devel-4.9.98-1.fc19.x86_64.rpm kdenetwork-krfb-libs-4.9.98-1.fc19.x86_64.rpm kdenetwork.x86_64: W: spelling-error %description -l en_US kget -> get, k get kdenetwork.x86_64: W: spelling-error %description -l en_US downloader -> downloaded, down loader, down-loader kdenetwork.x86_64: W: spelling-error %description -l en_US kopete -> kopeck kdenetwork.x86_64: W: spelling-error %description -l en_US kppp -> Krupp kdenetwork.x86_64: W: spelling-error %description -l en_US dialer -> dealer, dialed, diaper kdenetwork.x86_64: W: spelling-error %description -l en_US pppd -> pp pd, pp-pd, pepped kdenetwork.x86_64: W: spelling-error %description -l en_US krdc -> Kroc kdenetwork.x86_64: W: spelling-error %description -l en_US krfb -> Krebs kdenetwork.x86_64: E: no-binary kdenetwork.x86_64: W: no-documentation kdenetwork-common.noarch: W: obsolete-not-provided kdenetwork-libs kdenetwork-common.noarch: W: no-documentation kdenetwork-devel.noarch: W: no-documentation kdenetwork-fileshare-samba.x86_64: W: no-documentation kdenetwork-kdnssd.x86_64: W: no-documentation kdenetwork-kget-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kdenetwork-kget-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kdenetwork-kget-libs.x86_64: W: no-documentation kdenetwork-kopete-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kdenetwork-kopete-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kdenetwork-kopete-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liboscar.so.1.0.0 exit@GLIBC_2.2.5 kdenetwork-kopete-libs.x86_64: W: no-documentation kdenetwork-kopete-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libkyahoo.so kdenetwork-kopete-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/liboscar.so kdenetwork-kopete-devel.x86_64: W: no-documentation kdenetwork-krdc-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kdenetwork-krdc-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kdenetwork-krdc-libs.x86_64: W: no-documentation kdenetwork-krdc-devel.x86_64: W: no-documentation kdenetwork-krfb-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kdenetwork-krfb-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kdenetwork-krfb-libs.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 1 errors, 31 warnings. Requires -------- kdenetwork-kopete-devel (rpmlib, GLIBC filtered): kdelibs4-devel kdenetwork-kopete-libs(x86-64) libkopete.so.4()(64bit) libkopete_oscar.so.4()(64bit) libkopete_otr_shared.so.1()(64bit) libkopete_videodevice.so.4()(64bit) libkopeteaddaccountwizard.so.1()(64bit) libkopetechatwindow_shared.so.1()(64bit) libkopetecontactlist.so.1()(64bit) libkopeteidentity.so.1()(64bit) libkopeteprivacy.so.1()(64bit) libkopetestatusmenu.so.1()(64bit) kdenetwork-krdc-devel (rpmlib, GLIBC filtered): kdelibs4-devel kdenetwork-krdc-libs(x86-64) libkrdccore.so.4()(64bit) kdenetwork-kopete-libs (rpmlib, GLIBC filtered): /sbin/ldconfig kdenetwork-common kdenetwork-kopete libICE.so.6()(64bit) libQt3Support.so.4()(64bit) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXau.so.6()(64bit) libXext.so.6()(64bit) libXft.so.2()(64bit) libXpm.so.4()(64bit) libXss.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libjasper.so.1()(64bit) libjpeg.so.62()(64bit) libkabc.so.4()(64bit) libkcmutils.so.4()(64bit) libkde3support.so.4()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkemoticons.so.4()(64bit) libkhtml.so.5()(64bit) libkidletime.so.4()(64bit) libkio.so.5()(64bit) libkjs.so.4()(64bit) libknotifyconfig.so.4()(64bit) libkopete.so.4()(64bit) libkopete_videodevice.so.4()(64bit) libkopeteaddaccountwizard.so.1()(64bit) libkopetestatusmenu.so.1()(64bit) libkparts.so.4()(64bit) libkprintutils.so.4()(64bit) libkresources.so.4()(64bit) libkutils.so.4()(64bit) libkyahoo.so.1()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libnepomukutils.so.4()(64bit) liboscar.so.1()(64bit) libotr.so.2()(64bit) libphonon.so.4()(64bit) libpthread.so.0()(64bit) libqimageblitz.so.4()(64bit) libsolid.so.4()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libv4l2.so.0()(64bit) rtld(GNU_HASH) kdenetwork-devel (rpmlib, GLIBC filtered): kdenetwork-common kdenetwork-kopete-devel kdenetwork-krdc-devel kdenetwork-krdc-libs (rpmlib, GLIBC filtered): /sbin/ldconfig kdenetwork-common kdenetwork-krdc libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtSvg.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdenetwork-common (rpmlib, GLIBC filtered): kdenetwork-krfb-libs (rpmlib, GLIBC filtered): /sbin/ldconfig kdenetwork-common kdenetwork-krfb libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdenetwork-kget-libs (rpmlib, GLIBC filtered): /sbin/ldconfig kdenetwork-kget libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSql.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgpg-error.so.0()(64bit) libgpgme++-pthread.so.2()(64bit) libgpgme-pthread.so.11()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkworkspace.so.4()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libpthread.so.0()(64bit) libqca.so.2()(64bit) libqgpgme.so.1()(64bit) libsolid.so.4()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdenetwork-kdnssd (rpmlib, GLIBC filtered): kdenetwork-common libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkdnssd.so.4()(64bit) libkio.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdenetwork (rpmlib, GLIBC filtered): kdenetwork-common kdenetwork-fileshare-samba kdenetwork-kdnssd kdenetwork-kget kdenetwork-kopete kdenetwork-kppp kdenetwork-krdc kdenetwork-krfb kdenetwork-fileshare-samba (rpmlib, GLIBC filtered): kdenetwork-common libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) samba Provides -------- kdenetwork-kopete-devel: kdenetwork-kopete-devel kdenetwork-kopete-devel(x86-64) kdenetwork-krdc-devel: kdenetwork-krdc-devel kdenetwork-krdc-devel(x86-64) kdenetwork-kopete-libs: chatwindowaccessiblewidgetfactory.so()(64bit) kdenetwork-kopete-libs kdenetwork-kopete-libs(x86-64) libkopete.so.4()(64bit) libkopete_oscar.so.4()(64bit) libkopete_otr_shared.so.1()(64bit) libkopete_videodevice.so.4()(64bit) libkopeteaddaccountwizard.so.1()(64bit) libkopetechatwindow_shared.so.1()(64bit) libkopetecontactlist.so.1()(64bit) libkopeteidentity.so.1()(64bit) libkopeteprivacy.so.1()(64bit) libkopetestatusmenu.so.1()(64bit) libkyahoo.so.1()(64bit) liboscar.so.1()(64bit) kdenetwork-devel: kdenetwork-devel kdenetwork-krdc-libs: kdenetwork-krdc-libs kdenetwork-krdc-libs(x86-64) libkrdccore.so.4()(64bit) kdenetwork-common: kdenetwork-common kdenetwork-krfb-libs: kdenetwork-krfb-libs kdenetwork-krfb-libs(x86-64) libkrfbprivate.so.4.10.0()(64bit) kdenetwork-kget-libs: kdenetwork-kget-libs kdenetwork-kget-libs(x86-64) libkgetcore.so.4()(64bit) kdenetwork-kdnssd: kded_dnssdwatcher.so()(64bit) kdenetwork-kdnssd kdenetwork-kdnssd(x86-64) kio_zeroconf.so()(64bit) kdenetwork: kdenetwork kdenetwork(x86-64) kdenetwork-fileshare-samba: kdenetwork-fileshare-samba kdenetwork-fileshare-samba(x86-64) sambausershareplugin.so()(64bit) Unversioned so-files -------------------- kdenetwork-fileshare-samba: /usr/lib64/kde4/sambausershareplugin.so kdenetwork-kdnssd: /usr/lib64/kde4/kded_dnssdwatcher.so kdenetwork-kdnssd: /usr/lib64/kde4/kio_zeroconf.so kdenetwork-kopete-libs: /usr/lib64/kde4/plugins/accessible/chatwindowaccessiblewidgetfactory.so kdenetwork-kopete-libs: /usr/lib64/libkyahoo.so kdenetwork-kopete-libs: /usr/lib64/liboscar.so MD5-sum check ------------- http://download.kde.org/unstable/4.9.98/src/kdenetwork-4.9.98.tar.xz : CHECKSUM(SHA256) this package : 027329b5f818b1499d6185e77684c517fbf6ee008ecb7b440f9925964662de3f CHECKSUM(SHA256) upstream package : 027329b5f818b1499d6185e77684c517fbf6ee008ecb7b440f9925964662de3f Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn kdenetwork -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires