Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in kdepim-runtime See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kdepim- runtime-libs [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in kdepim-runtime [ ]: Useful -debuginfo package or justification otherwise. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: update-mime-database is invoked as required Note: mimeinfo files in: kdepim-runtime [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kdepim-runtime-4.9.98-1.fc19.x86_64.rpm kdepim-runtime-libs-4.9.98-1.fc19.x86_64.rpm kdepim-runtime.x86_64: W: obsolete-not-provided kdepim-runtime-devel kdepim-runtime.x86_64: W: no-documentation kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_microblog_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonaditray kdepim-runtime.x86_64: W: no-manual-page-for-binary kmail-migrator kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_kdeaccounts_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_mailtransport_dummy_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary kjotsmigrator kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_icaldir_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi2xml kdepim-runtime.x86_64: W: no-manual-page-for-binary kres-migrator kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_mixedmaildir_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_davgroupware_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_nntp_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_kcal_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_nepomuk_feeder kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_vcarddir_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_pop3_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_openxchange_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_localbookmarks_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary accountwizard kdepim-runtime.x86_64: W: no-manual-page-for-binary kaddressbookmigrator kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_googlecalendar_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_birthdays_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary nepomukpimindexerutility kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_kolabproxy_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_imap_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_nepomuktag_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_kabc_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_maildispatcher_agent kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_googlecontacts_resource kdepim-runtime.x86_64: W: no-manual-page-for-binary akonadi_invitations_agent kdepim-runtime-libs.x86_64: W: summary-not-capitalized C kdepim-runtime runtime libraries kdepim-runtime-libs.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 34 warnings. Requires -------- kdepim-runtime (rpmlib, GLIBC filtered): /bin/sh kde-runtime kdepim-runtime-libs(x86-64) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtDeclarative.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtScript.so.4()(64bit) libQtSvg.so.4()(64bit) libQtWebKit.so.4()(64bit) libQtXml.so.4()(64bit) libQtXmlPatterns.so.4()(64bit) libakonadi-calendar.so.4()(64bit) libakonadi-contact.so.4()(64bit) libakonadi-filestore.so.4()(64bit) libakonadi-kabc.so.4()(64bit) libakonadi-kcal.so.4()(64bit) libakonadi-kde.so.4()(64bit) libakonadi-kmime.so.4()(64bit) libakonadi-notes.so.4()(64bit) libakonadi-xml.so.4()(64bit) libakonadiprotocolinternals.so.1()(64bit) libboost_system-mt.so.1.50.0()(64bit) libboost_thread-mt.so.1.50.0()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libkabc.so.4()(64bit) libkalarmcal.so.2()(64bit) libkcal.so.4()(64bit) libkcalcore.so.4()(64bit) libkcalutils.so.4()(64bit) libkcmutils.so.4()(64bit) libkdecore.so.5()(64bit) libkdepim-copy.so.4()(64bit) libkdeui.so.5()(64bit) libkdewebkit.so.5()(64bit) libkgapi.so.0()(64bit) libkidletime.so.4()(64bit) libkimap.so.4()(64bit) libkio.so.5()(64bit) libkmbox.so.4()(64bit) libkmime.so.4()(64bit) libkmindexreader.so.4()(64bit) libknewstuff3.so.4()(64bit) libknotifyconfig.so.4()(64bit) libkolab.so.0()(64bit) libkolabxml.so.0()(64bit) libkparts.so.4()(64bit) libkpimidentities.so.4()(64bit) libkpimtextedit.so.4()(64bit) libkpimutils.so.4()(64bit) libkresources.so.4()(64bit) libkrosscore.so.4()(64bit) libm.so.6()(64bit) libmaildir.so.4()(64bit) libmailtransport.so.4()(64bit) libmicroblog.so.4()(64bit) libnepomuk.so.4()(64bit) libnepomukcore.so.4()(64bit) libnepomukquery.so.4()(64bit) libnepomukutils.so.4()(64bit) libphonon.so.4()(64bit) libpthread.so.0()(64bit) libqjson.so.0()(64bit) libsolid.so.4()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstreamanalyzer.so.0()(64bit) libstreams.so.0()(64bit) libxerces-c-3.1.so()(64bit) rtld(GNU_HASH) kdepim-runtime-libs (rpmlib, GLIBC filtered): /sbin/ldconfig akonadi(x86-64) kdepim-runtime kdepimlibs-akonadi(x86-64) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libakonadi-kde.so.4()(64bit) libakonadi-kmime.so.4()(64bit) libakonadiprotocolinternals.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libkcalcore.so.4()(64bit) libkcalutils.so.4()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkpimutils.so.4()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.8)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.2)(64bit) rtld(GNU_HASH) Provides -------- kdepim-runtime: accountwizard_plugin.so()(64bit) akonadi-google akonadi-google-calendar akonadi-google-contacts akonadi-google-tasks akonadi_akonotes_resource.so()(64bit) akonadi_contacts_resource.so()(64bit) akonadi_ical_resource.so()(64bit) akonadi_kalarm_dir_resource.so()(64bit) akonadi_kalarm_resource.so()(64bit) akonadi_knut_resource.so()(64bit) akonadi_maildir_resource.so()(64bit) akonadi_mbox_resource.so()(64bit) akonadi_nepomuk_calendar_feeder.so()(64bit) akonadi_nepomuk_contact_feeder.so()(64bit) akonadi_nepomuk_email_feeder.so()(64bit) akonadi_nepomuk_note_feeder.so()(64bit) akonadi_notes_resource.so()(64bit) akonadi_serializer_addressee.so()(64bit) akonadi_serializer_bookmark.so()(64bit) akonadi_serializer_contactgroup.so()(64bit) akonadi_serializer_kalarm.so()(64bit) akonadi_serializer_kcal.so()(64bit) akonadi_serializer_kcalcore.so()(64bit) akonadi_serializer_mail.so()(64bit) akonadi_serializer_microblog.so()(64bit) akonadi_vcard_resource.so()(64bit) kabc_akonadi.so()(64bit) kcal_akonadi.so()(64bit) kcm_akonadi.so()(64bit) kcm_akonadi_resources.so()(64bit) kcm_akonadi_server.so()(64bit) kdepim-runtime kdepim-runtime(x86-64) kdepim4-runtime kio_akonadi.so()(64bit) libkdeqmlplugin.so()(64bit) mimehandler(application/x-accountwizard-package) kdepim-runtime-libs: kdepim-runtime-libs kdepim-runtime-libs(x86-64) libakonadi-filestore.so.4()(64bit) libakonadi-xml.so.4()(64bit) libkdepim-copy.so.4()(64bit) libkmindexreader.so.4()(64bit) libmaildir.so.4()(64bit) Unversioned so-files -------------------- kdepim-runtime: /usr/lib64/kde4/accountwizard_plugin.so kdepim-runtime: /usr/lib64/kde4/akonadi_akonotes_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_contacts_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_ical_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_kalarm_dir_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_kalarm_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_knut_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_maildir_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_mbox_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_nepomuk_calendar_feeder.so kdepim-runtime: /usr/lib64/kde4/akonadi_nepomuk_contact_feeder.so kdepim-runtime: /usr/lib64/kde4/akonadi_nepomuk_email_feeder.so kdepim-runtime: /usr/lib64/kde4/akonadi_nepomuk_note_feeder.so kdepim-runtime: /usr/lib64/kde4/akonadi_notes_resource.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_addressee.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_bookmark.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_contactgroup.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_kalarm.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_kcal.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_kcalcore.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_mail.so kdepim-runtime: /usr/lib64/kde4/akonadi_serializer_microblog.so kdepim-runtime: /usr/lib64/kde4/akonadi_vcard_resource.so kdepim-runtime: /usr/lib64/kde4/imports/org/kde/libkdeqmlplugin.so kdepim-runtime: /usr/lib64/kde4/kabc_akonadi.so kdepim-runtime: /usr/lib64/kde4/kcal_akonadi.so kdepim-runtime: /usr/lib64/kde4/kcm_akonadi.so kdepim-runtime: /usr/lib64/kde4/kcm_akonadi_resources.so kdepim-runtime: /usr/lib64/kde4/kcm_akonadi_server.so kdepim-runtime: /usr/lib64/kde4/kio_akonadi.so MD5-sum check ------------- http://download.kde.org/unstable/4.9.98/src/kdepim-runtime-4.9.98.tar.xz : CHECKSUM(SHA256) this package : 0510371b6c3847655826e226273ac4fba744c7b1cdcda89565ae1a239b287c87 CHECKSUM(SHA256) upstream package : 0510371b6c3847655826e226273ac4fba744c7b1cdcda89565ae1a239b287c87 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn kdepim-runtime -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires