Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in libdb-utils, libdb-devel, libdb-devel-doc, libdb-devel-static, libdb-cxx, libdb-cxx- devel, libdb-tcl, libdb-tcl-devel, libdb-sql, libdb-sql-devel, libdb-java, libdb-java-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Large documentation must go in a -doc subpackage. Note: Documentation size is 54323200 bytes in 2923 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libdb- devel-doc , libdb-devel-static , libdb-cxx-devel , libdb-tcl-devel , libdb-sql-devel , libdb-java-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Test run failed Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define __soversion_major 5 %define __soversion %{__soversion_major}.3 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: libdb-5.3.21-4.fc19.x86_64.rpm libdb-utils-5.3.21-4.fc19.x86_64.rpm libdb-devel-5.3.21-4.fc19.x86_64.rpm libdb-devel-doc-5.3.21-4.fc19.noarch.rpm libdb-devel-static-5.3.21-4.fc19.x86_64.rpm libdb-cxx-5.3.21-4.fc19.x86_64.rpm libdb-cxx-devel-5.3.21-4.fc19.x86_64.rpm libdb-tcl-5.3.21-4.fc19.x86_64.rpm libdb-tcl-devel-5.3.21-4.fc19.x86_64.rpm libdb-sql-5.3.21-4.fc19.x86_64.rpm libdb-sql-devel-5.3.21-4.fc19.x86_64.rpm libdb-java-5.3.21-4.fc19.x86_64.rpm libdb-java-devel-5.3.21-4.fc19.x86_64.rpm libdb.x86_64: W: shared-lib-calls-exit /usr/lib64/libdb-5.3.so exit@GLIBC_2.2.5 libdb-utils.x86_64: W: no-documentation libdb-utils.x86_64: W: no-manual-page-for-binary db_stat libdb-utils.x86_64: W: no-manual-page-for-binary db_checkpoint libdb-utils.x86_64: W: no-manual-page-for-binary db_tuner libdb-utils.x86_64: W: no-manual-page-for-binary db_hotbackup libdb-utils.x86_64: W: no-manual-page-for-binary db_load libdb-utils.x86_64: W: no-manual-page-for-binary db_replicate libdb-utils.x86_64: W: no-manual-page-for-binary db_verify libdb-utils.x86_64: W: no-manual-page-for-binary db_recover libdb-utils.x86_64: W: no-manual-page-for-binary db_log_verify libdb-utils.x86_64: W: no-manual-page-for-binary db_dump libdb-utils.x86_64: W: no-manual-page-for-binary db_upgrade libdb-utils.x86_64: W: no-manual-page-for-binary db_dump185 libdb-utils.x86_64: W: no-manual-page-for-binary db_deadlock libdb-utils.x86_64: W: no-manual-page-for-binary db_printlog libdb-utils.x86_64: W: no-manual-page-for-binary db_archive libdb-devel.x86_64: W: no-documentation libdb-devel-doc.noarch: E: devel-dependency libdb-devel libdb-devel-static.x86_64: W: no-documentation libdb-cxx.x86_64: W: shared-lib-calls-exit /usr/lib64/libdb_cxx-5.3.so exit@GLIBC_2.2.5 libdb-cxx.x86_64: W: no-documentation libdb-cxx-devel.x86_64: W: no-documentation libdb-tcl.x86_64: W: shared-lib-calls-exit /usr/lib64/libdb_tcl-5.3.so exit@GLIBC_2.2.5 libdb-tcl.x86_64: W: no-documentation libdb-tcl-devel.x86_64: W: no-documentation libdb-sql.x86_64: W: shared-lib-calls-exit /usr/lib64/libdb_sql-5.3.so exit@GLIBC_2.2.5 libdb-sql.x86_64: W: no-documentation libdb-sql-devel.x86_64: W: no-documentation libdb-sql-devel.x86_64: W: no-manual-page-for-binary dbsql libdb-java.x86_64: W: shared-lib-calls-exit /usr/lib64/libdb_java-5.3.so exit@GLIBC_2.2.5 libdb-java.x86_64: W: no-documentation libdb-java-devel.x86_64: W: no-documentation 13 packages and 0 specfiles checked; 1 errors, 32 warnings. Requires -------- libdb-sql (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb(x86-64) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb-tcl-devel (rpmlib, GLIBC filtered): libdb-tcl(x86-64) libdb-tcl (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb(x86-64) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb-java (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb(x86-64) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb-java-devel (rpmlib, GLIBC filtered): libdb-java(x86-64) libdb-utils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdb(x86-64) libdb-5.3.so()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb-devel-static (rpmlib, GLIBC filtered): libdb-devel(x86-64) libdb-cxx-devel (rpmlib, GLIBC filtered): libdb-cxx(x86-64) libdb-devel(x86-64) libdb-cxx (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb(x86-64) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) libdb-devel-doc (rpmlib, GLIBC filtered): libdb libdb-devel libdb-sql-devel (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdb-sql(x86-64) libdb_sql-5.3.so()(64bit) libdl.so.2()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb-devel (rpmlib, GLIBC filtered): libdb(x86-64) Provides -------- libdb-sql: libdb-sql libdb-sql(x86-64) libdb_sql-5.3.so()(64bit) libdb-tcl-devel: libdb-tcl-devel libdb-tcl-devel(x86-64) libdb-tcl: libdb-tcl libdb-tcl(x86-64) libdb_tcl-5.3.so()(64bit) libdb-java: libdb-java libdb-java(x86-64) libdb_java-5.3.so()(64bit) libdb: libdb libdb(x86-64) libdb-5.3.so()(64bit) libdb-java-devel: libdb-java-devel libdb-java-devel(x86-64) libdb-utils: libdb-utils libdb-utils(x86-64) libdb-devel-static: libdb-devel-static libdb-devel-static(x86-64) libdb-cxx-devel: libdb-cxx-devel libdb-cxx-devel(x86-64) libdb-cxx: libdb-cxx libdb-cxx(x86-64) libdb_cxx-5.3.so()(64bit) libdb-devel-doc: libdb-devel-doc libdb-sql-devel: libdb-sql-devel libdb-sql-devel(x86-64) libdb-devel: libdb-devel libdb-devel(x86-64) Unversioned so-files -------------------- libdb: /usr/lib64/libdb-5.3.so libdb: /usr/lib64/libdb-5.so libdb-cxx: /usr/lib64/libdb_cxx-5.3.so libdb-cxx: /usr/lib64/libdb_cxx-5.so libdb-tcl: /usr/lib64/libdb_tcl-5.3.so libdb-tcl: /usr/lib64/libdb_tcl-5.so libdb-sql: /usr/lib64/libdb_sql-5.3.so libdb-sql: /usr/lib64/libdb_sql-5.so libdb-java: /usr/lib64/libdb_java-5.3.so libdb-java: /usr/lib64/libdb_java-5.3_g.so libdb-java: /usr/lib64/libdb_java-5.so MD5-sum check ------------- http://download.oracle.com/berkeley-db/db-5.3.21.tar.gz : CHECKSUM(SHA256) this package : ddd92a930317df92021054c03992392db9ea5cddba43bef8920d392a82114fb8 CHECKSUM(SHA256) upstream package : ddd92a930317df92021054c03992392db9ea5cddba43bef8920d392a82114fb8 http://download.oracle.com/berkeley-db/db.1.85.tar.gz : CHECKSUM(SHA256) this package : 4220d4ddeb77fb57ba2f37c1aa105d561d3ef85a6fb89c79c3edd735d0e193c6 CHECKSUM(SHA256) upstream package : 4220d4ddeb77fb57ba2f37c1aa105d561d3ef85a6fb89c79c3edd735d0e193c6 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn libdb -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires