Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Header files in -devel subpackage, if present. Note: libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/csv/csv.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/csv/csv_extern.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/ex_apprec/ex_apprec.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/ex_apprec/ex_apprec_auto.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/ex_rep/base/rep_base.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/ex_rep/common/rep_common.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_c/getting_started/gettingstarted_common.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/excxx_repquote/RepConfigInfo.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/excxx_repquote/dbc_auto.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/excxx_repquote_gsg/RepConfigInfo.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/excxx_repquote_gsg/SimpleConfigInfo.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/wce_tpcb/TpcbExample.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/wce_tpcb/newres.h libdb4-doc : /usr/share/doc/libdb4-doc-4.8.30/examples_cxx/wce_tpcb/resource.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in libdb4-utils, libdb4-devel, libdb4-doc, libdb4-devel-static, libdb4-cxx, libdb4-cxx-devel, libdb4-tcl, libdb4-tcl-devel, libdb4-java, libdb4-java-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Large documentation must go in a -doc subpackage. Note: Documentation size is 46172160 bytes in 2612 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libdb4-doc , libdb4-devel-static , libdb4-cxx-devel , libdb4-tcl-devel , libdb4 -java-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Test run failed Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define __soversion_major 4 %define __soversion %{__soversion_major}.8 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: libdb4-4.8.30-5.fc18.x86_64.rpm libdb4-utils-4.8.30-5.fc18.x86_64.rpm libdb4-devel-4.8.30-5.fc18.x86_64.rpm libdb4-doc-4.8.30-5.fc18.noarch.rpm libdb4-devel-static-4.8.30-5.fc18.x86_64.rpm libdb4-cxx-4.8.30-5.fc18.x86_64.rpm libdb4-cxx-devel-4.8.30-5.fc18.x86_64.rpm libdb4-tcl-4.8.30-5.fc18.x86_64.rpm libdb4-tcl-devel-4.8.30-5.fc18.x86_64.rpm libdb4-java-4.8.30-5.fc18.x86_64.rpm libdb4-java-devel-4.8.30-5.fc18.x86_64.rpm libdb4.x86_64: W: self-obsoletion db4 < 5.0.0 obsoletes db4 = 4.8.30 libdb4-utils.x86_64: W: self-obsoletion db4-utils < 5.0.0 obsoletes db4-utils = 4.8.30 libdb4-utils.x86_64: W: no-documentation libdb4-utils.x86_64: W: no-manual-page-for-binary db4_sql libdb4-utils.x86_64: W: no-manual-page-for-binary db4_archive libdb4-utils.x86_64: W: no-manual-page-for-binary db4_printlog libdb4-utils.x86_64: W: no-manual-page-for-binary db4_recover libdb4-utils.x86_64: W: no-manual-page-for-binary db4_dump libdb4-utils.x86_64: W: no-manual-page-for-binary db4_dump185 libdb4-utils.x86_64: W: no-manual-page-for-binary db4_hotbackup libdb4-utils.x86_64: W: no-manual-page-for-binary db4_checkpoint libdb4-utils.x86_64: W: no-manual-page-for-binary db4_load libdb4-utils.x86_64: W: no-manual-page-for-binary db4_upgrade libdb4-utils.x86_64: W: no-manual-page-for-binary db4_verify libdb4-utils.x86_64: W: no-manual-page-for-binary db4_deadlock libdb4-utils.x86_64: W: no-manual-page-for-binary db4_stat libdb4-devel.x86_64: W: self-obsoletion db4-devel < 5.0.0 obsoletes db4-devel = 4.8.30 libdb4-devel.x86_64: W: only-non-binary-in-usr-lib libdb4-devel.x86_64: W: no-documentation libdb4-doc.noarch: W: self-obsoletion db4-devel-doc < 5.0.0 obsoletes db4-devel-doc = 4.8.30 libdb4-devel-static.x86_64: W: self-obsoletion db4-devel-static < 5.0.0 obsoletes db4-devel-static = 4.8.30 libdb4-devel-static.x86_64: W: no-documentation libdb4-cxx.x86_64: W: self-obsoletion db4-cxx < 5.0.0 obsoletes db4-cxx = 4.8.30 libdb4-cxx.x86_64: W: no-documentation libdb4-cxx-devel.x86_64: W: self-obsoletion db4-cxx-devel < 5.0.0 obsoletes db4-cxx-devel = 4.8.30 libdb4-cxx-devel.x86_64: W: only-non-binary-in-usr-lib libdb4-cxx-devel.x86_64: W: no-documentation libdb4-tcl.x86_64: W: self-obsoletion db4-tcl < 5.0.0 obsoletes db4-tcl = 4.8.30 libdb4-tcl.x86_64: W: no-documentation libdb4-tcl-devel.x86_64: W: self-obsoletion db4-tcl-devel < 5.0.0 obsoletes db4-tcl-devel = 4.8.30 libdb4-tcl-devel.x86_64: W: only-non-binary-in-usr-lib libdb4-tcl-devel.x86_64: W: no-documentation libdb4-java.x86_64: W: self-obsoletion db4-java < 5.0.0 obsoletes db4-java = 4.8.30 libdb4-java.x86_64: W: no-documentation libdb4-java-devel.x86_64: W: self-obsoletion db4-java-devel < 5.0.0 obsoletes db4-java-devel = 4.8.30 libdb4-java-devel.x86_64: W: only-non-binary-in-usr-lib libdb4-java-devel.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 0 errors, 37 warnings. Requires -------- libdb4-tcl (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb4(x86-64) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb4-utils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdb-4.8.so()(64bit) libdb4(x86-64) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb4-devel-static (rpmlib, GLIBC filtered): libdb4-devel(x86-64) libdb4-cxx (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb4(x86-64) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) libdb4-devel (rpmlib, GLIBC filtered): libdb4(x86-64) libdb4-cxx-devel (rpmlib, GLIBC filtered): libdb4-cxx(x86-64) libdb4-devel(x86-64) libdb4-tcl-devel (rpmlib, GLIBC filtered): libdb4-tcl(x86-64) libdb4-java (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdb4(x86-64) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb4-doc (rpmlib, GLIBC filtered): libdb4 (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdb4-java-devel (rpmlib, GLIBC filtered): libdb4-java(x86-64) Provides -------- libdb4-tcl: db4-tcl libdb4-tcl libdb4-tcl(x86-64) libdb_tcl-4.8.so()(64bit) libdb4-utils: db4-utils libdb4-utils libdb4-utils(x86-64) libdb4-devel-static: db4-devel-static libdb4-devel-static libdb4-devel-static(x86-64) libdb4-cxx: db4-cxx libdb4-cxx libdb4-cxx(x86-64) libdb_cxx-4.8.so()(64bit) libdb4-devel: db4-devel libdb4-devel libdb4-devel(x86-64) libdb4-cxx-devel: db4-cxx-devel libdb4-cxx-devel libdb4-cxx-devel(x86-64) libdb4-tcl-devel: db4-tcl-devel libdb4-tcl-devel libdb4-tcl-devel(x86-64) libdb4-java: db4-java libdb4-java libdb4-java(x86-64) libdb_java-4.8.so()(64bit) libdb4-doc: db4-devel-doc libdb4-doc libdb4: db4 libdb-4.8.so()(64bit) libdb4 libdb4(x86-64) libdb4-java-devel: db4-java-devel libdb4-java-devel libdb4-java-devel(x86-64) Unversioned so-files -------------------- libdb4: /usr/lib64/libdb-4.8.so libdb4: /usr/lib64/libdb-4.so libdb4-cxx: /usr/lib64/libdb_cxx-4.8.so libdb4-cxx: /usr/lib64/libdb_cxx-4.so libdb4-tcl: /usr/lib64/libdb_tcl-4.8.so libdb4-tcl: /usr/lib64/libdb_tcl-4.so libdb4-java: /usr/lib64/libdb_java-4.8.so libdb4-java: /usr/lib64/libdb_java-4.8_g.so libdb4-java: /usr/lib64/libdb_java-4.so MD5-sum check ------------- http://download.oracle.com/berkeley-db/db-4.8.30.tar.gz : CHECKSUM(SHA256) this package : e0491a07cdb21fb9aa82773bbbedaeb7639cbd0e7f96147ab46141e0045db72a CHECKSUM(SHA256) upstream package : e0491a07cdb21fb9aa82773bbbedaeb7639cbd0e7f96147ab46141e0045db72a http://download.oracle.com/berkeley-db/db.1.85.tar.gz : CHECKSUM(SHA256) this package : 4220d4ddeb77fb57ba2f37c1aa105d561d3ef85a6fb89c79c3edd735d0e193c6 CHECKSUM(SHA256) upstream package : 4220d4ddeb77fb57ba2f37c1aa105d561d3ef85a6fb89c79c3edd735d0e193c6 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn libdb4 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires