Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ldb-tools , libldb-devel , pyldb , pyldb-devel [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define talloc_version 2.0.8 %define tdb_version 1.2.11 %define tevent_version 0.9.17 [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: libldb-1.1.14-1.fc19.x86_64.rpm ldb-tools-1.1.14-1.fc19.x86_64.rpm libldb-devel-1.1.14-1.fc19.x86_64.rpm pyldb-1.1.14-1.fc19.x86_64.rpm pyldb-devel-1.1.14-1.fc19.x86_64.rpm libldb.x86_64: W: spelling-error Summary(en_US) ldap -> lap, leap, dapple libldb.x86_64: W: spelling-error %description -l en_US tdb -> db, tab, tub libldb.x86_64: W: shared-lib-calls-exit /usr/lib64/libldb.so.1.1.14 exit@GLIBC_2.2.5 libldb.x86_64: W: no-documentation pyldb.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/ldb.so ldb.so()(64bit) pyldb.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- libldb-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libldb libldb.so.1()(64bit) libtalloc-devel libtdb-devel libtevent-devel pkgconfig pkgconfig(talloc) pkgconfig(tdb) ldb-tools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libldb libldb-cmdline.so()(64bit) libldb-cmdline.so(LDB_1.1.14)(64bit) libldb.so.1()(64bit) libldb.so.1(LDB_0.9.10)(64bit) libldb.so.1(LDB_0.9.15)(64bit) libldb.so.1(LDB_0.9.18)(64bit) libldb.so.1(LDB_0.9.19)(64bit) libldb.so.1(LDB_1.1.0)(64bit) libldb.so.1(LDB_1.1.5)(64bit) libpopt.so.0()(64bit) libpopt.so.0(LIBPOPT_0)(64bit) libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) libtdb.so.1()(64bit) libtevent.so.0()(64bit) rtld(GNU_HASH) pyldb-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libpyldb-util.so.1()(64bit) pkgconfig(ldb) pyldb libldb (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libldb.so.1()(64bit) libldb.so.1(LDB_0.9.10)(64bit) libldb.so.1(LDB_0.9.15)(64bit) libldb.so.1(LDB_0.9.22)(64bit) libldb.so.1(LDB_1.1.14)(64bit) libldb.so.1(LDB_1.1.6)(64bit) libtalloc libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) libtdb libtdb.so.1()(64bit) libtdb.so.1(TDB_1.2.1)(64bit) libtevent libtevent.so.0()(64bit) libtevent.so.0(TEVENT_0.9.9)(64bit) rtld(GNU_HASH) pyldb (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libldb libldb.so.1()(64bit) libldb.so.1(LDB_0.9.10)(64bit) libldb.so.1(LDB_0.9.15)(64bit) libldb.so.1(LDB_1.0.2)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpyldb-util.so.1()(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.2)(64bit) libpython2.7.so.1.0()(64bit) libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) libtdb.so.1()(64bit) libtevent.so.0()(64bit) libutil.so.1()(64bit) python(abi) python-tdb rtld(GNU_HASH) Provides -------- libldb-devel: libldb-devel libldb-devel(x86-64) pkgconfig(ldb) ldb-tools: ldb-tools ldb-tools(x86-64) libldb-cmdline.so()(64bit) libldb-cmdline.so(LDB_1.1.14)(64bit) pyldb-devel: pkgconfig(pyldb-util) pyldb-devel pyldb-devel(x86-64) libldb: asq.so()(64bit) bundled(libreplace) bundled(libtdb_compat) libldb libldb(x86-64) libldb.so.1()(64bit) libldb.so.1(LDB_0.9.10)(64bit) libldb.so.1(LDB_0.9.12)(64bit) libldb.so.1(LDB_0.9.15)(64bit) libldb.so.1(LDB_0.9.16)(64bit) libldb.so.1(LDB_0.9.17)(64bit) libldb.so.1(LDB_0.9.18)(64bit) libldb.so.1(LDB_0.9.19)(64bit) libldb.so.1(LDB_0.9.20)(64bit) libldb.so.1(LDB_0.9.22)(64bit) libldb.so.1(LDB_0.9.23)(64bit) libldb.so.1(LDB_0.9.24)(64bit) libldb.so.1(LDB_1.0.0)(64bit) libldb.so.1(LDB_1.0.1)(64bit) libldb.so.1(LDB_1.0.2)(64bit) libldb.so.1(LDB_1.1.0)(64bit) libldb.so.1(LDB_1.1.1)(64bit) libldb.so.1(LDB_1.1.10)(64bit) libldb.so.1(LDB_1.1.11)(64bit) libldb.so.1(LDB_1.1.12)(64bit) libldb.so.1(LDB_1.1.13)(64bit) libldb.so.1(LDB_1.1.14)(64bit) libldb.so.1(LDB_1.1.2)(64bit) libldb.so.1(LDB_1.1.3)(64bit) libldb.so.1(LDB_1.1.4)(64bit) libldb.so.1(LDB_1.1.5)(64bit) libldb.so.1(LDB_1.1.6)(64bit) libldb.so.1(LDB_1.1.7)(64bit) libldb.so.1(LDB_1.1.8)(64bit) libldb.so.1(LDB_1.1.9)(64bit) paged_results.so()(64bit) paged_searches.so()(64bit) rdn_name.so()(64bit) sample.so()(64bit) server_sort.so()(64bit) skel.so()(64bit) tdb.so()(64bit) pyldb: ldb.so()(64bit) libpyldb-util.so.1()(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.10)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.11)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.12)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.13)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.14)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.2)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.3)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.4)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.5)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.6)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.7)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.8)(64bit) libpyldb-util.so.1(PYLDB_UTIL_1.1.9)(64bit) pyldb pyldb(x86-64) Unversioned so-files -------------------- libldb: /usr/lib64/ldb/modules/ldb/asq.so libldb: /usr/lib64/ldb/modules/ldb/paged_results.so libldb: /usr/lib64/ldb/modules/ldb/paged_searches.so libldb: /usr/lib64/ldb/modules/ldb/rdn_name.so libldb: /usr/lib64/ldb/modules/ldb/sample.so libldb: /usr/lib64/ldb/modules/ldb/server_sort.so libldb: /usr/lib64/ldb/modules/ldb/skel.so libldb: /usr/lib64/ldb/modules/ldb/tdb.so ldb-tools: /usr/lib64/ldb/libldb-cmdline.so pyldb: /usr/lib64/python2.7/site-packages/ldb.so MD5-sum check ------------- http://samba.org/ftp/ldb/ldb-1.1.14.tar.gz : CHECKSUM(SHA256) this package : d0c83ecb7619dea65373af8fc5e89720e3aa1c48ff10f12cc132d335c5ee1e32 CHECKSUM(SHA256) upstream package : d0c83ecb7619dea65373af8fc5e89720e3aa1c48ff10f12cc132d335c5ee1e32 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn libldb -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires