Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in libreport-web See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libreport- filesystem , libreport-devel , libreport-web , libreport-web-devel , libreport-python , libreport-cli , libreport-newt , libreport-gtk , libreport-gtk-devel , libreport-plugin-kerneloops , libreport-plugin- logger , libreport-plugin-mailx , libreport-plugin-bugzilla , libreport- plugin-ureport , libreport-plugin-rhtsupport , libreport-compat , libreport-plugin-reportuploader , libreport-fedora , libreport-anaconda [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %{!?python_site: %define python_site %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(0)")} %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1259520 bytes in /usr/share 10240 libreport-plugin-mailx-2.0.20-1.fc19.x86_64.rpm 10240 libreport-plugin- kerneloops-2.0.20-1.fc19.x86_64.rpm 10240 libreport- compat-2.0.20-1.fc19.x86_64.rpm 10240 libreport-plugin- rhtsupport-2.0.20-1.fc19.x86_64.rpm 10240 libreport-plugin- logger-2.0.20-1.fc19.x86_64.rpm 10240 libreport-plugin- reportuploader-2.0.20-1.fc19.x86_64.rpm 10240 libreport- cli-2.0.20-1.fc19.x86_64.rpm 10240 libreport-plugin- bugzilla-2.0.20-1.fc19.x86_64.rpm 1177600 libreport-2.0.20-1.fc19.x86_64.rpm Rpmlint ------- Checking: libreport-2.0.20-1.fc19.x86_64.rpm libreport-filesystem-2.0.20-1.fc19.x86_64.rpm libreport-devel-2.0.20-1.fc19.x86_64.rpm libreport-web-2.0.20-1.fc19.x86_64.rpm libreport-web-devel-2.0.20-1.fc19.x86_64.rpm libreport-python-2.0.20-1.fc19.x86_64.rpm libreport-cli-2.0.20-1.fc19.x86_64.rpm libreport-newt-2.0.20-1.fc19.x86_64.rpm libreport-gtk-2.0.20-1.fc19.x86_64.rpm libreport-gtk-devel-2.0.20-1.fc19.x86_64.rpm libreport-plugin-kerneloops-2.0.20-1.fc19.x86_64.rpm libreport-plugin-logger-2.0.20-1.fc19.x86_64.rpm libreport-plugin-mailx-2.0.20-1.fc19.x86_64.rpm libreport-plugin-bugzilla-2.0.20-1.fc19.x86_64.rpm libreport-plugin-ureport-2.0.20-1.fc19.x86_64.rpm libreport-plugin-rhtsupport-2.0.20-1.fc19.x86_64.rpm libreport-compat-2.0.20-1.fc19.x86_64.rpm libreport-plugin-reportuploader-2.0.20-1.fc19.x86_64.rpm libreport-fedora-2.0.20-1.fc19.x86_64.rpm libreport-anaconda-2.0.20-1.fc19.x86_64.rpm libreport.x86_64: E: explicit-lib-dependency libreport-filesystem libreport.x86_64: W: spelling-error %description -l en_US trac -> trace, tract, track libreport-filesystem.x86_64: W: no-documentation libreport-devel.x86_64: W: no-documentation libreport-web.x86_64: W: non-standard-group Libraries libreport-web.x86_64: W: no-documentation libreport-web.x86_64: E: library-without-ldconfig-postin /usr/lib64/libreport-web.so.0.0.1 libreport-web.x86_64: E: library-without-ldconfig-postun /usr/lib64/libreport-web.so.0.0.1 libreport-web.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libreport-web.so libreport-web-devel.x86_64: W: no-documentation libreport-python.x86_64: W: spelling-error Summary(en_US) libs -> lobs, lib, lbs libreport-python.x86_64: W: spelling-error %description -l en_US libs -> lobs, lib, lbs libreport-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/report/_pyreport.so _pyreport.so()(64bit) libreport-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/reportclient/_reportclient.so _reportclient.so()(64bit) libreport-python.x86_64: W: no-documentation libreport-cli.x86_64: W: summary-not-capitalized C libreport's command line interface libreport-newt.x86_64: W: summary-not-capitalized C libreport's newt interface libreport-newt.x86_64: W: no-documentation libreport-newt.x86_64: W: no-manual-page-for-binary report-newt libreport-gtk.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end libreport-gtk.x86_64: W: no-documentation libreport-gtk.x86_64: W: no-manual-page-for-binary report-gtk libreport-gtk-devel.x86_64: W: no-documentation libreport-plugin-kerneloops.x86_64: W: summary-not-capitalized C libreport's kerneloops reporter plugin libreport-plugin-kerneloops.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_Kerneloops.xml libreport-plugin-logger.x86_64: W: summary-not-capitalized C libreport's logger reporter plugin libreport-plugin-logger.x86_64: W: obsolete-not-provided abrt-plugin-logger libreport-plugin-logger.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_Logger.conf libreport-plugin-logger.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_Logger.xml libreport-plugin-mailx.x86_64: W: summary-not-capitalized C libreport's mailx reporter plugin libreport-plugin-mailx.x86_64: W: obsolete-not-provided abrt-plugin-mailx libreport-plugin-mailx.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_Mailx.xml libreport-plugin-bugzilla.x86_64: W: summary-not-capitalized C libreport's bugzilla plugin libreport-plugin-bugzilla.x86_64: W: obsolete-not-provided abrt-plugin-bugzilla libreport-plugin-bugzilla.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_Bugzilla.xml libreport-plugin-ureport.x86_64: W: summary-not-capitalized C libreport's micro report plugin libreport-plugin-ureport.x86_64: W: spelling-error %description -l en_US abrt -> abet, art, abort libreport-plugin-ureport.x86_64: W: no-documentation libreport-plugin-ureport.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_uReport.xml libreport-plugin-ureport.x86_64: W: no-manual-page-for-binary reporter-ureport libreport-plugin-rhtsupport.x86_64: W: summary-not-capitalized C libreport's RHTSupport plugin libreport-plugin-rhtsupport.x86_64: W: obsolete-not-provided abrt-plugin-rhtsupport libreport-plugin-rhtsupport.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_RHTSupport.xml libreport-compat.x86_64: W: summary-not-capitalized C libreport's compat layer for obsoleted 'report' package libreport-plugin-reportuploader.x86_64: W: summary-not-capitalized C libreport's reportuploader plugin libreport-plugin-reportuploader.x86_64: W: obsolete-not-provided abrt-plugin-reportuploader libreport-plugin-reportuploader.x86_64: W: non-conffile-in-etc /etc/libreport/events/report_Uploader.xml libreport-plugin-reportuploader.x86_64: W: non-conffile-in-etc /etc/libreport/workflows/workflow_Upload.xml libreport-fedora.x86_64: W: spelling-error %description -l en_US sytems -> stems, systems, system libreport-fedora.x86_64: W: no-documentation libreport-fedora.x86_64: W: non-conffile-in-etc /etc/libreport/workflows/workflow_Fedora.xml libreport-anaconda.x86_64: E: explicit-lib-dependency libreport-plugin-bugzilla libreport-anaconda.x86_64: E: explicit-lib-dependency libreport-plugin-reportuploader libreport-anaconda.x86_64: W: spelling-error %description -l en_US scp -> cps, sci, sip libreport-anaconda.x86_64: W: no-documentation libreport-anaconda.x86_64: W: non-conffile-in-etc /etc/libreport/workflows/workflow_AnacondaFedora.xml libreport-anaconda.x86_64: W: non-conffile-in-etc /etc/libreport/workflows/workflow_AnacondaUpload.xml 20 packages and 0 specfiles checked; 5 errors, 52 warnings. Requires -------- libreport-gtk (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libreport libreport-gtk.so.0()(64bit) libreport.so.0()(64bit) recordmydesktop rtld(GNU_HASH) libreport-python (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libreport libreport.so.0()(64bit) python(abi) rtld(GNU_HASH) libreport-plugin-mailx (rpmlib, GLIBC filtered): config(libreport-plugin-mailx) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libreport libreport.so.0()(64bit) mailx rtld(GNU_HASH) libreport-plugin-reportuploader (rpmlib, GLIBC filtered): config(libreport-plugin-reportuploader) libbtparser.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libjson.so.0()(64bit) libproxy.so.1()(64bit) libreport libreport-web.so.0()(64bit) libreport.so.0()(64bit) libtar.so.1()(64bit) libxml2.so.2()(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.3()(64bit) rtld(GNU_HASH) libreport-plugin-rhtsupport (rpmlib, GLIBC filtered): config(libreport-plugin-rhtsupport) libbtparser.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libjson.so.0()(64bit) libproxy.so.1()(64bit) libreport libreport-web.so.0()(64bit) libreport.so.0()(64bit) libtar.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.3()(64bit) rtld(GNU_HASH) libreport-plugin-logger (rpmlib, GLIBC filtered): config(libreport-plugin-logger) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libreport libreport.so.0()(64bit) rtld(GNU_HASH) libreport-anaconda (rpmlib, GLIBC filtered): config(libreport-anaconda) libreport-plugin-bugzilla libreport-plugin-reportuploader libreport-compat (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libreport libreport-plugin-bugzilla libreport-plugin-rhtsupport libreport.so.0()(64bit) rtld(GNU_HASH) libreport-web (rpmlib, GLIBC filtered): libbtparser.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libjson.so.0()(64bit) libproxy.so.1()(64bit) libreport libreport-web.so.0()(64bit) libreport.so.0()(64bit) libxml2.so.2()(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.3()(64bit) rtld(GNU_HASH) libreport-web-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libreport-web pkgconfig(btparser) pkgconfig(glib-2.0) pkgconfig(json) pkgconfig(libcurl) pkgconfig(libproxy-1.0) pkgconfig(libreport) pkgconfig(libxml-2.0) pkgconfig(xmlrpc) pkgconfig(xmlrpc_client) libreport-filesystem (rpmlib, GLIBC filtered): libreport-gtk-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libreport-gtk libreport-gtk.so.0()(64bit) pkgconfig(libreport) libreport-plugin-bugzilla (rpmlib, GLIBC filtered): config(libreport-plugin-bugzilla) libbtparser.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libjson.so.0()(64bit) libproxy.so.1()(64bit) libreport libreport-web.so.0()(64bit) libreport.so.0()(64bit) libxml2.so.2()(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.3()(64bit) rtld(GNU_HASH) libreport (rpmlib, GLIBC filtered): /sbin/ldconfig config(libreport) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libglib-2.0.so.0()(64bit) libreport-filesystem libreport-python libreport.so.0()(64bit) rtld(GNU_HASH) libreport-plugin-kerneloops (rpmlib, GLIBC filtered): curl libbtparser.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libjson.so.0()(64bit) libproxy.so.1()(64bit) libreport libreport-web.so.0()(64bit) libreport.so.0()(64bit) libxml2.so.2()(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.3()(64bit) rtld(GNU_HASH) libreport-newt (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libnewt.so.0.52()(64bit) libnewt.so.0.52(NEWT_0.52)(64bit) libreport libreport.so.0()(64bit) rtld(GNU_HASH) libreport-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libabrt_dbus.so.0()(64bit) libreport libreport.so.0()(64bit) pkgconfig(glib-2.0) libreport-fedora (rpmlib, GLIBC filtered): config(libreport-fedora) libreport-plugin-ureport (rpmlib, GLIBC filtered): libbtparser.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libjson.so.0()(64bit) libproxy.so.1()(64bit) libreport libreport-web.so.0()(64bit) libreport.so.0()(64bit) libxml2.so.2()(64bit) libxmlrpc.so.3()(64bit) libxmlrpc_client.so.3()(64bit) libxmlrpc_util.so.3()(64bit) rtld(GNU_HASH) libreport-cli (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libreport libreport.so.0()(64bit) rtld(GNU_HASH) Provides -------- libreport-gtk: libreport-gtk libreport-gtk(x86-64) libreport-gtk.so.0()(64bit) report-gtk libreport-python: _pyreport.so()(64bit) _reportclient.so()(64bit) libreport-python libreport-python(x86-64) report libreport-plugin-mailx: config(libreport-plugin-mailx) libreport-plugin-mailx libreport-plugin-mailx(x86-64) libreport-plugin-reportuploader: config(libreport-plugin-reportuploader) libreport-plugin-reportuploader libreport-plugin-reportuploader(x86-64) report-config-ftp report-config-scp report-plugin-ftp report-plugin-scp libreport-plugin-rhtsupport: config(libreport-plugin-rhtsupport) libreport-plugin-rhtsupport libreport-plugin-rhtsupport(x86-64) libreport-plugin-logger: config(libreport-plugin-logger) libreport-plugin-logger libreport-plugin-logger(x86-64) report-config-localsave report-plugin-localsave libreport-anaconda: config(libreport-anaconda) libreport-anaconda libreport-anaconda(x86-64) libreport-compat: libreport-compat libreport-compat(x86-64) libreport-web: libreport-web libreport-web(x86-64) libreport-web.so.0()(64bit) libreport-web-devel: libreport-web-devel libreport-web-devel(x86-64) pkgconfig(libreport-web) libreport-filesystem: libreport-filesystem libreport-filesystem(x86-64) libreport-gtk-devel: libreport-gtk-devel libreport-gtk-devel(x86-64) pkgconfig(libreport-gtk) libreport-plugin-bugzilla: config(libreport-plugin-bugzilla) libreport-plugin-bugzilla libreport-plugin-bugzilla(x86-64) report-config-bugzilla-redhat-com report-plugin-bugzilla libreport: config(libreport) libabrt_dbus.so.0()(64bit) libreport libreport(x86-64) libreport.so.0()(64bit) libreport-plugin-kerneloops: libreport-plugin-kerneloops libreport-plugin-kerneloops(x86-64) libreport-newt: libreport-newt libreport-newt(x86-64) report-newt libreport-devel: libreport-devel libreport-devel(x86-64) pkgconfig(libreport) libreport-fedora: config(libreport-fedora) libreport-fedora libreport-fedora(x86-64) libreport-plugin-ureport: libreport-plugin-ureport libreport-plugin-ureport(x86-64) libreport-cli: libreport-cli libreport-cli(x86-64) Unversioned so-files -------------------- libreport-web: /usr/lib64/libreport-web.so libreport-python: /usr/lib64/python2.7/site-packages/report/_pyreport.so libreport-python: /usr/lib64/python2.7/site-packages/reportclient/_reportclient.so MD5-sum check ------------- https://fedorahosted.org/released/abrt/libreport-2.0.20.tar.gz : CHECKSUM(SHA256) this package : a2a66b97e1e345f18837f39657210931bd6cb9bebc33f56736e56380ddbf743e CHECKSUM(SHA256) upstream package : a2a66b97e1e345f18837f39657210931bd6cb9bebc33f56736e56380ddbf743e Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn libreport -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires