Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: linux-firmware : /lib/firmware/isci/create_fw.h linux-firmware : /lib/firmware/isci/probe_roms.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Large documentation must go in a -doc subpackage. Note: Documentation size is 1423360 bytes in 59 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libertas- usb8388-firmware , libertas-usb8388-olpc-firmware , libertas- sd8686-firmware , libertas-sd8787-firmware [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0 [!]: Reviewer should test that the package builds in mock. [!]: Dist tag is present. Note: Multiple Release tags found [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: linux-firmware-20121218-0.2.gitbda53ca.fc19.noarch.rpm libertas-usb8388-firmware-20121218-0.2.gitbda53ca.fc19.noarch.rpm libertas-usb8388-olpc-firmware-20121218-0.2.gitbda53ca.fc19.noarch.rpm libertas-sd8686-firmware-20121218-0.2.gitbda53ca.fc19.noarch.rpm libertas-sd8787-firmware-20121218-0.2.gitbda53ca.fc19.noarch.rpm linux-firmware.noarch: W: obsolete-not-provided ueagle-atm4-firmware linux-firmware.noarch: W: obsolete-not-provided netxen-firmware linux-firmware.noarch: W: obsolete-not-provided ql2100-firmware linux-firmware.noarch: W: obsolete-not-provided ql2200-firmware linux-firmware.noarch: W: obsolete-not-provided ql23xx-firmware linux-firmware.noarch: W: obsolete-not-provided rt61pci-firmware linux-firmware.noarch: W: obsolete-not-provided rt73usb-firmware linux-firmware.noarch: W: devel-file-in-non-devel-package /lib/firmware/isci/create_fw.h linux-firmware.noarch: W: devel-file-in-non-devel-package /lib/firmware/isci/create_fw.c linux-firmware.noarch: W: devel-file-in-non-devel-package /lib/firmware/isci/probe_roms.h linux-firmware.noarch: E: non-executable-script /lib/firmware/configure 0644L /bin/bash 5 packages and 0 specfiles checked; 1 errors, 10 warnings. Requires -------- libertas-sd8686-firmware (rpmlib, GLIBC filtered): libertas-sd8787-firmware (rpmlib, GLIBC filtered): libertas-usb8388-firmware (rpmlib, GLIBC filtered): linux-firmware (rpmlib, GLIBC filtered): libertas-usb8388-olpc-firmware (rpmlib, GLIBC filtered): Provides -------- libertas-sd8686-firmware: libertas-sd8686-firmware libertas-sd8787-firmware: libertas-sd8787-firmware libertas-usb8388-firmware: libertas-usb8388-firmware linux-firmware: kernel-firmware linux-firmware xorg-x11-drv-ati-firmware libertas-usb8388-olpc-firmware: libertas-usb8388-olpc-firmware Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn linux-firmware -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires