Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lvm2-devel , lvm2-libs , lvm2-python-libs , lvm2-cluster , cmirror , lvm2-sysvinit [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 337920 bytes in 14 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0 [!]: Reviewer should test that the package builds in mock. [!]: Dist tag is present. Note: Multiple Release tags found [!]: Spec use %global instead of %define. Note: %define device_mapper_version 1.02.77 %define enable_thin 1 %define enable_lvmetad 1 %define enable_cluster 1 %define enable_cmirror 1 %define systemd_version 189-3 %define dracut_version 002-18 %define util- linux_version 2.22.1 %define bash_version 4.0 %define corosync_version 1.99.9-1 %define dlm_version 3.99.1-1 %define libselinux_version 1.30.19-4 %define persistent_data_version 0.1.4 %define enable_cluster 0 %define enable_cmirror 0 %define configure_cluster --with- cluster=internal --with-clvmd=corosync %define configure_cmirror --enable-cmirrord %define configure_cluster --with-cluster=internal --with-clvmd=none %define _default_pid_dir /run %define _default_dm_run_dir /run %define _default_run_dir /run/lvm %define _default_locking_dir /run/lock/lvm %define _udevbasedir %{_prefix}/lib/udev %define _udevdir %{_udevbasedir}/rules.d %define _tmpfilesdir %{_prefix}/lib/tmpfiles.d %define configure_udev --with- udevdir=%{_udevdir} --enable-udev_sync %define configure_thin --with- thin=internal --with-thin-check=%{_sbindir}/thin_check %define configure_lvmetad --enable-lvmetad [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: lvm2-2.02.98-4.fc19.x86_64.rpm lvm2-devel-2.02.98-4.fc19.x86_64.rpm lvm2-libs-2.02.98-4.fc19.x86_64.rpm lvm2-python-libs-2.02.98-4.fc19.x86_64.rpm lvm2-cluster-2.02.98-4.fc19.x86_64.rpm cmirror-2.02.98-4.fc19.x86_64.rpm lvm2-sysvinit-2.02.98-4.fc19.x86_64.rpm lvm2.x86_64: W: spelling-error Summary(en_US) Userland -> User land, User-land, Slanderous lvm2.x86_64: W: spelling-error %description -l en_US mdadd -> daddy lvm2.x86_64: W: spelling-error %description -l en_US losetup -> lo setup, lo-setup, setup lvm2.x86_64: E: non-standard-executable-perm /usr/lib/systemd/system-generators/lvm2-activation-generator 0555L lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/lvmdump 0555L lvm2.x86_64: E: incorrect-fsf-address /usr/sbin/lvmdump lvm2.x86_64: E: non-standard-dir-perm /run/lvm 0700L lvm2.x86_64: E: incorrect-fsf-address /usr/share/doc/lvm2-2.02.98/COPYING lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/fsadm 0555L lvm2.x86_64: E: incorrect-fsf-address /usr/sbin/fsadm lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/backup 0700L lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/blkdeactivate 0555L lvm2.x86_64: E: incorrect-fsf-address /usr/sbin/blkdeactivate lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/lvm 0555L lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/lvmetad 0555L lvm2.x86_64: E: non-standard-dir-perm /run/lock/lvm 0700L lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/lvmconf 0555L lvm2.x86_64: E: incorrect-fsf-address /usr/sbin/lvmconf lvm2.x86_64: W: hidden-file-or-dir /etc/lvm/cache/.cache lvm2.x86_64: E: non-readable /etc/lvm/cache/.cache 0600L lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/cache 0700L lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/archive 0700L lvm2.x86_64: E: non-standard-executable-perm /usr/sbin/vgimportclone 0555L lvm2.x86_64: E: incorrect-fsf-address /usr/sbin/vgimportclone lvm2.x86_64: W: install-file-in-docs /usr/share/doc/lvm2-2.02.98/INSTALL lvm2-devel.x86_64: W: no-documentation lvm2-devel.x86_64: E: incorrect-fsf-address /usr/include/lvm2app.h lvm2-devel.x86_64: E: incorrect-fsf-address /usr/include/lvm2cmd.h lvm2-libs.x86_64: W: no-documentation lvm2-libs.x86_64: E: non-standard-executable-perm /usr/lib64/device-mapper/libdevmapper-event-lvm2thin.so 0555L lvm2-libs.x86_64: E: non-standard-executable-perm /usr/lib64/device-mapper/libdevmapper-event-lvm2snapshot.so 0555L lvm2-libs.x86_64: E: non-standard-executable-perm /usr/lib64/device-mapper/libdevmapper-event-lvm2raid.so 0555L lvm2-libs.x86_64: E: non-standard-executable-perm /usr/lib64/device-mapper/libdevmapper-event-lvm2mirror.so 0555L lvm2-python-libs.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/lvm.so lvm.so()(64bit) lvm2-python-libs.x86_64: W: no-documentation lvm2-cluster.x86_64: W: spelling-error Summary(en_US) userland -> user land, user-land, slanderous lvm2-cluster.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/clvmd 0555L lvm2-cluster.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/clvmd lvm2-cluster.x86_64: W: incoherent-init-script-name clvmd ('lvm2-cluster', 'lvm2-clusterd') cmirror.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/cmirrord 0555L cmirror.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/cmirrord cmirror.x86_64: W: no-reload-entry /etc/rc.d/init.d/cmirrord lvm2-sysvinit.x86_64: W: spelling-error Summary(en_US) SysV -> Sysop lvm2-sysvinit.x86_64: W: spelling-error Summary(en_US) init -> unit, int, nit lvm2-sysvinit.x86_64: W: summary-ended-with-dot C SysV style init script for LVM2. lvm2-sysvinit.x86_64: W: spelling-error %description -l en_US SysV -> Sysop lvm2-sysvinit.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit lvm2-sysvinit.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d lvm2-sysvinit.x86_64: W: no-documentation lvm2-sysvinit.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/blk-availability 0555L lvm2-sysvinit.x86_64: E: incorrect-fsf-address /etc/rc.d/init.d/blk-availability lvm2-sysvinit.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/lvm2-monitor 0555L lvm2-sysvinit.x86_64: E: incorrect-fsf-address /etc/rc.d/init.d/lvm2-monitor lvm2-sysvinit.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/lvm2-lvmetad 0555L lvm2-sysvinit.x86_64: E: incorrect-fsf-address /etc/rc.d/init.d/lvm2-lvmetad lvm2-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/blk-availability lvm2-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/blk-availability lvm2-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/blk-availability lvm2-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/blk-availability lvm2-sysvinit.x86_64: W: no-reload-entry /etc/rc.d/init.d/blk-availability lvm2-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/lvm2-monitor lvm2-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/lvm2-monitor lvm2-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/lvm2-monitor lvm2-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/lvm2-monitor lvm2-sysvinit.x86_64: W: no-reload-entry /etc/rc.d/init.d/lvm2-monitor lvm2-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/lvm2-lvmetad lvm2-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/lvm2-lvmetad lvm2-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/lvm2-lvmetad lvm2-sysvinit.x86_64: E: malformed-line-in-lsb-comment-block # performance by avoiding further scans while running lvm2-sysvinit.x86_64: E: malformed-line-in-lsb-comment-block # subsequent LVM commands or while using lvm2app library. lvm2-sysvinit.x86_64: W: incoherent-subsys /etc/rc.d/init.d/lvm2-lvmetad $DAEMON lvm2-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/lvm2-lvmetad lvm2-sysvinit.x86_64: W: no-reload-entry /etc/rc.d/init.d/lvm2-lvmetad 7 packages and 0 specfiles checked; 42 errors, 31 warnings. Requires -------- lvm2 (rpmlib, GLIBC filtered): /bin/bash /bin/sh bash config(lvm2) device-mapper-persistent-data libc.so.6()(64bit) libdevmapper-event.so.1.02()(64bit) libdevmapper-event.so.1.02(Base)(64bit) libdevmapper.so.1.02()(64bit) libdevmapper.so.1.02(Base)(64bit) libdl.so.2()(64bit) liblvm2app.so.2.2()(64bit) liblvm2app.so.2.2(Base)(64bit) libpthread.so.0()(64bit) libreadline.so.6()(64bit) librt.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) lvm2-libs module-init-tools rtld(GNU_HASH) systemd-sysv systemd-units lvm2-cluster (rpmlib, GLIBC filtered): /bin/bash /bin/sh chkconfig corosync device-mapper dlm libc.so.6()(64bit) libcmap.so.4()(64bit) libcmap.so.4(COROSYNC_CMAP_1.0)(64bit) libcpg.so.4()(64bit) libcpg.so.4(COROSYNC_CPG_1.0)(64bit) libdevmapper-event.so.1.02()(64bit) libdevmapper-event.so.1.02(Base)(64bit) libdevmapper.so.1.02()(64bit) libdevmapper.so.1.02(Base)(64bit) libdl.so.2()(64bit) libdlm.so.3()(64bit) libpthread.so.0()(64bit) libquorum.so.5()(64bit) libquorum.so.5(COROSYNC_QUORUM_1.0)(64bit) librt.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) lvm2 rtld(GNU_HASH) lvm2-libs (rpmlib, GLIBC filtered): /sbin/ldconfig device-mapper-event libc.so.6()(64bit) libdevmapper-event-lvm2.so.2.02()(64bit) libdevmapper-event-lvm2.so.2.02(Base)(64bit) libdevmapper-event.so.1.02()(64bit) libdevmapper-event.so.1.02(Base)(64bit) libdevmapper.so.1.02()(64bit) libdevmapper.so.1.02(Base)(64bit) libdl.so.2()(64bit) liblvm2cmd.so.2.02()(64bit) liblvm2cmd.so.2.02(Base)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) rtld(GNU_HASH) lvm2-python-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) liblvm2app.so.2.2()(64bit) liblvm2app.so.2.2(Base)(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) lvm2-libs python(abi) rtld(GNU_HASH) lvm2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config device-mapper-devel device-mapper-event-devel libdevmapper-event-lvm2.so.2.02()(64bit) liblvm2app.so.2.2()(64bit) liblvm2cmd.so.2.02()(64bit) lvm2 pkgconfig pkgconfig(devmapper) cmirror (rpmlib, GLIBC filtered): /bin/bash /bin/sh chkconfig corosync device-mapper libc.so.6()(64bit) libcpg.so.4()(64bit) libcpg.so.4(COROSYNC_CPG_1.0)(64bit) libdevmapper.so.1.02()(64bit) libdevmapper.so.1.02(Base)(64bit) rtld(GNU_HASH) lvm2-sysvinit (rpmlib, GLIBC filtered): /bin/bash initscripts lvm2 Provides -------- lvm2: config(lvm2) lvm2 lvm2(x86-64) lvm2-cluster: lvm2-cluster lvm2-cluster(x86-64) lvm2-libs: libdevmapper-event-lvm2.so.2.02()(64bit) libdevmapper-event-lvm2.so.2.02(Base)(64bit) libdevmapper-event-lvm2mirror.so.2.02()(64bit) libdevmapper-event-lvm2mirror.so.2.02(Base)(64bit) libdevmapper-event-lvm2raid.so.2.02()(64bit) libdevmapper-event-lvm2raid.so.2.02(Base)(64bit) libdevmapper-event-lvm2snapshot.so.2.02()(64bit) libdevmapper-event-lvm2snapshot.so.2.02(Base)(64bit) libdevmapper-event-lvm2thin.so.2.02()(64bit) libdevmapper-event-lvm2thin.so.2.02(Base)(64bit) liblvm2app.so.2.2()(64bit) liblvm2app.so.2.2(Base)(64bit) liblvm2cmd.so.2.02()(64bit) liblvm2cmd.so.2.02(Base)(64bit) lvm2-libs lvm2-libs(x86-64) lvm2-python-libs: lvm.so()(64bit) lvm2-python-libs lvm2-python-libs(x86-64) python-lvm lvm2-devel: lvm2-devel lvm2-devel(x86-64) pkgconfig(lvm2app) cmirror: cmirror cmirror(x86-64) lvm2-sysvinit: lvm2-sysvinit lvm2-sysvinit(x86-64) Unversioned so-files -------------------- lvm2-libs: /usr/lib64/device-mapper/libdevmapper-event-lvm2mirror.so lvm2-libs: /usr/lib64/device-mapper/libdevmapper-event-lvm2raid.so lvm2-libs: /usr/lib64/device-mapper/libdevmapper-event-lvm2snapshot.so lvm2-libs: /usr/lib64/device-mapper/libdevmapper-event-lvm2thin.so lvm2-libs: /usr/lib64/libdevmapper-event-lvm2mirror.so lvm2-libs: /usr/lib64/libdevmapper-event-lvm2raid.so lvm2-libs: /usr/lib64/libdevmapper-event-lvm2snapshot.so lvm2-libs: /usr/lib64/libdevmapper-event-lvm2thin.so lvm2-python-libs: /usr/lib64/python2.7/site-packages/lvm.so Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn lvm2 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires