Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in man-pages- es-extra [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 81920 bytes in 9 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define extra_name %{name}-extra %define extra_ver 0.8a %define extra_pkg_name %{extra_name}-%{extra_ver} %define es_man_dir %{_mandir}/es [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: man-pages-es-1.55-19.fc19.noarch.rpm man-pages-es-extra-1.55-19.fc19.noarch.rpm man-pages-es.noarch: I: enchant-dictionary-not-found es man-pages-es.noarch: W: spelling-error %description -l en_US piernas -> Napier man-pages-es.noarch: W: spelling-error %description -l en_US ditec -> cited, cordite man-pages-es-extra.noarch: W: summary-ended-with-dot es Páginas de manual extras en castellano. 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- man-pages-es-extra (rpmlib, GLIBC filtered): man-pages-es man-pages-es (rpmlib, GLIBC filtered): man-pages-reader Provides -------- man-pages-es-extra: man-pages-es-extra man-pages-es: man-pages-es MD5-sum check ------------- http://ditec.um.es/~piernas/manpages-es/man-pages-es-1.55.tar.bz2 : CHECKSUM(SHA256) this package : cc9c19b44146ebb55243a86ab66bdd654a696a0eedd378db9cc4bad2cb621fea CHECKSUM(SHA256) upstream package : cc9c19b44146ebb55243a86ab66bdd654a696a0eedd378db9cc4bad2cb621fea http://ditec.um.es/~piernas/manpages-es/man-pages-es-extra-0.8a.tar.gz : CHECKSUM(SHA256) this package : 9096662d0ad45cdd0f2de30a3cf7c04bd450eb1c9f2b43c7f22deb40265f7361 CHECKSUM(SHA256) upstream package : 9096662d0ad45cdd0f2de30a3cf7c04bd450eb1c9f2b43c7f22deb40265f7361 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn man-pages-es -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires