Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No /usr/share/javadoc/maven-plugin-tools found See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in maven-plugin- annotations, maven-plugin-plugin, maven-plugin-tools-annotations, maven- plugin-tools-ant, maven-plugin-tools-api, maven-plugin-tools-beanshell, maven-plugin-tools-generators, maven-plugin-tools-java, maven-plugin-tools- model, maven-script, maven-script-ant, maven-script-beanshell, maven-plugin- tools-javadocs See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc html files found in maven-plugin-tools-javadoc See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in maven- plugin-annotations , maven-plugin-plugin , maven-plugin-tools-annotations , maven-plugin-tools-ant , maven-plugin-tools-api , maven-plugin-tools- beanshell , maven-plugin-tools-generators , maven-plugin-tools-java , maven-plugin-tools-javadoc , maven-plugin-tools-model , maven-script , maven-script-ant , maven-script-beanshell , maven-plugin-tools-javadocs [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 40960 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Javadoc subpackages have Requires: jpackage-utils Maven: [ ]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: maven-plugin-tools-3.1-7.fc19.noarch.rpm maven-plugin-annotations-3.1-7.fc19.noarch.rpm maven-plugin-plugin-3.1-7.fc19.noarch.rpm maven-plugin-tools-annotations-3.1-7.fc19.noarch.rpm maven-plugin-tools-ant-3.1-7.fc19.noarch.rpm maven-plugin-tools-api-3.1-7.fc19.noarch.rpm maven-plugin-tools-beanshell-3.1-7.fc19.noarch.rpm maven-plugin-tools-generators-3.1-7.fc19.noarch.rpm maven-plugin-tools-java-3.1-7.fc19.noarch.rpm maven-plugin-tools-javadoc-3.1-7.fc19.noarch.rpm maven-plugin-tools-model-3.1-7.fc19.noarch.rpm maven-script-3.1-7.fc19.noarch.rpm maven-script-ant-3.1-7.fc19.noarch.rpm maven-script-beanshell-3.1-7.fc19.noarch.rpm maven-plugin-tools-javadocs-3.1-7.fc19.noarch.rpm maven-plugin-annotations.noarch: W: no-documentation maven-plugin-plugin.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsi maven-plugin-plugin.noarch: W: no-documentation maven-plugin-tools-annotations.noarch: W: no-documentation maven-plugin-tools-ant.noarch: W: no-documentation maven-plugin-tools-api.noarch: W: no-documentation maven-plugin-tools-beanshell.noarch: W: no-documentation maven-plugin-tools-generators.noarch: W: no-documentation maven-plugin-tools-java.noarch: W: no-documentation maven-plugin-tools-javadoc.noarch: W: spelling-error %description -l en_US taglets -> eaglets, tablets, tag lets maven-plugin-tools-javadoc.noarch: W: spelling-error %description -l en_US javadocs -> java docs, java-docs, avocados maven-plugin-tools-javadoc.noarch: W: no-documentation maven-plugin-tools-model.noarch: W: no-documentation maven-script.noarch: W: no-documentation maven-script-ant.noarch: W: no-documentation maven-script-beanshell.noarch: E: description-line-too-long C This package provides Maven Beanshell Mojo Support, which write Maven plugins with maven-script-beanshell.noarch: W: no-documentation maven-plugin-tools-javadocs.noarch: W: spelling-error Summary(en_US) Javadoc -> Java doc, Java-doc, Avocado 15 packages and 0 specfiles checked; 1 errors, 17 warnings. Requires -------- maven-plugin-tools-model (rpmlib, GLIBC filtered): java jpackage-utils maven-plugin-descriptor maven-plugin-tools plexus-containers-container-default plexus-utils maven-script (rpmlib, GLIBC filtered): jpackage-utils maven-plugin-tools maven-plugin-tools-java (rpmlib, GLIBC filtered): java jpackage-utils maven maven-plugin-descriptor maven-plugin-tools maven-plugin-tools-api maven-project plexus-containers-component-annotations plexus-containers-container-default plexus-utils qdox maven-plugin-tools-api (rpmlib, GLIBC filtered): java jpackage-utils maven maven-plugin-descriptor maven-plugin-tools maven-project plexus-containers-container-default plexus-utils maven-plugin-tools-ant (rpmlib, GLIBC filtered): java jpackage-utils maven-plugin-descriptor maven-plugin-tools maven-plugin-tools-api maven-plugin-tools-model maven-project plexus-containers-component-annotations plexus-containers-container-default plexus-utils maven-plugin-tools-beanshell (rpmlib, GLIBC filtered): bsh java jpackage-utils maven-plugin-descriptor maven-plugin-tools maven-plugin-tools-api plexus-containers-component-annotations maven-plugin-plugin (rpmlib, GLIBC filtered): java jpackage-utils maven maven-artifact-manager maven-doxia-sink-api maven-doxia-sitetools maven-plugin-descriptor maven-plugin-registry maven-plugin-tools maven-plugin-tools-annotations maven-plugin-tools-api maven-plugin-tools-beanshell maven-plugin-tools-generators maven-plugin-tools-java maven-plugin-tools-model maven-project maven-shared-reporting-api maven-shared-reporting-impl plexus-utils plexus-velocity velocity maven-plugin-tools (rpmlib, GLIBC filtered): java jpackage-utils maven-plugin-tools-javadocs (rpmlib, GLIBC filtered): jpackage-utils maven-plugin-tools-annotations (rpmlib, GLIBC filtered): java jpackage-utils maven maven-plugin-annotations maven-plugin-descriptor maven-plugin-tools maven-plugin-tools-api maven-project objectweb-asm plexus-archiver plexus-containers-component-annotations plexus-containers-container-default plexus-utils qdox maven-script-beanshell (rpmlib, GLIBC filtered): java jpackage-utils maven maven-script plexus-bsh-factory maven-plugin-annotations (rpmlib, GLIBC filtered): java jpackage-utils maven maven-plugin-tools maven-script-ant (rpmlib, GLIBC filtered): ant java jpackage-utils maven maven-plugin-descriptor maven-project maven-script plexus-ant-factory plexus-archiver plexus-component-factories-pom plexus-containers-container-default maven-plugin-tools-javadoc (rpmlib, GLIBC filtered): java jpackage-utils maven-plugin-tools maven-plugin-tools-java maven-plugin-tools-generators (rpmlib, GLIBC filtered): java jpackage-utils jtidy maven maven-plugin-descriptor maven-plugin-tools maven-plugin-tools-api maven-project maven-shared-reporting-api objectweb-asm plexus-containers-container-default plexus-utils plexus-velocity velocity Provides -------- maven-plugin-tools-model: maven-plugin-tools-model maven-shared-plugin-tools-model mvn(org.apache.maven.plugin-tools:maven-plugin-tools-model) maven-script: maven-script mvn(org.apache.maven.plugin-tools:maven-script) maven-plugin-tools-java: maven-plugin-tools-java maven-shared-plugin-tools-java mvn(org.apache.maven.plugin-tools:maven-plugin-tools-java) maven-plugin-tools-api: maven-plugin-tools-api maven-shared-plugin-tools-api mvn(org.apache.maven.plugin-tools:maven-plugin-tools-api) maven-plugin-tools-ant: maven-plugin-tools-ant maven-shared-plugin-tools-ant mvn(org.apache.maven.plugin-tools:maven-plugin-tools-ant) maven-plugin-tools-beanshell: maven-plugin-tools-beanshell maven-shared-plugin-tools-beanshell mvn(org.apache.maven.plugin-tools:maven-plugin-tools-beanshell) maven-plugin-plugin: maven-plugin-plugin maven2-plugin-plugin mvn(org.apache.maven.plugins:maven-plugin-plugin) maven-plugin-tools: maven-plugin-tools mvn(org.apache.maven.plugin-tools:maven-plugin-tools) maven-plugin-tools-javadocs: maven-plugin-tools-javadocs maven-plugin-tools-annotations: maven-plugin-tools-annotations mvn(org.apache.maven.plugin-tools:maven-plugin-tools-annotations) maven-script-beanshell: maven-script-beanshell mvn(org.apache.maven.plugin-tools:maven-script-beanshell) maven-plugin-annotations: maven-plugin-annotations mvn(org.apache.maven.plugin-tools:maven-plugin-annotations) maven-script-ant: maven-script-ant mvn(org.apache.maven.plugin-tools:maven-script-ant) maven-plugin-tools-javadoc: maven-plugin-tools-javadoc mvn(org.apache.maven.plugin-tools:maven-plugin-tools-javadoc) maven-plugin-tools-generators: maven-plugin-tools-generators mvn(org.apache.maven.plugin-tools:maven-plugin-tools-generators) MD5-sum check ------------- http://repo2.maven.org/maven2/org/apache/maven/plugin-tools/maven-plugin-tools/3.1/maven-plugin-tools-3.1-source-release.zip : CHECKSUM(SHA256) this package : 3847724f0097d2881e9a1df51a22e87fb2b9559e895abc9c8b3d35f5a8d267f2 CHECKSUM(SHA256) upstream package : 3847724f0097d2881e9a1df51a22e87fb2b9559e895abc9c8b3d35f5a8d267f2 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn maven-plugin-tools -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires