Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 143360 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Multiple BuildRoot definitions found [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4689920 bytes in /usr/share 4689920 mc-4.8.7-1.fc19.x86_64.rpm Rpmlint ------- Checking: mc-4.8.7-1.fc19.x86_64.rpm mc.x86_64: W: incoherent-version-in-changelog 4.8.7-1 ['1:4.8.7-1.fc19', '1:4.8.7-1'] mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/unlink mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/utime mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/rmdir mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/chown mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/append mc.x86_64: E: executable-sourced-script /etc/profile.d/mc.sh 0755L mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/mv mc.x86_64: E: script-without-shebang /usr/libexec/mc/mc-wrapper.sh mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/chmod mc.x86_64: E: script-without-shebang /usr/libexec/mc/mc.csh mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/fexists mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/ln mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/ls mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/send mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/mkdir mc.x86_64: E: script-without-shebang /usr/libexec/mc/mc.sh mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/hardlink mc.x86_64: E: non-readable /usr/libexec/mc/cons.saver 0711L mc.x86_64: E: non-standard-executable-perm /usr/libexec/mc/cons.saver 0711L mc.x86_64: E: executable-sourced-script /etc/profile.d/mc.csh 0755L mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/info mc.x86_64: E: script-without-shebang /usr/libexec/mc/fish/get mc.x86_64: E: executable-marked-as-config-file /etc/mc/edit.indent.rc mc.x86_64: E: script-without-shebang /usr/libexec/mc/mc-wrapper.csh mc.x86_64: W: no-manual-page-for-binary mcdiff 1 packages and 0 specfiles checked; 24 errors, 2 warnings. Requires -------- mc (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl /usr/bin/python config(mc) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgpm.so.2()(64bit) libpthread.so.0()(64bit) libslang.so.2()(64bit) libslang.so.2(SLANG2)(64bit) libssh2.so.1()(64bit) perl(File::Basename) perl(File::Temp) perl(POSIX) perl(bytes) perl(strict) rtld(GNU_HASH) Provides -------- mc: config(mc) mc mc(x86-64) MD5-sum check ------------- http://www.midnight-commander.org/downloads/mc-4.8.7.tar.xz : CHECKSUM(SHA256) this package : 88f620f7944d629087e0f3518a7e7bff7600fd1c4fa157767cdcca95f2cb3074 CHECKSUM(SHA256) upstream package : 88f620f7944d629087e0f3518a7e7bff7600fd1c4fa157767cdcca95f2cb3074 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn mc -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires