Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mesa-libGL , mesa-libEGL , mesa-libGLES , mesa-dri-filesystem , mesa-dri-drivers , khrplatform-devel , mesa-libGL-devel , mesa-libEGL-devel , mesa-libGLES- devel , mesa-libOSMesa , mesa-libOSMesa-devel , mesa-libgbm , mesa- libgbm-devel , mesa-libwayland-egl , mesa-libwayland-egl-devel , mesa- libxatracker , mesa-libxatracker-devel , mesa-libglapi [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 256000 bytes in 9 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define rhel_no_hw_arches ppc ppc64 ppc64p7 %define with_private_llvm 1 %define with_private_llvm 0 %define with_wayland 1 %define min_wayland_version 0.85 %define min_wayland_version 1.0 %define with_radeonsi 1 %define with_hardware 0 %define dri_drivers --with-dri- drivers=swrast %define with_llvm 1 %define swrastc ,swrast %define with_hardware 1 %define base_drivers nouveau,radeon,r200 %define platform_drivers ,i915,i965 %define with_vmware 1 %define platform_drivers ,i915,i965 %define with_vmware 1 %define platform_drivers ,i915 %define dri_drivers --with-dri- drivers=%{base_drivers}%{?platform_drivers}%{?swrastc} %define _default_patch_fuzz 2 %define common_flags --enable-selinux --enable-pic --disable-asm %define common_flags --enable-selinux --enable-pic [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mesa-libGL-9.0.1-4.fc19.x86_64.rpm mesa-libEGL-9.0.1-4.fc19.x86_64.rpm mesa-libGLES-9.0.1-4.fc19.x86_64.rpm mesa-dri-filesystem-9.0.1-4.fc19.x86_64.rpm mesa-dri-drivers-9.0.1-4.fc19.x86_64.rpm khrplatform-devel-9.0.1-4.fc19.noarch.rpm mesa-libGL-devel-9.0.1-4.fc19.x86_64.rpm mesa-libEGL-devel-9.0.1-4.fc19.x86_64.rpm mesa-libGLES-devel-9.0.1-4.fc19.x86_64.rpm mesa-libOSMesa-9.0.1-4.fc19.x86_64.rpm mesa-libOSMesa-devel-9.0.1-4.fc19.x86_64.rpm mesa-libgbm-9.0.1-4.fc19.x86_64.rpm mesa-libgbm-devel-9.0.1-4.fc19.x86_64.rpm mesa-libwayland-egl-9.0.1-4.fc19.x86_64.rpm mesa-libwayland-egl-devel-9.0.1-4.fc19.x86_64.rpm mesa-libxatracker-9.0.1-4.fc19.x86_64.rpm mesa-libxatracker-devel-9.0.1-4.fc19.x86_64.rpm mesa-libglapi-9.0.1-4.fc19.x86_64.rpm mesa-libGL.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment mesa-libGL.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mesa-libGL.x86_64: W: shared-lib-calls-exit /usr/lib64/libGL.so.1.2.0 exit@GLIBC_2.2.5 mesa-libGL.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libGL-9.0.1/COPYING mesa-libEGL.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment mesa-libEGL.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mesa-libEGL.x86_64: W: shared-lib-calls-exit /usr/lib64/libEGL.so.1.0.0 exit@GLIBC_2.2.5 mesa-libEGL.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libEGL-9.0.1/COPYING mesa-libGLES.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment mesa-libGLES.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mesa-libGLES.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libGLES-9.0.1/COPYING mesa-dri-filesystem.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-dri-filesystem-9.0.1/COPYING mesa-dri-drivers.x86_64: W: obsolete-not-provided mesa-dri-drivers-experimental mesa-dri-drivers.x86_64: W: obsolete-not-provided mesa-dri-drivers-dri1 mesa-dri-drivers.x86_64: W: obsolete-not-provided mesa-dri-llvmcore mesa-dri-drivers.x86_64: W: shared-lib-calls-exit /usr/lib64/libdricore9.0.1.so.1.0.0 exit@GLIBC_2.2.5 mesa-dri-drivers.x86_64: W: no-documentation mesa-dri-drivers.x86_64: E: library-without-ldconfig-postin /usr/lib64/libdricore9.0.1.so.1.0.0 mesa-dri-drivers.x86_64: E: library-without-ldconfig-postun /usr/lib64/libdricore9.0.1.so.1.0.0 mesa-dri-drivers.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libdricore9.0.1.so khrplatform-devel.noarch: W: spelling-error Summary(en_US) Khronos -> Kronor khrplatform-devel.noarch: W: spelling-error %description -l en_US Khronos -> Kronor khrplatform-devel.noarch: W: no-documentation mesa-libGL-devel.x86_64: W: no-documentation mesa-libEGL-devel.x86_64: W: no-documentation mesa-libGLES-devel.x86_64: W: no-documentation mesa-libOSMesa.x86_64: W: spelling-error Summary(en_US) offscreen -> off screen, off-screen, firescreen mesa-libOSMesa.x86_64: W: spelling-error %description -l en_US offscreen -> off screen, off-screen, firescreen mesa-libOSMesa.x86_64: W: shared-lib-calls-exit /usr/lib64/libOSMesa.so.8.0.0 exit@GLIBC_2.2.5 mesa-libOSMesa.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libOSMesa-9.0.1/COPYING mesa-libOSMesa-devel.x86_64: W: spelling-error Summary(en_US) offscreen -> off screen, off-screen, firescreen mesa-libOSMesa-devel.x86_64: W: spelling-error %description -l en_US offscreen -> off screen, off-screen, firescreen mesa-libOSMesa-devel.x86_64: W: no-documentation mesa-libgbm.x86_64: W: spelling-error Summary(en_US) gbm -> gm, gem, gum mesa-libgbm.x86_64: W: spelling-error %description -l en_US gbm -> gm, gem, gum mesa-libgbm.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mesa-libgbm.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libgbm-9.0.1/COPYING mesa-libgbm-devel.x86_64: W: no-documentation mesa-libwayland-egl.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mesa-libwayland-egl.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libwayland-egl-9.0.1/COPYING mesa-libwayland-egl-devel.x86_64: W: no-documentation mesa-libxatracker.x86_64: W: spelling-error Summary(en_US) vmware -> stemware mesa-libxatracker.x86_64: W: spelling-error %description -l en_US vmware -> stemware mesa-libxatracker.x86_64: E: incorrect-fsf-address /usr/share/doc/mesa-libxatracker-9.0.1/COPYING mesa-libxatracker-devel.x86_64: W: no-documentation mesa-libglapi.x86_64: W: spelling-error Summary(en_US) glapi -> lapping mesa-libglapi.x86_64: W: spelling-error %description -l en_US glapi -> lapping mesa-libglapi.x86_64: W: shared-lib-calls-exit /usr/lib64/libglapi.so.0.0.0 exit@GLIBC_2.2.5 mesa-libglapi.x86_64: W: no-documentation 18 packages and 0 specfiles checked; 10 errors, 39 warnings. Requires -------- khrplatform-devel (rpmlib, GLIBC filtered): mesa-libxatracker-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libxatracker.so.1()(64bit) mesa-libxatracker(x86-64) mesa-libEGL (rpmlib, GLIBC filtered): /sbin/ldconfig libX11-xcb.so.1()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libdrm.so.2()(64bit) libgbm.so.1()(64bit) libglapi.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libselinux.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libwayland-client.so.0()(64bit) libwayland-server.so.0()(64bit) libxcb-dri2.so.0()(64bit) libxcb-render.so.0()(64bit) libxcb-shape.so.0()(64bit) libxcb-xfixes.so.0()(64bit) libxcb.so.1()(64bit) rtld(GNU_HASH) mesa-libwayland-egl-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libwayland-egl.so.1()(64bit) mesa-libwayland-egl(x86-64) mesa-libEGL-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config khrplatform-devel libEGL.so.1()(64bit) mesa-libEGL pkgconfig(libdrm) pkgconfig(x11) pkgconfig(x11-xcb) pkgconfig(xcb-glx) pkgconfig(xdamage) pkgconfig(xext) pkgconfig(xfixes) pkgconfig(xxf86vm) mesa-dri-drivers (rpmlib, GLIBC filtered): config(mesa-dri-drivers) libLLVM-3.1.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libdricore9.0.1.so.1()(64bit) libdrm.so.2()(64bit) libdrm_intel.so.1()(64bit) libdrm_nouveau.so.2()(64bit) libdrm_radeon.so.1()(64bit) libexpat.so.1()(64bit) libffi.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) mesa-dri-filesystem(x86-64) rtld(GNU_HASH) mesa-libGLES (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libdrm.so.2()(64bit) libglapi.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) rtld(GNU_HASH) mesa-libxatracker (rpmlib, GLIBC filtered): /sbin/ldconfig libLLVM-3.1.so()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) mesa-libGL (rpmlib, GLIBC filtered): /sbin/ldconfig libX11 libX11-xcb.so.1()(64bit) libX11.so.6()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXxf86vm.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libdrm.so.2()(64bit) libglapi.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libxcb-glx.so.0()(64bit) libxcb.so.1()(64bit) rtld(GNU_HASH) mesa-libGL-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gl-manpages libGL.so.1()(64bit) libglapi.so.0()(64bit) mesa-libGL pkgconfig(libdrm) pkgconfig(x11) pkgconfig(x11-xcb) pkgconfig(xcb-glx) pkgconfig(xdamage) pkgconfig(xext) pkgconfig(xfixes) pkgconfig(xxf86vm) mesa-libOSMesa-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libOSMesa.so.8()(64bit) mesa-libOSMesa mesa-libwayland-egl (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libselinux.so.1()(64bit) rtld(GNU_HASH) mesa-libgbm-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libgbm.so.1()(64bit) mesa-libgbm(x86-64) pkgconfig(libudev) mesa-libglapi (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) rtld(GNU_HASH) mesa-libGLES-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config khrplatform-devel libGLESv1_CM.so.1()(64bit) libGLESv2.so.2()(64bit) mesa-libGLES mesa-dri-filesystem (rpmlib, GLIBC filtered): mesa-libOSMesa (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libglapi.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) mesa-libgbm (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libglapi.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libselinux.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) rtld(GNU_HASH) Provides -------- khrplatform-devel: khrplatform-devel mesa-libxatracker-devel: libxatracker-devel mesa-libxatracker-devel mesa-libxatracker-devel(x86-64) pkgconfig(xatracker) mesa-libEGL: libEGL.so.1()(64bit) mesa-libEGL mesa-libEGL(x86-64) mesa-libwayland-egl-devel: libwayland-egl-devel mesa-libwayland-egl-devel mesa-libwayland-egl-devel(x86-64) pkgconfig(wayland-egl) mesa-libEGL-devel: mesa-libEGL-devel mesa-libEGL-devel(x86-64) pkgconfig(egl) mesa-dri-drivers: config(mesa-dri-drivers) i915_dri.so()(64bit) i965_dri.so()(64bit) libdricore9.0.1.so.1()(64bit) mesa-dri-drivers mesa-dri-drivers(x86-64) nouveau_dri.so()(64bit) nouveau_vieux_dri.so()(64bit) r200_dri.so()(64bit) r300_dri.so()(64bit) r600_dri.so()(64bit) radeon_dri.so()(64bit) radeonsi_dri.so()(64bit) swrast_dri.so()(64bit) vmwgfx_dri.so()(64bit) mesa-libGLES: libGLESv1_CM.so.1()(64bit) libGLESv2.so.2()(64bit) mesa-libGLES mesa-libGLES(x86-64) mesa-libxatracker: libxatracker libxatracker.so.1()(64bit) mesa-libxatracker mesa-libxatracker(x86-64) mesa-libGL: libGL libGL.so.1()(64bit) mesa-libGL mesa-libGL(x86-64) mesa-libGL-devel: libGL-devel mesa-libGL-devel mesa-libGL-devel(x86-64) pkgconfig(dri) pkgconfig(gl) mesa-libOSMesa-devel: mesa-libOSMesa-devel mesa-libOSMesa-devel(x86-64) pkgconfig(osmesa) mesa-libwayland-egl: libwayland-egl libwayland-egl.so.1()(64bit) mesa-libwayland-egl mesa-libwayland-egl(x86-64) mesa-libgbm-devel: libgbm-devel mesa-libgbm-devel mesa-libgbm-devel(x86-64) pkgconfig(gbm) mesa-libglapi: libglapi.so.0()(64bit) mesa-libglapi mesa-libglapi(x86-64) mesa-libGLES-devel: mesa-libGLES-devel mesa-libGLES-devel(x86-64) pkgconfig(glesv1_cm) pkgconfig(glesv2) mesa-dri-filesystem: mesa-dri-filesystem mesa-dri-filesystem(x86-64) mesa-libOSMesa: libOSMesa libOSMesa.so.8()(64bit) mesa-libOSMesa mesa-libOSMesa(x86-64) mesa-libgbm: libgbm libgbm.so.1()(64bit) mesa-libgbm mesa-libgbm(x86-64) Unversioned so-files -------------------- mesa-dri-drivers: /usr/lib64/dri/i915_dri.so mesa-dri-drivers: /usr/lib64/dri/i965_dri.so mesa-dri-drivers: /usr/lib64/dri/nouveau_dri.so mesa-dri-drivers: /usr/lib64/dri/nouveau_vieux_dri.so mesa-dri-drivers: /usr/lib64/dri/r200_dri.so mesa-dri-drivers: /usr/lib64/dri/r300_dri.so mesa-dri-drivers: /usr/lib64/dri/r600_dri.so mesa-dri-drivers: /usr/lib64/dri/radeon_dri.so mesa-dri-drivers: /usr/lib64/dri/radeonsi_dri.so mesa-dri-drivers: /usr/lib64/dri/swrast_dri.so mesa-dri-drivers: /usr/lib64/dri/vmwgfx_dri.so mesa-dri-drivers: /usr/lib64/libdricore9.0.1.so MD5-sum check ------------- ftp://ftp.freedesktop.org/pub/mesa/9.0.1/MesaLib-9.0.1.tar.bz2 : CHECKSUM(SHA256) this package : 57a7ba83bace3f3a7dc0929fe026ef5f0ad454234ec4ad8a3e0d31650a75db6f CHECKSUM(SHA256) upstream package : 57a7ba83bace3f3a7dc0929fe026ef5f0ad454234ec4ad8a3e0d31650a75db6f Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn mesa -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires