Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/mgetty+sendfax/faxspool.rules.sample [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mgetty- sendfax , mgetty-voice , mgetty-viewfax [ ]: Package complies to the Packaging Guidelines [ ]: Texinfo files are properly installed Note: Texinfo .info file(s) in mgetty [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 921600 bytes in 57 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define date Jun15 %define SENDFAX_UID 78 %define makeflags CFLAGS="$RPM_OPT_FLAGS -Wall -DAUTO_PPP -D_FILE_OFFSET_BITS=64" prefix=%{_prefix} spool=%{_var}/spool BINDIR=%{_bindir} SBINDIR=%{_sbindir} LIBDIR=%{_libdir}/mgetty+sendfax HELPDIR=%{_libdir}/mgetty+sendfax CONFDIR=%{_sysconfdir}/mgetty+sendfax MANDIR=%{_mandir} MAN1DIR=%{_mandir}/man1 MAN4DIR=%{_mandir}/man4 MAN5DIR=%{_mandir}/man5 MAN8DIR=%{_mandir}/man8 INFODIR=%{_infodir} ECHO='"echo -e"' INSTALL=%{__install} %define instflags CFLAGS="$RPM_OPT_FLAGS -Wall -DAUTO_PPP" prefix=$RPM_BUILD_ROOT%{_prefix} spool=$RPM_BUILD_ROOT%{_var}/spool BINDIR=$RPM_BUILD_ROOT%{_bindir} SBINDIR=$RPM_BUILD_ROOT%{_sbindir} LIBDIR=$RPM_BUILD_ROOT%{_libdir}/mgetty+sendfax HELPDIR=$RPM_BUILD_ROOT%{_libdir}/mgetty+sendfax CONFDIR=$RPM_BUILD_ROOT%{_sysconfdir}/mgetty+sendfax MANDIR=$RPM_BUILD_ROOT%{_mandir} MAN1DIR=$RPM_BUILD_ROOT%{_mandir}/man1 MAN4DIR=$RPM_BUILD_ROOT%{_mandir}/man4 MAN5DIR=$RPM_BUILD_ROOT%{_mandir}/man5 MAN8DIR=$RPM_BUILD_ROOT%{_mandir}/man8 INFODIR=$RPM_BUILD_ROOT%{_infodir} ECHO='echo -e' INSTALL=%{__install} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1075200 bytes in /usr/share 51200 mgetty-viewfax-1.1.36-16.fc18.x86_64.rpm 40960 mgetty- sendfax-1.1.36-16.fc18.x86_64.rpm 122880 mgetty- voice-1.1.36-16.fc18.x86_64.rpm 860160 mgetty-1.1.36-16.fc18.x86_64.rpm Rpmlint ------- Checking: mgetty-1.1.36-16.fc18.x86_64.rpm mgetty-sendfax-1.1.36-16.fc18.x86_64.rpm mgetty-voice-1.1.36-16.fc18.x86_64.rpm mgetty-viewfax-1.1.36-16.fc18.x86_64.rpm mgetty.x86_64: W: spelling-error Summary(en_US) getty -> Getty, gutty, petty mgetty.x86_64: W: spelling-error %description -l en_US getty -> Getty, gutty, petty mgetty.x86_64: W: spelling-error %description -l en_US logins -> losing, loins, lo gins mgetty.x86_64: W: spelling-error %description -l en_US sendfax -> send fax, send-fax, sendoff mgetty.x86_64: W: spelling-error %description -l en_US viewfax -> view fax, view-fax, viewfinder mgetty.x86_64: E: non-readable /etc/mgetty+sendfax/login.config 0600L mgetty.x86_64: E: non-readable /etc/mgetty+sendfax/dialin.config 0600L mgetty.x86_64: E: non-readable /etc/mgetty+sendfax/mgetty.config 0600L mgetty.x86_64: W: file-not-utf8 /usr/share/doc/mgetty-1.1.36/modems.db mgetty.x86_64: E: non-readable /sbin/mgetty 0700L mgetty.x86_64: E: non-standard-executable-perm /sbin/mgetty 0700L mgetty.x86_64: E: non-readable /usr/sbin/callback 0700L mgetty.x86_64: E: non-standard-executable-perm /usr/sbin/callback 0700L mgetty.x86_64: W: manual-page-warning /usr/share/man/man8/mgetty.8.gz 163: warning: macro `login:'' not defined mgetty.x86_64: W: manual-page-warning /usr/share/man/man8/callback.8.gz 15: warning: macro `..' not defined mgetty.x86_64: W: install-file-in-docs /usr/share/doc/mgetty-1.1.36/samples/new_fax.all/INSTALL mgetty-sendfax.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end mgetty-sendfax.x86_64: W: spelling-error %description -l en_US getty -> Getty, gutty, petty mgetty-sendfax.x86_64: W: spelling-error %description -l en_US logins -> losing, loins, lo gins mgetty-sendfax.x86_64: W: conffile-without-noreplace-flag /etc/mgetty+sendfax/faxspool.rules.sample mgetty-sendfax.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/sendfax mgetty-sendfax.x86_64: W: manual-page-warning /usr/share/man/man1/mgetty_fax.1.gz 10: warning: macro `..' not defined mgetty-sendfax.x86_64: W: manual-page-warning /usr/share/man/man8/sendfax.8.gz 20: warning: macro `..' not defined mgetty-sendfax.x86_64: E: setuid-binary /usr/lib64/mgetty+sendfax/faxq-helper fax 04711L mgetty-sendfax.x86_64: E: non-standard-executable-perm /usr/lib64/mgetty+sendfax/faxq-helper 04711L mgetty-sendfax.x86_64: E: non-standard-executable-perm /usr/lib64/mgetty+sendfax/faxq-helper 04711L mgetty-sendfax.x86_64: W: no-manual-page-for-binary kvg mgetty-sendfax.x86_64: W: no-manual-page-for-binary newslock mgetty-sendfax.x86_64: W: no-manual-page-for-binary ct mgetty-voice.x86_64: W: only-non-binary-in-usr-lib mgetty-voice.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/vgetty mgetty-voice.x86_64: W: file-not-utf8 /usr/share/doc/mgetty-voice-1.1.36/ChangeLog mgetty-voice.x86_64: E: non-readable /sbin/vgetty 0700L mgetty-voice.x86_64: E: non-standard-executable-perm /sbin/vgetty 0700L mgetty-voice.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/vm mgetty-voice.x86_64: E: non-readable /etc/mgetty+sendfax/voice.conf 0600L mgetty-voice.x86_64: W: no-manual-page-for-binary vm mgetty-viewfax.x86_64: W: only-non-binary-in-usr-lib mgetty-viewfax.x86_64: E: incorrect-fsf-address /usr/share/doc/mgetty-viewfax-1.1.36/COPYING 4 packages and 0 specfiles checked; 17 errors, 22 warnings. Requires -------- mgetty (rpmlib, GLIBC filtered): /bin/sh /sbin/install-info /usr/sbin/sendmail config(mgetty) coreutils libc.so.6()(64bit) rtld(GNU_HASH) systemd-units mgetty-sendfax (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl /usr/sbin/useradd config(mgetty-sendfax) coreutils libc.so.6()(64bit) mgetty netpbm-progs perl perl(Getopt::Std) perl(IO::Handle) perl(POSIX) perl(strict) perl(vars) rtld(GNU_HASH) mgetty-viewfax (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) mgetty-voice (rpmlib, GLIBC filtered): config(mgetty-voice) libc.so.6()(64bit) libm.so.6()(64bit) mgetty rtld(GNU_HASH) Provides -------- mgetty: config(mgetty) mgetty mgetty(x86-64) mgetty-sendfax: config(mgetty-sendfax) mgetty-sendfax mgetty-sendfax(x86-64) mgetty-viewfax: mgetty-viewfax mgetty-viewfax(x86-64) mgetty-voice: config(mgetty-voice) mgetty-voice mgetty-voice(x86-64) MD5-sum check ------------- ftp://mgetty.greenie.net/pub/mgetty/source/1.1/mgetty1.1.36-Jun15.tar.gz : CHECKSUM(SHA256) this package : 8b8642aa318604ad057ed161cacff5c600296cbfbc9b4d562134ee5c130c80ce CHECKSUM(SHA256) upstream package : 8b8642aa318604ad057ed161cacff5c600296cbfbc9b4d562134ee5c130c80ce ftp://mgetty.greenie.net/pub/mgetty/source/1.1/mgetty1.1.36-Jun15.tar.gz.asc : CHECKSUM(SHA256) this package : 7a6189ce22a58f6ffabac103ee13b7b4f8c3be5076c1327f6a7872a2c3535bcd CHECKSUM(SHA256) upstream package : 7a6189ce22a58f6ffabac103ee13b7b4f8c3be5076c1327f6a7872a2c3535bcd Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn mgetty -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires