Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw- binutils-generic , mingw32-binutils , mingw64-binutils [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 1 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mingw-binutils-generic-2.23.51.0.5-3.fc19.x86_64.rpm mingw32-binutils-2.23.51.0.5-3.fc19.x86_64.rpm mingw64-binutils-2.23.51.0.5-3.fc19.x86_64.rpm mingw-binutils-generic.x86_64: W: spelling-error Summary(en_US) toolchains -> tool chains, tool-chains, chainsaws mingw-binutils-generic.x86_64: W: spelling-error %description -l en_US objdump -> obj dump, obj-dump, dumpy mingw-binutils-generic.x86_64: W: spelling-error %description -l en_US toolchains -> tool chains, tool-chains, chainsaws mingw-binutils-generic.x86_64: W: no-manual-page-for-binary mingw-objcopy mingw-binutils-generic.x86_64: W: no-manual-page-for-binary mingw-strip mingw-binutils-generic.x86_64: W: no-manual-page-for-binary mingw-objdump mingw32-binutils.x86_64: W: spelling-error %description -l en_US executables -> executable, executable s, executrices mingw32-binutils.x86_64: W: no-documentation mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/i686-w64-mingw32/bin/ld /usr/bin/i686-w64-mingw32-ld mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/i686-w64-mingw32/bin/strip /usr/bin/i686-w64-mingw32-strip mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/i686-w64-mingw32/bin/ranlib /usr/bin/i686-w64-mingw32-ranlib mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/i686-w64-mingw32/bin/nm /usr/bin/i686-w64-mingw32-nm mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/bin/i686-w64-mingw32-dlltool /usr/i686-w64-mingw32/bin/dlltool mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/bin/i686-w64-mingw32-objcopy /usr/i686-w64-mingw32/bin/objcopy mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/bin/i686-w64-mingw32-ld.bfd /usr/i686-w64-mingw32/bin/ld.bfd mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/bin/i686-w64-mingw32-as /usr/i686-w64-mingw32/bin/as mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/bin/i686-w64-mingw32-ar /usr/i686-w64-mingw32/bin/ar mingw32-binutils.x86_64: W: cross-directory-hard-link /usr/i686-w64-mingw32/bin/objdump /usr/bin/i686-w64-mingw32-objdump mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-strings mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-dlltool mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-as mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-strip mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-dllwrap mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-ld.bfd mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-ar mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-size mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-windres mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-ld mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-nm mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-objdump mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-addr2line mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-gprof mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-readelf mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-c++filt mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-elfedit mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-windmc mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-objcopy mingw32-binutils.x86_64: W: no-manual-page-for-binary i686-w64-mingw32-ranlib mingw32-binutils.x86_64: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-binutils.x86_64: W: spelling-error %description -l en_US executables -> executable, executable s, executrices mingw64-binutils.x86_64: W: no-documentation mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/bin/x86_64-w64-mingw32-nm /usr/x86_64-w64-mingw32/bin/nm mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/bin/x86_64-w64-mingw32-ld.bfd /usr/x86_64-w64-mingw32/bin/ld.bfd mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/x86_64-w64-mingw32/bin/ld /usr/bin/x86_64-w64-mingw32-ld mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/x86_64-w64-mingw32/bin/dlltool /usr/bin/x86_64-w64-mingw32-dlltool mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/bin/x86_64-w64-mingw32-ranlib /usr/x86_64-w64-mingw32/bin/ranlib mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/x86_64-w64-mingw32/bin/objcopy /usr/bin/x86_64-w64-mingw32-objcopy mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/x86_64-w64-mingw32/bin/objdump /usr/bin/x86_64-w64-mingw32-objdump mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/bin/x86_64-w64-mingw32-strip /usr/x86_64-w64-mingw32/bin/strip mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/x86_64-w64-mingw32/bin/as /usr/bin/x86_64-w64-mingw32-as mingw64-binutils.x86_64: W: cross-directory-hard-link /usr/x86_64-w64-mingw32/bin/ar /usr/bin/x86_64-w64-mingw32-ar mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-ld mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-objdump mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-ranlib mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-windres mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-windmc mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-gprof mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-addr2line mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-c++filt mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-nm mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-ar mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-as mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-objcopy mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-ld.bfd mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-strings mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-readelf mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-size mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-dlltool mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-strip mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-dllwrap mingw64-binutils.x86_64: W: no-manual-page-for-binary x86_64-w64-mingw32-elfedit mingw64-binutils.x86_64: W: non-standard-dir-in-usr x86_64-w64-mingw32 3 packages and 0 specfiles checked; 0 errors, 72 warnings. Requires -------- mingw32-binutils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) mingw-binutils-generic mingw32-filesystem rtld(GNU_HASH) mingw64-binutils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) mingw-binutils-generic mingw64-filesystem rtld(GNU_HASH) mingw-binutils-generic (rpmlib, GLIBC filtered): libc.so.6()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) rtld(GNU_HASH) Provides -------- mingw32-binutils: mingw32-binutils mingw32-binutils(x86-64) mingw64-binutils: mingw64-binutils mingw64-binutils(x86-64) mingw-binutils-generic: mingw-binutils-generic mingw-binutils-generic(x86-64) MD5-sum check ------------- http://www.kernel.org/pub/linux/devel/binutils/binutils-2.23.51.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 352bca34668e11f679e6de50ad437f6d8f09ad080895e375f8ea4fb8bd6d5ea7 CHECKSUM(SHA256) upstream package : 352bca34668e11f679e6de50ad437f6d8f09ad080895e375f8ea4fb8bd6d5ea7 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn mingw-binutils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires