Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-pthreads : /usr/i686-w64-mingw32/sys- root/mingw/include/pthread.h mingw32-pthreads : /usr/i686-w64-mingw32/sys- root/mingw/include/sched.h mingw32-pthreads : /usr/i686-w64-mingw32/sys- root/mingw/include/semaphore.h mingw64-pthreads : /usr/x86_64-w64-mingw32 /sys-root/mingw/include/pthread.h mingw64-pthreads : /usr/x86_64-w64-mingw32 /sys-root/mingw/include/sched.h mingw64-pthreads : /usr/x86_64-w64-mingw32 /sys-root/mingw/include/semaphore.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Static libraries in -static subpackage, if present. Note: Archive *.a files found in mingw32-pthreads, mingw64-pthreads See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-pthreads , mingw32-pthreads-static , mingw64-pthreads , mingw64 -pthreads-static [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 778240 bytes in 26 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mingw32-pthreads-2.8.0-23.20110511cvs.fc19.noarch.rpm mingw32-pthreads-static-2.8.0-23.20110511cvs.fc19.noarch.rpm mingw64-pthreads-2.8.0-23.20110511cvs.fc19.noarch.rpm mingw64-pthreads-static-2.8.0-23.20110511cvs.fc19.noarch.rpm mingw32-pthreads.noarch: W: spelling-error Summary(en_US) pthread -> thread, p thread mingw32-pthreads.noarch: W: spelling-error %description -l en_US multithreaded -> multicolored mingw32-pthreads.noarch: W: spelling-error %description -l en_US Solaris -> Polaris, Solaria, Solar is mingw32-pthreads.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively mingw32-pthreads.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libpthreadGCE2.dll.a mingw32-pthreads.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libpthreadGC2.dll.a mingw32-pthreads.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-pthreads-2.8.0/README.NONPORTABLE mingw32-pthreads.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libpthreadGCE2.dll.a mingw32-pthreads.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/pthread.h mingw32-pthreads.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/semaphore.h mingw32-pthreads.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/sched.h mingw32-pthreads.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-pthreads-2.8.0/ChangeLog mingw32-pthreads.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libpthreadGC2.dll.a mingw32-pthreads.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-pthreads-2.8.0/COPYING.LIB mingw32-pthreads.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw32-pthreads-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libpthreadGC2.a mingw32-pthreads-static.noarch: W: no-documentation mingw32-pthreads-static.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-pthreads.noarch: W: spelling-error Summary(en_US) pthread -> thread, p thread mingw64-pthreads.noarch: W: spelling-error %description -l en_US multithreaded -> multicolored mingw64-pthreads.noarch: W: spelling-error %description -l en_US Solaris -> Polaris, Solaria, Solar is mingw64-pthreads.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively mingw64-pthreads.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libpthreadGCE2.dll.a mingw64-pthreads.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libpthreadGC2.dll.a mingw64-pthreads.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/sched.h mingw64-pthreads.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libpthreadGCE2.dll.a mingw64-pthreads.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libpthreadGC2.dll.a mingw64-pthreads.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-pthreads-2.8.0/README.NONPORTABLE mingw64-pthreads.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/semaphore.h mingw64-pthreads.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-pthreads-2.8.0/COPYING.LIB mingw64-pthreads.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-pthreads-2.8.0/ChangeLog mingw64-pthreads.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/pthread.h mingw64-pthreads.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw64-pthreads-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libpthreadGC2.a mingw64-pthreads-static.noarch: W: no-documentation mingw64-pthreads-static.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 4 packages and 0 specfiles checked; 8 errors, 28 warnings. Requires -------- mingw32-pthreads (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw64-pthreads (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw64-pthreads-static (rpmlib, GLIBC filtered): mingw64-pthreads mingw32-pthreads-static (rpmlib, GLIBC filtered): mingw32-pthreads Provides -------- mingw32-pthreads: mingw32(pthreadgc2.dll) mingw32(pthreadgce2.dll) mingw32-pthreads mingw32-winpthreads mingw64-pthreads: mingw64(pthreadgc2.dll) mingw64(pthreadgce2.dll) mingw64-pthreads mingw64-winpthreads mingw64-pthreads-static: mingw64-pthreads-static mingw32-pthreads-static: mingw32-pthreads-static Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn mingw-pthreads -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires