Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mlogc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 81920 bytes in 5 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mod_security-2.7.2-1.fc19.x86_64.rpm mlogc-2.7.2-1.fc19.x86_64.rpm mod_security.x86_64: E: non-standard-dir-perm /var/lib/mod_security 0770L mlogc.x86_64: E: non-readable /etc/mlogc.conf 0640L mlogc.x86_64: E: non-standard-dir-perm /var/log/mlogc/data 0770L mlogc.x86_64: W: log-files-without-logrotate /var/log/mlogc mlogc.x86_64: W: no-manual-page-for-binary mlogc mlogc.x86_64: W: no-manual-page-for-binary mlogc-batch-load mlogc.x86_64: W: install-file-in-docs /usr/share/doc/mlogc-2.7.2/INSTALL 2 packages and 0 specfiles checked; 3 errors, 4 warnings. Requires -------- mod_security (rpmlib, GLIBC filtered): config(mod_security) httpd httpd-mmn libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) liblber-2.4.so.2()(64bit) libldap_r-2.4.so.2()(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libpcre.so.1()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.8)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) mlogc (rpmlib, GLIBC filtered): /usr/bin/perl config(mlogc) libapr-1.so.0()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libpcre.so.1()(64bit) libpthread.so.0()(64bit) mod_security perl(Digest::MD5) perl(File::Find) perl(File::Spec::Functions) perl(Sys::Hostname) perl(strict) rtld(GNU_HASH) Provides -------- mod_security: config(mod_security) mod_security mod_security(x86-64) mod_security2.so()(64bit) mlogc: config(mlogc) mlogc mlogc(x86-64) Unversioned so-files -------------------- mod_security: /usr/lib64/httpd/modules/mod_security2.so MD5-sum check ------------- http://www.modsecurity.org/tarball/2.7.2/modsecurity-apache_2.7.2.tar.gz : CHECKSUM(SHA256) this package : 2fa43264e3aa024d29869eada3171a2aba19fc05180860fd84c7a6ebfd1f2854 CHECKSUM(SHA256) upstream package : 2fa43264e3aa024d29869eada3171a2aba19fc05180860fd84c7a6ebfd1f2854 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn mod_security -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires