Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 6 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0 [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define all_32bit_archs i386 i486 i586 i686 athlon ppc sparcv9 %define nfs_services %{SOURCE11} %{SOURCE12} %{SOURCE13} %{SOURCE14} %{SOURCE15} %{SOURCE16} %{SOURCE17} %{SOURCE18} %{SOURCE19} %define nfs_start_services %{SOURCE11} %{SOURCE12} %{SOURCE13} %{SOURCE14} %{SOURCE15} %{SOURCE18} %define nfs_automounts %{SOURCE20} %{SOURCE21} %define nfs_configs %{SOURCE50} %{SOURCE51} %{SOURCE52} %define nfsnobody_uid 65534 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nfs-utils-1.2.7-3.fc19.x86_64.rpm nfs-utils.x86_64: E: explicit-lib-dependency libblkid nfs-utils.x86_64: E: explicit-lib-dependency libcap nfs-utils.x86_64: E: explicit-lib-dependency libevent nfs-utils.x86_64: E: explicit-lib-dependency libgssglue nfs-utils.x86_64: E: explicit-lib-dependency libmount nfs-utils.x86_64: E: explicit-lib-dependency libnfsidmap nfs-utils.x86_64: E: explicit-lib-dependency libtirpc nfs-utils.x86_64: W: spelling-error %description -l en_US Showmount -> Show mount, Show-mount, Showground nfs-utils.x86_64: W: spelling-error %description -l en_US umount -> mount, amount, u mount nfs-utils.x86_64: W: incoherent-version-in-changelog 1.2.7-3 ['1:1.2.7-3.fc19', '1:1.2.7-3'] nfs-utils.x86_64: W: only-non-binary-in-usr-lib nfs-utils.x86_64: E: zero-length /var/lib/nfs/etab nfs-utils.x86_64: E: zero-length /var/lib/nfs/state nfs-utils.x86_64: E: non-standard-dir-perm /var/lib/nfs/statd/sm.bak 0700L nfs-utils.x86_64: E: zero-length /var/lib/nfs/xtab nfs-utils.x86_64: E: zero-length /var/lib/nfs/rmtab nfs-utils.x86_64: E: non-standard-dir-perm /var/lib/nfs/statd/sm 0700L nfs-utils.x86_64: E: non-standard-dir-perm /var/lib/nfs/statd 0700L nfs-utils.x86_64: E: setuid-binary /sbin/mount.nfs root 04755L nfs-utils.x86_64: E: non-standard-executable-perm /sbin/mount.nfs 04755L nfs-utils.x86_64: W: no-manual-page-for-binary umount.nfs4 nfs-utils.x86_64: W: no-manual-page-for-binary mount.nfs4 nfs-utils.x86_64: W: no-manual-page-for-binary gss_clnt_send_err nfs-utils.x86_64: W: no-manual-page-for-binary osd_login nfs-utils.x86_64: W: no-manual-page-for-binary start-statd nfs-utils.x86_64: W: no-manual-page-for-binary gss_destroy_creds nfs-utils.x86_64: W: dangerous-command-in-%pre mv nfs-utils.x86_64: W: dangerous-command-in-%post chown nfs-utils.x86_64: W: dangerous-command-in-%preun userdel 1 packages and 0 specfiles checked; 16 errors, 13 warnings. Requires -------- nfs-utils (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/chkconfig /sbin/nologin /usr/bin/env /usr/bin/python config(nfs-utils) fileutils gawk grep keyutils kmod libblkid libblkid.so.1()(64bit) libblkid.so.1(BLKID_1.0)(64bit) libc.so.6()(64bit) libcap libcap.so.2()(64bit) libcom_err.so.2()(64bit) libdevmapper.so.1.02()(64bit) libdevmapper.so.1.02(Base)(64bit) libdl.so.2()(64bit) libevent libevent-2.0.so.5()(64bit) libgssglue libgssglue.so.1()(64bit) libgssglue.so.1(libgssapi_CITI_2)(64bit) libk5crypto.so.3()(64bit) libkeyutils.so.1()(64bit) libkeyutils.so.1(KEYUTILS_0.3)(64bit) libkeyutils.so.1(KEYUTILS_1.0)(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libmount libmount.so.1()(64bit) libmount.so.1(MOUNT_2.19)(64bit) libnfsidmap libnfsidmap.so.0()(64bit) libsqlite3.so.0()(64bit) libtirpc libtirpc.so.1()(64bit) libwrap.so.0()(64bit) quota rpcbind rtld(GNU_HASH) sed sh-utils shadow-utils systemd-units textutils Provides -------- nfs-utils: config(nfs-utils) exportfs mount.nfs mount.nfs4 nfs-utils nfs-utils(x86-64) nfsstat rpc.gssd rpc.idmapd rpc.mountd rpc.nfsd rpc.statd rpc.svcgssd rpcdebug showmount sm-notify start-statd umount.nfs umount.nfs4 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn nfs-utils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires