Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in nuxwdog-devel, nuxwdog-client-java See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nuxwdog- devel , nuxwdog-client-java [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 1 files. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nuxwdog-1.0.1-6.fc19.x86_64.rpm nuxwdog-devel-1.0.1-6.fc19.x86_64.rpm nuxwdog-client-java-1.0.1-6.fc19.x86_64.rpm nuxwdog.x86_64: E: explicit-lib-dependency keyutils-libs nuxwdog.x86_64: W: obsolete-not-provided nuxwdog-client nuxwdog.x86_64: W: obsolete-not-provided nuxwdog-client-perl nuxwdog.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Nuxwdogclient/Nuxwdogclient.so Nuxwdogclient.so()(64bit) nuxwdog.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Nuxwdogclient/Nuxwdogclient.so Nuxwdogclient.so()(64bit) nuxwdog.x86_64: E: incorrect-fsf-address /usr/share/doc/nuxwdog-1.0.1/LICENSE nuxwdog-devel.x86_64: W: obsolete-not-provided nuxwdog-client-devel nuxwdog-devel.x86_64: W: no-documentation nuxwdog-client-java.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 7 warnings. Requires -------- nuxwdog-client-java (rpmlib, GLIBC filtered): java jpackage-utils libc.so.6()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libnspr4.so()(64bit) libnuxwdog.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libstdc++.so.6()(64bit) nuxwdog rtld(GNU_HASH) nuxwdog (rpmlib, GLIBC filtered): /sbin/ldconfig keyutils-libs libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libkeyutils.so.1()(64bit) libkeyutils.so.1(KEYUTILS_0.3)(64bit) libm.so.6()(64bit) libnspr4.so()(64bit) libnuxwdog.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libselinux.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) nss perl(AutoLoader) perl(Carp) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) nuxwdog-devel (rpmlib, GLIBC filtered): libnuxwdog.so.0()(64bit) nuxwdog Provides -------- nuxwdog-client-java: libnuxwdog-jni.so()(64bit) nuxwdog-client-java nuxwdog-client-java(x86-64) nuxwdog: Nuxwdogclient.so()(64bit) libnuxwdog.so.0()(64bit) nuxwdog nuxwdog(x86-64) perl(Nuxwdogclient) nuxwdog-devel: nuxwdog-devel nuxwdog-devel(x86-64) Unversioned so-files -------------------- nuxwdog: /usr/lib64/perl5/vendor_perl/auto/Nuxwdogclient/Nuxwdogclient.so nuxwdog-client-java: /usr/lib64/nuxwdog-jni/libnuxwdog-jni.so MD5-sum check ------------- https://fedorahosted.org/released/nuxwdog/nuxwdog-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 6d0b8c4308338503509f2322ecfc6fe2d234961f5c3e723346daa5322326b601 CHECKSUM(SHA256) upstream package : 6d0b8c4308338503509f2322ecfc6fe2d234961f5c3e723346daa5322326b601 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn nuxwdog -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires