Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Static libraries in -static subpackage, if present. Note: Archive *.a files found in ocaml-gettext-devel, ocaml-gettext- camomile-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml- gettext-devel , ocaml-gettext-camomile , ocaml-gettext-camomile-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 81920 bytes in 6 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ocaml-gettext-0.3.4-7.fc19.x86_64.rpm ocaml-gettext-devel-0.3.4-7.fc19.x86_64.rpm ocaml-gettext-camomile-0.3.4-7.fc19.x86_64.rpm ocaml-gettext-camomile-devel-0.3.4-7.fc19.x86_64.rpm ocaml-gettext-devel.x86_64: W: no-manual-page-for-binary ocaml-gettext ocaml-gettext-devel.x86_64: W: no-manual-page-for-binary ocaml-xgettext 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- ocaml-gettext-camomile (rpmlib, GLIBC filtered): ocaml(Array) ocaml(AvlTree) ocaml(Bigarray) ocaml(Buffer) ocaml(CamomileLibrary) ocaml(CamomileLibraryDefault) ocaml(Complex) ocaml(FilePath) ocaml(FileUtil) ocaml(Format) ocaml(GettextCategory) ocaml(GettextCharset) ocaml(GettextConfig) ocaml(GettextDomain) ocaml(GettextFormat) ocaml(GettextFormat_lexer) ocaml(GettextFormat_parser) ocaml(GettextLocale) ocaml(GettextLocale_lexer) ocaml(GettextLocale_parser) ocaml(GettextLocale_types) ocaml(GettextMo) ocaml(GettextMo_int32) ocaml(GettextMo_lexer) ocaml(GettextMo_parser) ocaml(GettextRealize) ocaml(GettextTranslate) ocaml(GettextTypes) ocaml(GettextUtils) ocaml(Hashtbl) ocaml(IMap) ocaml(ISet) ocaml(Int32) ocaml(Int64) ocaml(Lazy) ocaml(Lexing) ocaml(List) ocaml(Map) ocaml(Obj) ocaml(Parsing) ocaml(Pervasives) ocaml(Printexc) ocaml(Printf) ocaml(Set) ocaml(Stream) ocaml(String) ocaml(Sys) ocaml(Unix) ocaml(runtime) ocaml-gettext ocaml-gettext (rpmlib, GLIBC filtered): libc.so.6()(64bit) ocaml(Arg) ocaml(Array) ocaml(Buffer) ocaml(CamlinternalOO) ocaml(Camlp4) ocaml(Camlp4_config) ocaml(Camlp4_import) ocaml(Char) ocaml(FilePath) ocaml(FileUtil) ocaml(Filename) ocaml(Format) ocaml(Gettext) ocaml(GettextCategory) ocaml(GettextCharset) ocaml(GettextConfig) ocaml(GettextDomain) ocaml(GettextFormat) ocaml(GettextFormat_lexer) ocaml(GettextFormat_parser) ocaml(GettextLocale) ocaml(GettextLocale_lexer) ocaml(GettextLocale_parser) ocaml(GettextLocale_types) ocaml(GettextMo) ocaml(GettextMo_int32) ocaml(GettextMo_lexer) ocaml(GettextMo_parser) ocaml(GettextPo) ocaml(GettextPoComment_parser) ocaml(GettextPo_lexer) ocaml(GettextPo_parser) ocaml(GettextPo_utils) ocaml(GettextStubCompat) ocaml(GettextTranslate) ocaml(GettextTypes) ocaml(GettextUtils) ocaml(Hashtbl) ocaml(Int32) ocaml(Int64) ocaml(Lazy) ocaml(Lexing) ocaml(List) ocaml(Map) ocaml(Marshal) ocaml(Nativeint) ocaml(Obj) ocaml(Parsing) ocaml(Pervasives) ocaml(Printexc) ocaml(Printf) ocaml(Queue) ocaml(Scanf) ocaml(Set) ocaml(Stream) ocaml(String) ocaml(Sys) ocaml(Unix) ocaml(runtime) ocaml-camomile-data rtld(GNU_HASH) ocaml-gettext-devel (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) ocaml-fileutils-devel ocaml-gettext rtld(GNU_HASH) ocaml-gettext-camomile-devel (rpmlib, GLIBC filtered): ocaml-gettext-devel Provides -------- ocaml-gettext-camomile: ocaml(GettextCamomile) ocaml-gettext-camomile ocaml-gettext-camomile(x86-64) ocaml-gettext: dllgettextStub.so()(64bit) ocaml(Gettext) ocaml(GettextCategory) ocaml(GettextCharset) ocaml(GettextCompat) ocaml(GettextCompile) ocaml(GettextConfig) ocaml(GettextDomain) ocaml(GettextDummy) ocaml(GettextFormat) ocaml(GettextFormat_lexer) ocaml(GettextFormat_parser) ocaml(GettextLocale) ocaml(GettextLocale_lexer) ocaml(GettextLocale_parser) ocaml(GettextLocale_types) ocaml(GettextMo) ocaml(GettextMo_int32) ocaml(GettextMo_lexer) ocaml(GettextMo_parser) ocaml(GettextModules) ocaml(GettextPo) ocaml(GettextPoComment_parser) ocaml(GettextPo_lexer) ocaml(GettextPo_parser) ocaml(GettextPo_utils) ocaml(GettextRealize) ocaml(GettextStub) ocaml(GettextStubCompat) ocaml(GettextTranslate) ocaml(GettextTypes) ocaml(GettextUtils) ocaml-gettext ocaml-gettext(x86-64) ocaml-gettext-devel: ocaml-gettext-devel ocaml-gettext-devel(x86-64) ocaml-gettext-camomile-devel: ocaml-gettext-camomile-devel ocaml-gettext-camomile-devel(x86-64) Unversioned so-files -------------------- ocaml-gettext: /usr/lib64/ocaml/stublibs/dllgettextStub.so MD5-sum check ------------- http://forge.ocamlcore.org/frs/download.php/676/ocaml-gettext-0.3.4.tar.gz : CHECKSUM(SHA256) this package : e19214638e8cf078aabda82e7bc4d49a65a557d9c54648a7fd8db6ef84c83302 CHECKSUM(SHA256) upstream package : e19214638e8cf078aabda82e7bc4d49a65a557d9c54648a7fd8db6ef84c83302 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn ocaml-gettext -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires