Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oddjob- mkhomedir [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 11 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: oddjob-0.31.3-2.fc19.x86_64.rpm oddjob-mkhomedir-0.31.3-2.fc19.x86_64.rpm oddjob.x86_64: W: obsolete-not-provided oddjob-devel oddjob.x86_64: W: obsolete-not-provided oddjob-libs oddjob.x86_64: W: obsolete-not-provided oddjob-python oddjob.x86_64: W: only-non-binary-in-usr-lib oddjob-mkhomedir.x86_64: W: spelling-error %description -l en_US pam -> map, Pam, pan oddjob-mkhomedir.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- oddjob (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(oddjob) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libselinux.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.8)(64bit) psmisc rtld(GNU_HASH) systemd-sysv systemd-units oddjob-mkhomedir (rpmlib, GLIBC filtered): /bin/dbus-send /bin/sh config(oddjob-mkhomedir) grep libc.so.6()(64bit) libdbus-1.so.3()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libselinux.so.1()(64bit) oddjob psmisc rtld(GNU_HASH) sed Provides -------- oddjob: config(oddjob) oddjob oddjob(x86-64) oddjob-mkhomedir: config(oddjob-mkhomedir) oddjob-mkhomedir oddjob-mkhomedir(x86-64) pam_oddjob_mkhomedir.so()(64bit) Unversioned so-files -------------------- oddjob-mkhomedir: /usr/lib64/security/pam_oddjob_mkhomedir.so MD5-sum check ------------- http://fedorahosted.org/released/oddjob/oddjob-0.31.3.tar.gz : CHECKSUM(SHA256) this package : 626dde3d3d1f33f6aefaaf4731019d4a35b59b2a42f81055a64dc5f08e312ad2 CHECKSUM(SHA256) upstream package : 626dde3d3d1f33f6aefaaf4731019d4a35b59b2a42f81055a64dc5f08e312ad2 http://fedorahosted.org/released/oddjob/oddjob-0.31.3.tar.gz.sig : CHECKSUM(SHA256) this package : 0464fc117d7971997553bc36acd47d96d94d13dbc89fc2c27d164ed3685f953f CHECKSUM(SHA256) upstream package : 0464fc117d7971997553bc36acd47d96d94d13dbc89fc2c27d164ed3685f953f Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn oddjob -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires