Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in okular, okular-active, okular-part See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in okular- active , okular-devel , okular-libs , okular-part , kio_msits [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in okular [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 430080 bytes in 14 files. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define kio_msits_epoch 7 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1105920 bytes in /usr/share 10240 kio_msits-4.9.98-2.fc19.x86_64.rpm 573440 okular-4.9.98-2.fc19.x86_64.rpm 71680 okular-active-4.9.98-2.fc19.x86_64.rpm 440320 okular- part-4.9.98-2.fc19.x86_64.rpm 10240 okular-libs-4.9.98-2.fc19.x86_64.rpm Rpmlint ------- Checking: okular-4.9.98-2.fc19.x86_64.rpm okular-active-4.9.98-2.fc19.x86_64.rpm okular-devel-4.9.98-2.fc19.x86_64.rpm okular-libs-4.9.98-2.fc19.x86_64.rpm okular-part-4.9.98-2.fc19.x86_64.rpm kio_msits-4.9.98-2.fc19.x86_64.rpm okular-active.x86_64: W: no-documentation okular-active.x86_64: W: no-manual-page-for-binary active-documentviewer okular-devel.x86_64: W: no-documentation okular-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment okular-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment okular-libs.x86_64: W: no-documentation okular-part.x86_64: W: spelling-error Summary(en_US) kpart -> kart, part, apart okular-part.x86_64: W: spelling-error %description -l en_US kpart -> kart, part, apart okular-part.x86_64: W: no-documentation kio_msits.x86_64: W: spelling-error Summary(en_US) kioslave -> enslave kio_msits.x86_64: W: spelling-error %description -l en_US kioslave -> enslave kio_msits.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 12 warnings. Requires -------- okular-part (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libchm.so.0()(64bit) libdjvulibre.so.21()(64bit) libepub.so.0()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkhtml.so.5()(64bit) libkio.so.5()(64bit) libkjs.so.4()(64bit) libkparts.so.4()(64bit) libkprintutils.so.4()(64bit) libkpty.so.4()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libnepomukutils.so.4()(64bit) libokularcore.so.2()(64bit) libphonon.so.4()(64bit) libpoppler-qt4.so.4()(64bit) libpthread.so.0()(64bit) libqca.so.2()(64bit) libqimageblitz.so.4()(64bit) libsolid.so.4()(64bit) libsoprano.so.4()(64bit) libspectre.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libz.so.1()(64bit) okular-libs(x86-64) rtld(GNU_HASH) okular-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkjsapi.so.4()(64bit) libm.so.6()(64bit) libphonon.so.4()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libthreadweaver.so.4()(64bit) rtld(GNU_HASH) okular-devel (rpmlib, GLIBC filtered): kdelibs4-devel libokularcore.so.2()(64bit) okular-libs(x86-64) kio_msits (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libchm.so.0()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) okular-active (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtDeclarative.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtOpenGL.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libactiveapp.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libm.so.6()(64bit) libokularcore.so.2()(64bit) libplasma.so.3()(64bit) libpthread.so.0()(64bit) libqimageblitz.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) okular-part(x86-64) rtld(GNU_HASH) okular (rpmlib, GLIBC filtered): /bin/sh kde-runtime kio_msits libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkparts.so.4()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libnepomukutils.so.4()(64bit) libpthread.so.0()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) okular-part(x86-64) rtld(GNU_HASH) Provides -------- okular-part: okular-part okular-part(x86-64) okularGenerator_chmlib.so()(64bit) okularGenerator_comicbook.so()(64bit) okularGenerator_djvu.so()(64bit) okularGenerator_dvi.so()(64bit) okularGenerator_epub.so()(64bit) okularGenerator_fax.so()(64bit) okularGenerator_fb.so()(64bit) okularGenerator_ghostview.so()(64bit) okularGenerator_kimgio.so()(64bit) okularGenerator_ooo.so()(64bit) okularGenerator_plucker.so()(64bit) okularGenerator_poppler.so()(64bit) okularGenerator_tiff.so()(64bit) okularGenerator_xps.so()(64bit) okularpart.so()(64bit) okular-libs: libokularcore.so.2()(64bit) okular-libs okular-libs(x86-64) okular-devel: okular-devel okular-devel(x86-64) kio_msits: kio_msits kio_msits(x86-64) kio_msits.so()(64bit) okular-active: libokularplugin.so()(64bit) mimehandler(application/epub+zip) mimehandler(application/pdf) mimehandler(application/vnd.kde.okular-archive) mimehandler(application/x-bzpdf) mimehandler(application/x-gzpdf) mimehandler(application/x-wwf) okular-active okular-active(x86-64) okular: mimehandler(application/epub+zip) mimehandler(application/oxps) mimehandler(application/pdf) mimehandler(application/postscript) mimehandler(application/prs.plucker) mimehandler(application/vnd.kde.okular-archive) mimehandler(application/vnd.ms-xpsdocument) mimehandler(application/vnd.oasis.opendocument.text) mimehandler(application/x-bzdvi) mimehandler(application/x-bzpdf) mimehandler(application/x-bzpostscript) mimehandler(application/x-cbr) mimehandler(application/x-cbt) mimehandler(application/x-cbz) mimehandler(application/x-chm) mimehandler(application/x-dvi) mimehandler(application/x-fictionbook+xml) mimehandler(application/x-gzdvi) mimehandler(application/x-gzpdf) mimehandler(application/x-gzpostscript) mimehandler(application/x-wwf) mimehandler(image/bmp) mimehandler(image/fax-g3) mimehandler(image/g3fax) mimehandler(image/gif) mimehandler(image/jp2) mimehandler(image/jpeg) mimehandler(image/png) mimehandler(image/tiff) mimehandler(image/vnd.djvu) mimehandler(image/x-bzeps) mimehandler(image/x-dds) mimehandler(image/x-eps) mimehandler(image/x-exr) mimehandler(image/x-gzeps) mimehandler(image/x-hdr) mimehandler(image/x-ico) mimehandler(image/x-pcx) mimehandler(image/x-portable-bitmap) mimehandler(image/x-portable-graymap) mimehandler(image/x-portable-pixmap) mimehandler(image/x-psd) mimehandler(image/x-rgb) mimehandler(image/x-tga) mimehandler(image/x-xbitmap) mimehandler(image/x-xcf) mimehandler(image/x-xpixmap) mimehandler(video/x-mng) okular okular(x86-64) Unversioned so-files -------------------- okular-active: /usr/lib64/kde4/imports/org/kde/okular/libokularplugin.so okular-part: /usr/lib64/kde4/okularGenerator_chmlib.so okular-part: /usr/lib64/kde4/okularGenerator_comicbook.so okular-part: /usr/lib64/kde4/okularGenerator_djvu.so okular-part: /usr/lib64/kde4/okularGenerator_dvi.so okular-part: /usr/lib64/kde4/okularGenerator_epub.so okular-part: /usr/lib64/kde4/okularGenerator_fax.so okular-part: /usr/lib64/kde4/okularGenerator_fb.so okular-part: /usr/lib64/kde4/okularGenerator_ghostview.so okular-part: /usr/lib64/kde4/okularGenerator_kimgio.so okular-part: /usr/lib64/kde4/okularGenerator_ooo.so okular-part: /usr/lib64/kde4/okularGenerator_plucker.so okular-part: /usr/lib64/kde4/okularGenerator_poppler.so okular-part: /usr/lib64/kde4/okularGenerator_tiff.so okular-part: /usr/lib64/kde4/okularGenerator_xps.so okular-part: /usr/lib64/kde4/okularpart.so kio_msits: /usr/lib64/kde4/kio_msits.so MD5-sum check ------------- ftp://ftp.kde.org/pub/kde/unstable/4.9.98/src/okular-4.9.98.tar.xz : CHECKSUM(SHA256) this package : df7573811b23a688a1f8c4f496a985ff6a04f040c7ea4ac0da1290f8ec68cf3f CHECKSUM(SHA256) upstream package : df7573811b23a688a1f8c4f496a985ff6a04f040c7ea4ac0da1290f8ec68cf3f Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn okular -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires