Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/openslp-1.2.1-17.fc18/openslp/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Large documentation must go in a -doc subpackage. Note: Documentation size is 1024000 bytes in 63 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openslp- server [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1064960 bytes in /usr/share 112640 openslp-server-1.2.1-17.fc18.x86_64.rpm 911360 openslp- devel-1.2.1-17.fc18.x86_64.rpm 40960 openslp-1.2.1-17.fc18.x86_64.rpm Rpmlint ------- Checking: openslp-1.2.1-17.fc18.x86_64.rpm openslp-devel-1.2.1-17.fc18.x86_64.rpm openslp-server-1.2.1-17.fc18.x86_64.rpm openslp.x86_64: W: no-manual-page-for-binary slptool openslp-server.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/slpd openslp-server.x86_64: W: no-manual-page-for-binary slpd openslp-server.x86_64: W: service-default-enabled /etc/rc.d/init.d/slpd openslp-server.x86_64: W: missing-lsb-keyword Short-Description in /etc/rc.d/init.d/slpd openslp-server.x86_64: W: service-default-enabled /etc/rc.d/init.d/slpd openslp-server.x86_64: W: incoherent-init-script-name slpd ('openslp-server', 'openslp-serverd') 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Requires -------- openslp (rpmlib, GLIBC filtered): /sbin/ldconfig config(openslp) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libnsl.so.1()(64bit) libresolv.so.2()(64bit) libslp.so.1()(64bit) rtld(GNU_HASH) openslp-server (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/service chkconfig config(openslp-server) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libnsl.so.1()(64bit) libresolv.so.2()(64bit) openslp rtld(GNU_HASH) openslp-devel (rpmlib, GLIBC filtered): libslp.so.1()(64bit) openslp(x86-64) Provides -------- openslp: config(openslp) libslp.so.1()(64bit) openslp openslp(x86-64) openslp-server: config(openslp-server) openslp-server openslp-server(x86-64) openslp-devel: openslp-devel openslp-devel(x86-64) MD5-sum check ------------- http://dl.sourceforge.net/sourceforge/openslp/openslp-1.2.1.tar.gz : CHECKSUM(SHA256) this package : 08c7ec1e76fdd66461b3784d52047f594405f31ba2791ab0c1ec7c97639f5fbd CHECKSUM(SHA256) upstream package : 9f9cd32e090a6ec37aec902f48b650ae77445f1fb1e02fc09fb2c6e7c603dc7b diff -r also reports differences Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn openslp -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires