Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ovirt-node- recipe , ovirt-node-tools [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 3 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-%{release}-buildroot [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define is_f16 %(test "0%{?fedora}" == "016" && echo 1 || echo 0) %define app_root %{_datadir}/%{name} %define recipe_root %{_datadir }/ovirt-node-recipe %define tools_root %{_datadir}/ovirt-node-tools [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ovirt-node-2.5.1-1.fc19.noarch.rpm ovirt-node-recipe-2.5.1-1.fc19.noarch.rpm ovirt-node-tools-2.5.1-1.fc19.noarch.rpm ovirt-node.noarch: W: spelling-error %description -l en_US hypervisor -> hyper visor, hyper-visor, supervisory ovirt-node.noarch: W: incoherent-version-in-changelog 2.5.0-1 ['2.5.1-1.fc19', '2.5.1-1'] ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/storage.py 0644L /usr/bin/python ovirt-node.noarch: E: script-without-shebang /usr/libexec/ovirt-functions ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/password.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/network.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/ovirtfunctions.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirt_config_setup/cim.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirt_config_setup/collectd.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirt_config_setup/plugins.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/log.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/iscsi.py 0644L /usr/bin/env ovirt-node.noarch: E: script-without-shebang /usr/lib/dracut/modules.d/91ovirtnode/ovirt-boot-functions ovirt-node.noarch: W: non-conffile-in-etc /etc/dracut.conf.d/ovirt-dracut.conf ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/install.py 0644L /usr/bin/python ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/snmp.py 0644L /usr/bin/python ovirt-node.noarch: W: non-conffile-in-etc /etc/modprobe.d/ovirt-qla4xxx.conf ovirt-node.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ovirtnode/kdump.py 0644L /usr/bin/env ovirt-node.noarch: W: no-manual-page-for-binary unpersist ovirt-node.noarch: W: no-manual-page-for-binary persist ovirt-node.noarch: W: dangerous-command-in-%post cp ovirt-node-recipe.noarch: W: obsolete-not-provided ovirt-node-tools ovirt-node-recipe.noarch: W: spurious-executable-perm /usr/share/man/man8/node-creator.8.gz 3 packages and 0 specfiles checked; 14 errors, 9 warnings. Requires -------- ovirt-node (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/chkconfig /usr/bin/env /usr/bin/python /usr/sbin/crond PyPAM anyterm augeas bash bind-utils chkconfig config(ovirt-node) cracklib-python cyrus-sasl cyrus-sasl-gssapi dbus-python dracut ethtool glusterfs-client grub2 iscsi-initiator-utils krb5-workstation libuser-python libvirt nc newt-python nfs-utils ntp python(abi) python-IPy python-gudev qemu-img system-release systemd-units udev wget ovirt-node-tools (rpmlib, GLIBC filtered): /usr/bin/env livecd-tools ovirt-node-recipe (rpmlib, GLIBC filtered): /bin/bash livecd-tools pykickstart Provides -------- ovirt-node: config(ovirt-node) ovirt-node ovirt-node-tools: ovirt-node-tools ovirt-node-recipe: ovirt-node-recipe Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn ovirt-node -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires