Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 153600 bytes in 5 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define glib2_version 2.33.12 %define pkgconfig_version 0.12 %define freetype_version 2.1.5 %define fontconfig_version 2.10.91 %define cairo_version 1.7.6 %define libthai_version 0.1.9 %define harfbuzz_version 0.9.9 %define bin_version 1.8.0 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3020800 bytes in /usr/share 2867200 pango-devel-1.32.6-1.fc19.x86_64.rpm 153600 pango-1.32.6-1.fc19.x86_64.rpm Rpmlint ------- Checking: pango-1.32.6-1.fc19.x86_64.rpm pango-devel-1.32.6-1.fc19.x86_64.rpm pango.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands pango.x86_64: E: incorrect-fsf-address /usr/share/doc/pango-1.32.6/COPYING pango.x86_64: W: no-manual-page-for-binary pango-querymodules-64 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Requires -------- pango-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cairo-devel fontconfig-devel freetype-devel glib2-devel libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpangoxft-1.0.so.0()(64bit) pango(x86-64) pkgconfig(cairo) pkgconfig(fontconfig) pkgconfig(freetype2) pkgconfig(glib-2.0) pkgconfig(gmodule-no-export-2.0) pkgconfig(gobject-2.0) pkgconfig(harfbuzz) pkgconfig(pango) pkgconfig(pangoft2) pkgconfig(xft) pango (rpmlib, GLIBC filtered): /bin/sh cairo freetype glib2 libX11.so.6()(64bit) libXft.so.2()(64bit) libXrender.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpangoxft-1.0.so.0()(64bit) libpthread.so.0()(64bit) libthai libthai.so.0()(64bit) libthai.so.0(LIBTHAI_0.1)(64bit) rtld(GNU_HASH) Provides -------- pango-devel: pango-devel pango-devel(x86-64) pkgconfig(pango) pkgconfig(pangocairo) pkgconfig(pangoft2) pkgconfig(pangoxft) pango: libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpangoxft-1.0.so.0()(64bit) pango pango(x86-64) pango-arabic-lang.so()(64bit) pango-indic-lang.so()(64bit) pango-thai-lang.so()(64bit) Unversioned so-files -------------------- pango: /usr/lib64/pango/1.8.0/modules/pango-arabic-lang.so pango: /usr/lib64/pango/1.8.0/modules/pango-indic-lang.so pango: /usr/lib64/pango/1.8.0/modules/pango-thai-lang.so MD5-sum check ------------- http://download.gnome.org/sources/pango/1.32/pango-1.32.6.tar.xz : CHECKSUM(SHA256) this package : 8e9a3eadebf30a31640f2b3ae0fb455cf92d10d1cad246d0ffe72ec595905174 CHECKSUM(SHA256) upstream package : 8e9a3eadebf30a31640f2b3ae0fb455cf92d10d1cad246d0ffe72ec595905174 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn pango -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires