Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 5468160 bytes in 481 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6338560 bytes in /usr/share 6338560 perl-Template-Toolkit-2.24-2.fc19.x86_64.rpm Rpmlint ------- Checking: perl-Template-Toolkit-2.24-2.fc19.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- perl-Template-Toolkit (rpmlib, GLIBC filtered): libc.so.6()(64bit) perl perl(:MODULE_COMPAT_5.16.2) perl(AppConfig) perl(CGI) perl(Cwd) perl(Data::Dumper) perl(Encode) perl(Exporter) perl(File::Basename) perl(File::Path) perl(File::Spec) perl(File::Temp) perl(Image::Info) perl(POSIX) perl(Pod::POM) perl(Scalar::Util) perl(Template) perl(Template::Base) perl(Template::Config) perl(Template::Constants) perl(Template::Directive) perl(Template::Document) perl(Template::Exception) perl(Template::Filters) perl(Template::Grammar) perl(Template::Iterator) perl(Template::Plugin) perl(Template::Plugin::File) perl(Template::Provider) perl(Template::Service) perl(Template::Stash) perl(Template::VMethods) perl(Template::View) perl(Text::Wrap) perl(base) perl(bytes) perl(constant) perl(locale) perl(overload) perl(strict) perl(vars) perl(warnings) rtld(GNU_HASH) Provides -------- perl-Template-Toolkit: perl(Template) perl(Template::Base) perl(Template::Config) perl(Template::Constants) perl(Template::Context) perl(Template::Directive) perl(Template::Document) perl(Template::Exception) perl(Template::Filters) perl(Template::Grammar) perl(Template::Iterator) perl(Template::Monad::Assert) perl(Template::Monad::Scalar) perl(Template::Namespace::Constants) perl(Template::Parser) perl(Template::Perl) perl(Template::Plugin) perl(Template::Plugin::Assert) perl(Template::Plugin::CGI) perl(Template::Plugin::Datafile) perl(Template::Plugin::Date) perl(Template::Plugin::Date::Calc) perl(Template::Plugin::Date::Manip) perl(Template::Plugin::Directory) perl(Template::Plugin::Dumper) perl(Template::Plugin::File) perl(Template::Plugin::Filter) perl(Template::Plugin::Format) perl(Template::Plugin::HTML) perl(Template::Plugin::Image) perl(Template::Plugin::Iterator) perl(Template::Plugin::Math) perl(Template::Plugin::Pod) perl(Template::Plugin::Procedural) perl(Template::Plugin::Scalar) perl(Template::Plugin::String) perl(Template::Plugin::Table) perl(Template::Plugin::URL) perl(Template::Plugin::View) perl(Template::Plugin::Wrap) perl(Template::Plugins) perl(Template::Provider) perl(Template::Service) perl(Template::Stash) perl(Template::Stash::Context) perl(Template::Stash::XS) perl(Template::Test) perl(Template::TieString) perl(Template::VMethods) perl(Template::View) perl-Template-Toolkit perl-Template-Toolkit(x86-64) perl-Template-Toolkit-examples Unversioned so-files -------------------- perl-Template-Toolkit: /usr/lib64/perl5/vendor_perl/auto/Template/Stash/XS/XS.so MD5-sum check ------------- http://search.cpan.org/CPAN/authors/id/A/AB/ABW/Template-Toolkit-2.24.tar.gz : CHECKSUM(SHA256) this package : 38834aa8c249f7b7fb8b7238f086a08947ea7d472d78f1f5e2b9f3dbf49d01c8 CHECKSUM(SHA256) upstream package : 38834aa8c249f7b7fb8b7238f086a08947ea7d472d78f1f5e2b9f3dbf49d01c8 http://tt2.org/download/TT_v224_html_docs.tar.gz : CHECKSUM(SHA256) this package : 9dacb6a2468f1d27bbdf2eb35dc0fefb641e200b87c7c7277342accd2817823c CHECKSUM(SHA256) upstream package : 9dacb6a2468f1d27bbdf2eb35dc0fefb641e200b87c7c7277342accd2817823c Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn perl-Template-Toolkit -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires