Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/rpm/macros.php [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in php-cli , php-fpm , php-devel , php-embedded [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 890880 bytes in 41 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: php-5.4.11-2.fc19.x86_64.rpm php-cli-5.4.11-2.fc19.x86_64.rpm php-fpm-5.4.11-2.fc19.x86_64.rpm php-devel-5.4.11-2.fc19.x86_64.rpm php-embedded-5.4.11-2.fc19.x86_64.rpm php.x86_64: W: name-repeated-in-summary C PHP php.x86_64: W: spelling-error %description -l en_US webpage -> web page, web-page, pageboy php.x86_64: W: obsolete-not-provided php-dbg php.x86_64: W: obsolete-not-provided php3 php.x86_64: W: obsolete-not-provided phpfi php.x86_64: W: obsolete-not-provided stronghold-php php.x86_64: W: no-documentation php.x86_64: E: non-standard-dir-perm /var/lib/php/session 0770L php-cli.x86_64: W: no-manual-page-for-binary phar.phar php-cli.x86_64: W: no-manual-page-for-binary phar php-cli.x86_64: W: no-manual-page-for-binary php-cgi php-fpm.x86_64: W: only-non-binary-in-usr-lib php-fpm.x86_64: E: non-standard-dir-perm /var/log/php-fpm 0770L php-devel.x86_64: W: obsolete-not-provided php-pecl-pdo-devel php-devel.x86_64: W: only-non-binary-in-usr-lib php-devel.x86_64: W: conffile-without-noreplace-flag /etc/rpm/macros.php php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_string.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_encoding.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfilter_pass.h php-devel.x86_64: E: incorrect-fsf-address /usr/lib64/php/build/shtool php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_allocators.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_language.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfilter_pass.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_convert.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_consts.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_encoding.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_defs.h php-devel.x86_64: E: rpath-in-buildconfig /usr/bin/php-config lines ['20'] php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_ident.h php-devel.x86_64: E: rpath-in-buildconfig /usr/bin/zts-php-config lines ['20'] php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfilter_8bit.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_language.h php-devel.x86_64: E: non-executable-script /usr/lib64/php-zts/build/run-tests.php 0644L /usr/bin/env php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_string.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfilter_wchar.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfilter_8bit.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_filter_output.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_memory_device.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfilter_wchar.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_memory_device.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_defs.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_allocators.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php/ext/mbstring/libmbfl/mbfl/mbfl_convert.h php-devel.x86_64: E: non-executable-script /usr/lib64/php/build/run-tests.php 0644L /usr/bin/env php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_filter_output.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_consts.h php-devel.x86_64: E: incorrect-fsf-address /usr/include/php-zts/php/ext/mbstring/libmbfl/mbfl/mbfl_ident.h php-devel.x86_64: E: incorrect-fsf-address /usr/lib64/php-zts/build/shtool php-devel.x86_64: W: no-manual-page-for-binary zts-php php-devel.x86_64: W: no-manual-page-for-binary zts-php-config php-devel.x86_64: W: no-manual-page-for-binary zts-phpize php-embedded.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 34 errors, 18 warnings. Requires -------- php-fpm (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/useradd libbz2.so.1()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libgmp.so.10()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpcre.so.1()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.11)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) php-common(x86-64) rtld(GNU_HASH) systemd-sysv systemd-units php (rpmlib, GLIBC filtered): httpd httpd-mmn libbz2.so.1()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libgmp.so.10()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpcre.so.1()(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.11)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) php-cli(x86-64) php-common(x86-64) rtld(GNU_HASH) php-devel (rpmlib, GLIBC filtered): /bin/sh autoconf automake libbz2.so.1()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libedit.so.0()(64bit) libgmp.so.10()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libncurses.so.5()(64bit) libnsl.so.1()(64bit) libpcre.so.1()(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libtinfo.so.5()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.11)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) pcre-devel(x86-64) php-cli(x86-64) rtld(GNU_HASH) php-cli (rpmlib, GLIBC filtered): /bin/sh libbz2.so.1()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libedit.so.0()(64bit) libgmp.so.10()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libncurses.so.5()(64bit) libnsl.so.1()(64bit) libpcre.so.1()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libtinfo.so.5()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.11)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) php-common(x86-64) rtld(GNU_HASH) php-embedded (rpmlib, GLIBC filtered): /sbin/ldconfig libbz2.so.1()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libgmp.so.10()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpcre.so.1()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.11)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) php-common(x86-64) rtld(GNU_HASH) Provides -------- php-fpm: php-fpm php-fpm(x86-64) php: mod_php php php(x86-64) php-zts php-zts(x86-64) php-devel: php-devel php-devel(x86-64) php-zts-devel php-zts-devel(x86-64) php-cli: php-cgi php-cgi(x86-64) php-cli php-cli(x86-64) php-pcntl php-pcntl(x86-64) php-readline php-readline(x86-64) php-embedded: libphp5-5.4.so()(64bit) php-embedded php-embedded(x86-64) php-embedded-devel php-embedded-devel(x86-64) Unversioned so-files -------------------- php: /usr/lib64/httpd/modules/libphp5-zts.so php: /usr/lib64/httpd/modules/libphp5.so php-embedded: /usr/lib64/libphp5-5.4.so php-embedded: /usr/lib64/libphp5.so MD5-sum check ------------- http://www.php.net/distributions/php-5.4.11.tar.bz2 : CHECKSUM(SHA256) this package : d4d095a965f015896d25321842da586076aca5fed4c52939866548ebad5b0fdb CHECKSUM(SHA256) upstream package : d4d095a965f015896d25321842da586076aca5fed4c52939866548ebad5b0fdb Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn php -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires