Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package requires php-common instead of php. See: http://fedoraproject.org/wiki/Packaging:PHP ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/rpm/macros.pear [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 215040 bytes in 30 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: php-pear-1.9.4-14.fc19.noarch.rpm php-pear.noarch: E: explicit-lib-dependency php-zlib php-pear.noarch: W: conffile-without-noreplace-flag /etc/rpm/macros.pear php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry/.channel.__uri php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry/.channel.__uri php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.channels/.alias php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.channels/.alias php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.lock php-pear.noarch: E: zero-length /var/lib/pear/.lock php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.depdblock php-pear.noarch: E: zero-length /var/lib/pear/.depdblock php-pear.noarch: W: file-not-utf8 /usr/share/doc/pear/XML_Util/examples/example.php php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry php-pear.noarch: E: incorrect-fsf-address /usr/share/pear-data/Structures_Graph/LICENSE php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry/.channel.doc.php.net php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry/.channel.doc.php.net php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.filemap php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry/.channel.pecl.php.net php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.registry/.channel.pecl.php.net php-pear.noarch: E: incorrect-fsf-address /usr/share/doc/php-pear-1.9.4/LICENSE-Structures_Graph php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.channels php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.channels php-pear.noarch: W: hidden-file-or-dir /var/lib/pear/.depdb php-pear.noarch: W: no-manual-page-for-binary pear php-pear.noarch: W: no-manual-page-for-binary peardev php-pear.noarch: W: no-manual-page-for-binary pecl php-pear.noarch: W: install-file-in-docs /usr/share/doc/pear/PEAR/INSTALL php-pear.noarch: W: dangerous-command-in-%pre mv 1 packages and 0 specfiles checked; 5 errors, 23 warnings. Requires -------- php-pear (rpmlib, GLIBC filtered): /bin/sh config(php-pear) php-bz2 php-cli php-ftp php-pcre php-posix php-tokenizer php-xml php-zlib Provides -------- php-pear: config(php-pear) php-pear php-pear(Archive_Tar) php-pear(Console_Getopt) php-pear(PEAR) php-pear(Structures_Graph) php-pear(XML_Util) php-pear-XML-Util MD5-sum check ------------- http://download.pear.php.net/package/PEAR-1.9.4.tgz : CHECKSUM(SHA256) this package : 80c329264a0363c6222b2f750e1646015161c9787bb4041f5ab41d95160bb93c CHECKSUM(SHA256) upstream package : 80c329264a0363c6222b2f750e1646015161c9787bb4041f5ab41d95160bb93c http://pear.php.net/get/XML_Util-1.2.1.tgz : CHECKSUM(SHA256) this package : 10edc563d20d6312cba41649e57e56b78b9330c486e9a8397fd5e109744e7273 CHECKSUM(SHA256) upstream package : 10edc563d20d6312cba41649e57e56b78b9330c486e9a8397fd5e109744e7273 http://pear.php.net/get/Archive_Tar-1.3.10.tgz : CHECKSUM(SHA256) this package : ed270707ba5a9b4ec5caeb8914ced5561c3e2ac7b3a5aa22ae90efe9e1792a22 CHECKSUM(SHA256) upstream package : ed270707ba5a9b4ec5caeb8914ced5561c3e2ac7b3a5aa22ae90efe9e1792a22 http://pear.php.net/get/Structures_Graph-1.0.4.tgz : CHECKSUM(SHA256) this package : 3619ac17892855117283e3555b1a156df0eb4d175e70e63d9c6d27d2c31a2e4f CHECKSUM(SHA256) upstream package : 3619ac17892855117283e3555b1a156df0eb4d175e70e63d9c6d27d2c31a2e4f http://pear.php.net/get/Console_Getopt-1.3.1.tgz : CHECKSUM(SHA256) this package : 9381ad3f8e48574c38917b55caae2cd20cf152af8e65a31d09931fad829161c4 CHECKSUM(SHA256) upstream package : 9381ad3f8e48574c38917b55caae2cd20cf152af8e65a31d09931fad829161c4 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn php-pear -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires