Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package requires php-common instead of php. See: http://fedoraproject.org/wiki/Packaging:PHP - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel-reviews/php- pecl-apc-3.1.14-1.fc19/php-pecl-apc/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in apc-panel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 112640 bytes in 7 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: php-pecl-apc-3.1.14-1.fc19.x86_64.rpm php-pecl-apc-devel-3.1.14-1.fc19.x86_64.rpm apc-panel-3.1.14-1.fc19.noarch.rpm php-pecl-apc.x86_64: W: install-file-in-docs /usr/share/doc/php-pecl-apc-3.1.14/INSTALL php-pecl-apc-devel.x86_64: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized php-pecl-apc-devel.x86_64: W: no-documentation apc-panel.noarch: W: no-documentation apc-panel.noarch: E: non-standard-dir-perm /etc/apc-panel 0750L 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Requires -------- php-pecl-apc (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pecl libc.so.6()(64bit) librt.so.1()(64bit) php(api) php(zend-abi) rtld(GNU_HASH) apc-panel (rpmlib, GLIBC filtered): httpd mod_php php-gd php-pecl-apc php-pecl-apc-devel (rpmlib, GLIBC filtered): php-devel(x86-64) php-pecl-apc(x86-64) Provides -------- php-pecl-apc: php-apc php-apc(x86-64) php-pecl(APC) php-pecl(APC)(x86-64) php-pecl-apc php-pecl-apc(x86-64) apc-panel: apc-panel php-pecl-apc-devel: php-pecl-apc-devel php-pecl-apc-devel(x86-64) Unversioned so-files -------------------- php-pecl-apc: /usr/lib64/php-zts/modules/apc.so php-pecl-apc: /usr/lib64/php/modules/apc.so MD5-sum check ------------- http://pecl.php.net/get/APC-3.1.14.tgz : CHECKSUM(SHA256) this package : b377537d50381930380ab48e28255961728a4a7cb4322bc78c4812f8b1f34eb0 CHECKSUM(SHA256) upstream package : 043eef5e6f884e055af51d3cea6ab20fb3cd3d4804babeaeb783431592db8a49 diff -r also reports differences Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn php-pecl-apc -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires