Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - GConf schemas are properly installed Note: gconf file(s) in pidgin See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: http://fedoraproject.org/wiki/Packaging:Perl - gtk-update-icon-cache is invoked when required Note: icons in pidgin See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - update-desktop-database is invoked when required Note: desktop file(s) in pidgin See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Large documentation must go in a -doc subpackage. Note: Documentation size is 20070400 bytes in 687 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pidgin- devel , pidgin-perl , libpurple , libpurple-devel , libpurple-perl , libpurple-tcl , finch , finch-devel , pidgin-docs [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-root [!]: Uses parallel make. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 45588480 bytes in /usr/share 23582720 libpurple-2.10.6-4.fc19.x86_64.rpm 19865600 pidgin- docs-2.10.6-4.fc19.x86_64.rpm 10240 libpurple- perl-2.10.6-4.fc19.x86_64.rpm 10240 libpurple- devel-2.10.6-4.fc19.x86_64.rpm 10240 finch-2.10.6-4.fc19.x86_64.rpm 2099200 pidgin-2.10.6-4.fc19.x86_64.rpm 10240 pidgin- perl-2.10.6-4.fc19.x86_64.rpm Rpmlint ------- Checking: pidgin-2.10.6-4.fc19.x86_64.rpm pidgin-devel-2.10.6-4.fc19.x86_64.rpm pidgin-perl-2.10.6-4.fc19.x86_64.rpm libpurple-2.10.6-4.fc19.x86_64.rpm libpurple-devel-2.10.6-4.fc19.x86_64.rpm libpurple-perl-2.10.6-4.fc19.x86_64.rpm libpurple-tcl-2.10.6-4.fc19.x86_64.rpm finch-2.10.6-4.fc19.x86_64.rpm finch-devel-2.10.6-4.fc19.x86_64.rpm pidgin-docs-2.10.6-4.fc19.x86_64.rpm pidgin.x86_64: W: spelling-error Summary(en_US) multiprotocol -> multiprocessor pidgin.x86_64: W: spelling-error %description -l en_US perl -> Perl, peel, perk pidgin.x86_64: W: obsolete-not-provided pidgin-evolution pidgin.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/purple.schemas pidgin.x86_64: W: no-manual-page-for-binary gaim pidgin-devel.x86_64: W: self-obsoletion gaim-devel obsoletes gaim-devel = 2.10.6-4.fc19 pidgin-devel.x86_64: W: no-documentation libpurple.x86_64: W: summary-not-capitalized C libpurple library for IM clients like Pidgin and Finch libpurple.x86_64: W: name-repeated-in-summary C libpurple libpurple.x86_64: W: obsolete-not-provided gaim libpurple.x86_64: W: obsolete-not-provided gaim-meanwhile libpurple.x86_64: W: shared-lib-calls-exit /usr/lib64/libpurple-client.so.0.10.6 exit@GLIBC_2.2.5 libpurple.x86_64: W: no-manual-page-for-binary purple-client-example libpurple.x86_64: W: no-manual-page-for-binary purple-url-handler libpurple.x86_64: W: no-manual-page-for-binary purple-remote libpurple.x86_64: W: no-manual-page-for-binary purple-send libpurple.x86_64: W: no-manual-page-for-binary purple-send-async libpurple-devel.x86_64: W: no-documentation libpurple-tcl.x86_64: W: no-documentation finch.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses finch-devel.x86_64: W: no-documentation pidgin-docs.x86_64: W: spelling-error Summary(en_US) libpurple -> lib purple, lib-purple, purple pidgin-docs.x86_64: W: spelling-error %description -l en_US Doxygen -> Oxygen, D oxygen 10 packages and 0 specfiles checked; 0 errors, 23 warnings. Requires -------- finch-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config finch libgnt.so.0()(64bit) libpurple-devel ncurses-devel pkgconfig pkgconfig(glib-2.0) pkgconfig(gnt) pkgconfig(purple) pidgin-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gtk2-devel libpurple-devel pidgin pkgconfig pkgconfig(gtk+-2.0) pkgconfig(purple) pidgin-perl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpurple libpurple-perl perl perl(Carp) perl(Purple) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) libpurple-perl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libperl.so()(64bit) libpthread.so.0()(64bit) libpurple libresolv.so.2()(64bit) librt.so.1()(64bit) libutil.so.1()(64bit) perl perl(:MODULE_COMPAT_5.16.1) perl(AutoLoader) perl(Carp) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) pidgin (rpmlib, GLIBC filtered): /bin/sh GConf2 glib2 gstreamer-plugins-bad-free gstreamer-plugins-good libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXss.so.1()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfarstream-0.1.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstbase-0.10.so.0()(64bit) libgstinterfaces-0.10.so.0()(64bit) libgstreamer-0.10.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libgtkspell.so.0()(64bit) libidn.so.11()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpurple(x86-64) libpurple.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH) xdg-utils pidgin-docs (rpmlib, GLIBC filtered): pidgin libpurple-tcl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpthread.so.0()(64bit) libpurple libresolv.so.2()(64bit) librt.so.1()(64bit) libtcl8.5.so()(64bit) libtk8.5.so()(64bit) rtld(GNU_HASH) finch (rpmlib, GLIBC filtered): /sbin/ldconfig glib2 libX11.so.6()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfarstream-0.1.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnt.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstbase-0.10.so.0()(64bit) libgstinterfaces-0.10.so.0()(64bit) libgstreamer-0.10.so.0()(64bit) libgthread-2.0.so.0()(64bit) libidn.so.11()(64bit) libm.so.6()(64bit) libncursesw.so.5()(64bit) libnsl.so.1()(64bit) libpanelw.so.5()(64bit) libpthread.so.0()(64bit) libpurple libpurple.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libtinfo.so.5()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) libpurple-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus-devel dbus-glib-devel libpurple libpurple-client.so.0()(64bit) libpurple.so.0()(64bit) pkgconfig pkgconfig(glib-2.0) libpurple (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig /usr/bin/python ca-certificates config(libpurple) cyrus-sasl-md5 cyrus-sasl-plain glib2 libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libavahi-glib.so.1()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdl.so.2()(64bit) libfarstream-0.1.so.0()(64bit) libgadu.so.3()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstbase-0.10.so.0()(64bit) libgstinterfaces-0.10.so.0()(64bit) libgstreamer-0.10.so.0()(64bit) libgthread-2.0.so.0()(64bit) libidn.so.11()(64bit) libidn.so.11(LIBIDN_1.0)(64bit) libjabber.so.0()(64bit) libm.so.6()(64bit) libmeanwhile.so.1()(64bit) libnsl.so.1()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnss3.so(NSS_3.2)(64bit) libnss3.so(NSS_3.3)(64bit) libnss3.so(NSS_3.4)(64bit) libnssutil3.so()(64bit) liboscar.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpthread.so.0()(64bit) libpurple-client.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libsasl2.so.2()(64bit) libsilc-1.1.so.2()(64bit) libsilcclient-1.1.so.3()(64bit) libsmime3.so()(64bit) libsmime3.so(NSS_3.4)(64bit) libssl3.so()(64bit) libssl3.so(NSS_3.2)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libymsg.so.0()(64bit) rtld(GNU_HASH) Provides -------- finch-devel: finch-devel finch-devel(x86-64) pkgconfig(finch) pkgconfig(gnt) pidgin-devel: gaim-devel pidgin-devel pidgin-devel(x86-64) pkgconfig(pidgin) pidgin-perl: Pidgin.so()(64bit) perl(Pidgin) pidgin-perl pidgin-perl(x86-64) libpurple-perl: Purple.so()(64bit) libpurple-perl libpurple-perl(x86-64) perl(Purple) perl.so()(64bit) pidgin: convcolors.so()(64bit) extplacement.so()(64bit) gaim gestures.so()(64bit) gtkbuddynote.so()(64bit) history.so()(64bit) iconaway.so()(64bit) markerline.so()(64bit) musicmessaging.so()(64bit) notify.so()(64bit) pidgin pidgin(x86-64) pidginrc.so()(64bit) sendbutton.so()(64bit) spellchk.so()(64bit) themeedit.so()(64bit) ticker.so()(64bit) timestamp.so()(64bit) timestamp_format.so()(64bit) vvconfig.so()(64bit) xmppconsole.so()(64bit) xmppdisco.so()(64bit) pidgin-docs: libpurple-docs pidgin-docs pidgin-docs(x86-64) libpurple-tcl: libpurple-tcl libpurple-tcl(x86-64) tcl.so()(64bit) finch: finch finch(x86-64) gntclipboard.so()(64bit) gntgf.so()(64bit) gnthistory.so()(64bit) gntlastlog.so()(64bit) gnttinyurl.so()(64bit) grouping.so()(64bit) irssi.so()(64bit) libgnt.so.0()(64bit) s.so()(64bit) libpurple-devel: libpurple-devel libpurple-devel(x86-64) pkgconfig(purple) libpurple: autoaccept.so()(64bit) buddynote.so()(64bit) config(libpurple) dbus-example.so()(64bit) idle.so()(64bit) joinpart.so()(64bit) libaim.so()(64bit) libbonjour.so()(64bit) libgg.so()(64bit) libicq.so()(64bit) libirc.so()(64bit) libjabber.so.0()(64bit) libmsn.so()(64bit) libmxit.so()(64bit) libmyspace.so()(64bit) libnovell.so()(64bit) liboscar.so.0()(64bit) libpurple libpurple(x86-64) libpurple-client.so.0()(64bit) libpurple.so.0()(64bit) libsametime.so()(64bit) libsilcpurple.so()(64bit) libsimple.so()(64bit) libtmpone_time_password.so.so()(64bit) libxmpp.so()(64bit) libyahoo.so()(64bit) libyahoojp.so()(64bit) libymsg.so.0()(64bit) libzephyr.so()(64bit) log_reader.so()(64bit) newline.so()(64bit) offlinemsg.so()(64bit) psychic.so()(64bit) ssl-nss.so()(64bit) ssl.so()(64bit) statenotify.so()(64bit) Unversioned so-files -------------------- pidgin: /usr/lib64/pidgin/convcolors.so pidgin: /usr/lib64/pidgin/extplacement.so pidgin: /usr/lib64/pidgin/gestures.so pidgin: /usr/lib64/pidgin/gtkbuddynote.so pidgin: /usr/lib64/pidgin/history.so pidgin: /usr/lib64/pidgin/iconaway.so pidgin: /usr/lib64/pidgin/markerline.so pidgin: /usr/lib64/pidgin/musicmessaging.so pidgin: /usr/lib64/pidgin/notify.so pidgin: /usr/lib64/pidgin/pidginrc.so pidgin: /usr/lib64/pidgin/sendbutton.so pidgin: /usr/lib64/pidgin/spellchk.so pidgin: /usr/lib64/pidgin/themeedit.so pidgin: /usr/lib64/pidgin/ticker.so pidgin: /usr/lib64/pidgin/timestamp.so pidgin: /usr/lib64/pidgin/timestamp_format.so pidgin: /usr/lib64/pidgin/vvconfig.so pidgin: /usr/lib64/pidgin/xmppconsole.so pidgin: /usr/lib64/pidgin/xmppdisco.so pidgin-perl: /usr/lib64/pidgin/perl/auto/Pidgin/Pidgin.so libpurple: /usr/lib64/purple-2/autoaccept.so libpurple: /usr/lib64/purple-2/buddynote.so libpurple: /usr/lib64/purple-2/dbus-example.so libpurple: /usr/lib64/purple-2/idle.so libpurple: /usr/lib64/purple-2/joinpart.so libpurple: /usr/lib64/purple-2/libaim.so libpurple: /usr/lib64/purple-2/libbonjour.so libpurple: /usr/lib64/purple-2/libgg.so libpurple: /usr/lib64/purple-2/libicq.so libpurple: /usr/lib64/purple-2/libirc.so libpurple: /usr/lib64/purple-2/libmsn.so libpurple: /usr/lib64/purple-2/libmxit.so libpurple: /usr/lib64/purple-2/libmyspace.so libpurple: /usr/lib64/purple-2/libnovell.so libpurple: /usr/lib64/purple-2/libsametime.so libpurple: /usr/lib64/purple-2/libsilcpurple.so libpurple: /usr/lib64/purple-2/libsimple.so libpurple: /usr/lib64/purple-2/libxmpp.so libpurple: /usr/lib64/purple-2/libyahoo.so libpurple: /usr/lib64/purple-2/libyahoojp.so libpurple: /usr/lib64/purple-2/libzephyr.so libpurple: /usr/lib64/purple-2/log_reader.so libpurple: /usr/lib64/purple-2/newline.so libpurple: /usr/lib64/purple-2/offlinemsg.so libpurple: /usr/lib64/purple-2/one_time_password.so libpurple: /usr/lib64/purple-2/psychic.so libpurple: /usr/lib64/purple-2/ssl-nss.so libpurple: /usr/lib64/purple-2/ssl.so libpurple: /usr/lib64/purple-2/statenotify.so libpurple-perl: /usr/lib64/purple-2/perl.so libpurple-perl: /usr/lib64/purple-2/perl/auto/Purple/Purple.so libpurple-tcl: /usr/lib64/purple-2/tcl.so finch: /usr/lib64/finch/gntclipboard.so finch: /usr/lib64/finch/gntgf.so finch: /usr/lib64/finch/gnthistory.so finch: /usr/lib64/finch/gntlastlog.so finch: /usr/lib64/finch/gnttinyurl.so finch: /usr/lib64/finch/grouping.so finch: /usr/lib64/gnt/irssi.so finch: /usr/lib64/gnt/s.so MD5-sum check ------------- http://downloads.sourceforge.net/pidgin/pidgin-2.10.6.tar.bz2 : CHECKSUM(SHA256) this package : 3e25a633b97cbfa8326999a30282e7a662a9b9bbf2853be84af0b8fb60392c96 CHECKSUM(SHA256) upstream package : 3e25a633b97cbfa8326999a30282e7a662a9b9bbf2853be84af0b8fb60392c96 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn pidgin -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires