Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in plymouth- system-theme , plymouth-core-libs , plymouth-graphics-libs , plymouth- devel , plymouth-scripts , plymouth-plugin-label , plymouth-plugin-fade- throbber , plymouth-theme-fade-in , plymouth-plugin-throbgress , plymouth-theme-spinfinity , plymouth-plugin-space-flares , plymouth- theme-solar , plymouth-plugin-two-step , plymouth-theme-charge , plymouth-plugin-script , plymouth-theme-script , plymouth-theme-spinner [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Only use %_sourcedir in very specific situations. Note: %_sourcedir/$RPM_SOURCE_DIR is used. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define plymouthdaemon_execdir %{_sbindir} %define plymouthclient_execdir %{_bindir} %define plymouth_libdir %{_libdir} %define plymouth_initrd_file /boot/initrd-plymouth.img [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: plymouth-0.8.8-5.fc18.x86_64.rpm plymouth-system-theme-0.8.8-5.fc18.x86_64.rpm plymouth-core-libs-0.8.8-5.fc18.x86_64.rpm plymouth-graphics-libs-0.8.8-5.fc18.x86_64.rpm plymouth-devel-0.8.8-5.fc18.x86_64.rpm plymouth-scripts-0.8.8-5.fc18.x86_64.rpm plymouth-plugin-label-0.8.8-5.fc18.x86_64.rpm plymouth-plugin-fade-throbber-0.8.8-5.fc18.x86_64.rpm plymouth-theme-fade-in-0.8.8-5.fc18.x86_64.rpm plymouth-plugin-throbgress-0.8.8-5.fc18.x86_64.rpm plymouth-theme-spinfinity-0.8.8-5.fc18.x86_64.rpm plymouth-plugin-space-flares-0.8.8-5.fc18.x86_64.rpm plymouth-theme-solar-0.8.8-5.fc18.x86_64.rpm plymouth-plugin-two-step-0.8.8-5.fc18.x86_64.rpm plymouth-theme-charge-0.8.8-5.fc18.x86_64.rpm plymouth-plugin-script-0.8.8-5.fc18.x86_64.rpm plymouth-theme-script-0.8.8-5.fc18.x86_64.rpm plymouth-theme-spinner-0.8.8-5.fc18.x86_64.rpm plymouth.x86_64: W: obsolete-not-provided plymouth-text-and-details-only plymouth.x86_64: W: obsolete-not-provided plymouth-plugin-pulser plymouth.x86_64: W: obsolete-not-provided plymouth-theme-pulser plymouth.x86_64: W: obsolete-not-provided plymouth-gdm-hooks plymouth.x86_64: W: obsolete-not-provided plymouth-utils plymouth.x86_64: W: dangling-relative-symlink /usr/bin/rhgb-client ../../bin/plymouth plymouth.x86_64: W: no-manual-page-for-binary plymouthd plymouth.x86_64: W: no-manual-page-for-binary rhgb-client plymouth.x86_64: W: dangerous-command-in-%post cp plymouth.x86_64: W: dangerous-command-in-%postun rm plymouth.x86_64: W: one-line-command-in-%posttrans /usr/libexec/plymouth/plymouth-generate-initrd plymouth-system-theme.x86_64: W: spelling-error %description -l en_US metapackage -> meta package, meta-package, prepackage plymouth-system-theme.x86_64: W: no-documentation plymouth-core-libs.x86_64: W: spelling-error %description -l en_US libply -> limply, lib ply, lib-ply plymouth-core-libs.x86_64: W: no-documentation plymouth-graphics-libs.x86_64: W: spelling-error %description -l en_US libply -> limply, lib ply, lib-ply plymouth-graphics-libs.x86_64: W: no-documentation plymouth-devel.x86_64: W: spelling-error %description -l en_US libply -> limply, lib ply, lib-ply plymouth-devel.x86_64: W: spelling-error %description -l en_US libplybootsplash -> splashily plymouth-devel.x86_64: W: no-documentation plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-text-display.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-renderer-plugin.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-logger.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-pixel-buffer.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-rectangle.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-event-loop.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-progress.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-list.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-boot-client/ply-boot-protocol.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-animation.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-key-file.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-utils.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-image.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-bitarray.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-renderer.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-throbber.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-keyboard.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-label.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-text-progress-bar.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-boot-splash-plugin.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-trigger.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-boot-splash.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-label-plugin.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-pixel-display.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-region.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-progress-animation.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-array.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-core/ply-terminal.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-command-parser.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-entry.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-buffer.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-terminal-session.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply/ply-hashtable.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-boot-client/ply-boot-client.h plymouth-devel.x86_64: E: incorrect-fsf-address /usr/include/plymouth-1/ply-splash-graphics/ply-progress-bar.h plymouth-scripts.x86_64: W: no-documentation plymouth-scripts.x86_64: W: no-manual-page-for-binary plymouth-set-default-theme plymouth-plugin-label.x86_64: W: spelling-error %description -l en_US pango -> pang, pangs, panto plymouth-plugin-label.x86_64: W: spelling-error %description -l en_US cairo -> Cairo, cairn plymouth-plugin-label.x86_64: W: no-documentation plymouth-plugin-fade-throbber.x86_64: W: no-documentation plymouth-theme-fade-in.x86_64: W: self-obsoletion plymouth-plugin-fade-in <= 0.7.0-0.2009.05.08.2 obsoletes plymouth-plugin-fade-in = 0.7.0-0.2009.05.08.2 plymouth-theme-fade-in.x86_64: W: no-documentation plymouth-plugin-throbgress.x86_64: W: no-documentation plymouth-theme-spinfinity.x86_64: W: self-obsoletion plymouth-plugin-spinfinity <= 0.7.0-0.2009.05.08.2 obsoletes plymouth-plugin-spinfinity = 0.7.0-0.2009.05.08.2 plymouth-theme-spinfinity.x86_64: W: no-documentation plymouth-plugin-space-flares.x86_64: W: no-documentation plymouth-theme-solar.x86_64: W: self-obsoletion plymouth-plugin-solar <= 0.7.0-0.2009.05.08.2 obsoletes plymouth-plugin-solar = 0.7.0-0.2009.05.08.2 plymouth-theme-solar.x86_64: W: no-documentation plymouth-plugin-two-step.x86_64: W: no-documentation plymouth-theme-charge.x86_64: W: no-documentation plymouth-plugin-script.x86_64: W: spelling-error %description -l en_US scriptable -> scrip table, scrip-table, script able plymouth-plugin-script.x86_64: W: no-documentation plymouth-theme-script.x86_64: W: no-documentation plymouth-theme-spinner.x86_64: W: no-documentation 18 packages and 0 specfiles checked; 35 errors, 40 warnings. Requires -------- plymouth-theme-charge (rpmlib, GLIBC filtered): /bin/sh plymouth-plugin-two-step plymouth-scripts plymouth-scripts (rpmlib, GLIBC filtered): /bin/bash coreutils cpio dracut findutils gzip plymouth plymouth-core-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply.so.2()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) plymouth-theme-spinfinity (rpmlib, GLIBC filtered): /bin/sh plymouth-plugin-throbgress plymouth-scripts plymouth-theme-fade-in (rpmlib, GLIBC filtered): /bin/sh plymouth-plugin-fade-throbber plymouth-scripts plymouth-theme-script (rpmlib, GLIBC filtered): /usr/sbin/plymouth-set-default-theme plymouth-plugin-script plymouth-theme-solar (rpmlib, GLIBC filtered): /bin/sh plymouth-plugin-space-flares plymouth-scripts plymouth-system-theme plymouth-plugin-label (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) plymouth plymouth-libs rtld(GNU_HASH) plymouth-plugin-fade-throbber (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) librt.so.1()(64bit) plymouth plymouth-libs rtld(GNU_HASH) plymouth (rpmlib, GLIBC filtered): /bin/sh config(plymouth) initscripts libc.so.6()(64bit) libdl.so.2()(64bit) libdrm.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply.so.2()(64bit) librt.so.1()(64bit) plymouth-scripts rtld(GNU_HASH) system-logos plymouth-plugin-script (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) librt.so.1()(64bit) plymouth plymouth-libs rtld(GNU_HASH) plymouth-plugin-two-step (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) librt.so.1()(64bit) plymouth plymouth-libs plymouth-plugin-label rtld(GNU_HASH) plymouth-graphics-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) librt.so.1()(64bit) plymouth-core-libs rtld(GNU_HASH) plymouth-theme-spinner (rpmlib, GLIBC filtered): /bin/sh plymouth-plugin-two-step plymouth-scripts plymouth-plugin-space-flares (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) librt.so.1()(64bit) plymouth plymouth-libs plymouth-plugin-label rtld(GNU_HASH) plymouth-plugin-throbgress (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpng15.so.15()(64bit) librt.so.1()(64bit) plymouth plymouth-libs plymouth-plugin-label rtld(GNU_HASH) plymouth-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libply-boot-client.so.2()(64bit) libply-splash-core.so.2()(64bit) libply-splash-graphics.so.2()(64bit) libply.so.2()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) pkgconfig pkgconfig(ply-splash-core) plymouth rtld(GNU_HASH) plymouth-system-theme (rpmlib, GLIBC filtered): plymouth(system-theme) Provides -------- plymouth-theme-charge: plymouth(system-theme) plymouth-theme-charge plymouth-theme-charge(x86-64) plymouth-scripts: plymouth-scripts plymouth-scripts(x86-64) plymouth-core-libs: libply-boot-client.so.2()(64bit) libply-splash-core.so.2()(64bit) libply.so.2()(64bit) plymouth-core-libs plymouth-core-libs(x86-64) plymouth-theme-spinfinity: plymouth-plugin-spinfinity plymouth-theme-spinfinity plymouth-theme-spinfinity(x86-64) plymouth-theme-fade-in: plymouth-plugin-fade-in plymouth-theme-fade-in plymouth-theme-fade-in(x86-64) plymouth-theme-script: plymouth-theme-script plymouth-theme-script(x86-64) plymouth-theme-solar: plymouth-plugin-solar plymouth-theme-solar plymouth-theme-solar(x86-64) plymouth-plugin-label: label.so()(64bit) plymouth-plugin-label plymouth-plugin-label(x86-64) plymouth-plugin-fade-throbber: fade-throbber.so()(64bit) plymouth-plugin-fade-throbber plymouth-plugin-fade-throbber(x86-64) plymouth: config(plymouth) details.so()(64bit) drm.so()(64bit) frame-buffer.so()(64bit) plymouth plymouth(x86-64) text.so()(64bit) plymouth-plugin-script: plymouth-plugin-script plymouth-plugin-script(x86-64) script.so()(64bit) plymouth-plugin-two-step: plymouth-plugin-two-step plymouth-plugin-two-step(x86-64) two-step.so()(64bit) plymouth-graphics-libs: libply-splash-graphics.so.2()(64bit) plymouth-graphics-libs plymouth-graphics-libs(x86-64) plymouth-libs plymouth-theme-spinner: plymouth-theme-spinner plymouth-theme-spinner(x86-64) plymouth-plugin-space-flares: plymouth-plugin-space-flares plymouth-plugin-space-flares(x86-64) space-flares.so()(64bit) plymouth-plugin-throbgress: plymouth-plugin-throbgress plymouth-plugin-throbgress(x86-64) throbgress.so()(64bit) plymouth-devel: pkgconfig(ply-boot-client) pkgconfig(ply-splash-core) pkgconfig(ply-splash-graphics) plymouth-devel plymouth-devel(x86-64) x11.so()(64bit) plymouth-system-theme: plymouth-system-plugin plymouth-system-theme plymouth-system-theme(x86-64) rhgb Unversioned so-files -------------------- plymouth: /usr/lib64/plymouth/details.so plymouth: /usr/lib64/plymouth/renderers/drm.so plymouth: /usr/lib64/plymouth/renderers/frame-buffer.so plymouth: /usr/lib64/plymouth/text.so plymouth-plugin-label: /usr/lib64/plymouth/label.so plymouth-plugin-fade-throbber: /usr/lib64/plymouth/fade-throbber.so plymouth-plugin-throbgress: /usr/lib64/plymouth/throbgress.so plymouth-plugin-space-flares: /usr/lib64/plymouth/space-flares.so plymouth-plugin-two-step: /usr/lib64/plymouth/two-step.so plymouth-plugin-script: /usr/lib64/plymouth/script.so MD5-sum check ------------- http://freedesktop.org/software/plymouth/releases/plymouth-0.8.8.tar.bz2 : CHECKSUM(SHA256) this package : 1bada4e1d3a31a5a99adc2db83f5452d9818839cda51a6e430f044f6281d759b CHECKSUM(SHA256) upstream package : 1bada4e1d3a31a5a99adc2db83f5452d9818839cda51a6e430f044f6281d759b Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn plymouth -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires