Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/pnm2ppa-1.04-25.fc19/pnm2ppa/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 204800 bytes in 19 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: pnm2ppa-1.04-25.fc19.x86_64.rpm pnm2ppa.x86_64: E: incorrect-fsf-address /usr/share/doc/pnm2ppa-1.04/pbm2ppa/LICENSE pnm2ppa.x86_64: E: incorrect-fsf-address /usr/share/doc/pnm2ppa-1.04/LICENSE pnm2ppa.x86_64: W: no-manual-page-for-binary test_ppa pnm2ppa.x86_64: W: no-manual-page-for-binary calibrate_ppa pnm2ppa.x86_64: W: no-manual-page-for-binary detect_ppa pnm2ppa.x86_64: W: no-manual-page-for-binary pbmtpg pnm2ppa.x86_64: W: install-file-in-docs /usr/share/doc/pnm2ppa-1.04/INSTALL pnm2ppa.x86_64: W: install-file-in-docs /usr/share/doc/pnm2ppa-1.04/pbm2ppa/INSTALL 1 packages and 0 specfiles checked; 2 errors, 6 warnings. Requires -------- pnm2ppa (rpmlib, GLIBC filtered): /bin/sh config(pnm2ppa) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) Provides -------- pnm2ppa: config(pnm2ppa) pnm2ppa pnm2ppa(x86-64) MD5-sum check ------------- http://download.sourceforge.net/pnm2ppa/pnm2ppa-1.04.tar.gz : CHECKSUM(SHA256) this package : 2a506ffca82db5b4d1cc59c03d1b5925b7aa60355844cc633a14ec8b237e0446 CHECKSUM(SHA256) upstream package : 2a506ffca82db5b4d1cc59c03d1b5925b7aa60355844cc633a14ec8b237e0446 http://www.httptech.com/ppa/files/ppa-0.8.6.tar.gz : CHECKSUM(SHA256) this package : 823924fc569d80332b287a5581beeea140b980ff247a9d43b41352155747b97a CHECKSUM(SHA256) upstream package : 35722ae6621f1d9270bc53170509d6960b228e3cb71ab55f38329c689f97ea17 diff -r also reports differences Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn pnm2ppa -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires