Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked when required Note: icons in policycoreutils-gui See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - update-desktop-database is invoked when required Note: desktop file(s) in policycoreutils-gui, policycoreutils-restorecond See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in policycoreutils-python , policycoreutils-devel , policycoreutils-sandbox , policycoreutils-newrole , policycoreutils-gui , policycoreutils- restorecond [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 1 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0, Source1 [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define libauditver 2.1.3-4 %define libsepolver 2.1.8-5 %define libsemanagever 2.1.9-1 %define libselinuxver 2.1.12-10 %define sepolgenver 1.1.8 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3686400 bytes in /usr/share 20480 policycoreutils-devel-2.1.13-56.fc19.x86_64.rpm 10240 policycoreutils- sandbox-2.1.13-56.fc19.x86_64.rpm 532480 policycoreutils- gui-2.1.13-56.fc19.x86_64.rpm 30720 policycoreutils- python-2.1.13-56.fc19.x86_64.rpm 3072000 policycoreutils-2.1.13-56.fc19.x86_64.rpm 10240 policycoreutils- restorecond-2.1.13-56.fc19.x86_64.rpm 10240 policycoreutils- newrole-2.1.13-56.fc19.x86_64.rpm Rpmlint ------- Checking: policycoreutils-2.1.13-56.fc19.x86_64.rpm policycoreutils-python-2.1.13-56.fc19.x86_64.rpm policycoreutils-devel-2.1.13-56.fc19.x86_64.rpm policycoreutils-sandbox-2.1.13-56.fc19.x86_64.rpm policycoreutils-newrole-2.1.13-56.fc19.x86_64.rpm policycoreutils-gui-2.1.13-56.fc19.x86_64.rpm policycoreutils-restorecond-2.1.13-56.fc19.x86_64.rpm policycoreutils.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems policycoreutils.x86_64: W: spelling-error %description -l en_US newrole -> new role, new-role, newsroom policycoreutils.x86_64: W: incoherent-version-in-changelog 2.1.12-56 ['2.1.13-56.fc19', '2.1.13-56'] policycoreutils.x86_64: E: incorrect-fsf-address /usr/sbin/fixfiles policycoreutils.x86_64: E: incorrect-fsf-address /usr/share/doc/policycoreutils-2.1.13/COPYING policycoreutils-python.x86_64: E: explicit-lib-dependency libcgroup policycoreutils-python.x86_64: E: description-line-too-long C The policycoreutils-python package contains the management tools use to manage an SELinux environment. policycoreutils-python.x86_64: W: obsolete-not-provided policycoreutils policycoreutils-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/policycoreutils/default_encoding_utf8.so default_encoding_utf8.so()(64bit) policycoreutils-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/sepolicy/_policy.so _policy.so()(64bit) policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/__init__.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/__init__.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/communicate.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/communicate.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/boolean.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/etc_rw.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/var_spool.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/matching.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/policycoreutils/__init__.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/network.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/defaults.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/unit_file.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/access.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/var_log.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/script.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/interfaces.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/var_lib.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/module.py policycoreutils-python.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/setsebool-bash-completion.sh policycoreutils-python.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/sepolicy-bash-completion.sh policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/user.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/sepolgeni18n.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/executable.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/yacc.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/refpolicy.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/network.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/network.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/tmp.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/interface.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/interface.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/output.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/generate.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/generate.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/seobject.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/classperms.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/rw.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/objectmodel.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/sbin/semanage policycoreutils-python.x86_64: W: manual-page-warning /usr/share/man/man8/semanage.8.gz 192: warning: macro `i' not defined policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/var_cache.py policycoreutils-python.x86_64: W: manual-page-warning /usr/share/man/man8/sepolicy-generate.8.gz 104: warning: macro `/' not defined policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/bin/chcat policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/lex.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/manpage.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/manpage.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/booleans.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/booleans.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/policygen.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/util.py policycoreutils-python.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/semanage-bash-completion.sh policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/var_run.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/refparser.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/templates/semodule.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolgen/audit.py policycoreutils-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/sepolicy/transition.py 0644L /usr/bin/python policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/sepolicy/transition.py policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/bin/sandbox policycoreutils-python.x86_64: E: incorrect-fsf-address /usr/bin/sepolicy policycoreutils-devel.x86_64: E: description-line-too-long C The policycoreutils-devel package contains the management tools use to develop policy in an SELinux environment. policycoreutils-devel.x86_64: E: incorrect-fsf-address /usr/bin/sepolgen-ifgen policycoreutils-devel.x86_64: E: incorrect-fsf-address /usr/bin/audit2allow policycoreutils-devel.x86_64: W: no-manual-page-for-binary sepolgen-ifgen-attr-helper policycoreutils-devel.x86_64: W: no-manual-page-for-binary sepolgen policycoreutils-devel.x86_64: W: no-manual-page-for-binary audit2why policycoreutils-devel.x86_64: W: no-manual-page-for-binary sepolgen-ifgen policycoreutils-sandbox.x86_64: E: description-line-too-long C The policycoreutils-sandbox package contains the scripts to create graphical sandboxes policycoreutils-sandbox.x86_64: E: setuid-binary /usr/sbin/seunshare root 04755L policycoreutils-sandbox.x86_64: E: non-standard-executable-perm /usr/sbin/seunshare 04755L policycoreutils-gui.x86_64: E: devel-dependency policycoreutils-devel policycoreutils-gui.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure policycoreutils-gui.x86_64: W: spelling-error %description -l en_US selinux -> Linux policycoreutils-gui.x86_64: W: no-documentation policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/portsPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/domainsPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/statusPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/usersPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/loginsPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/booleansPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/system-config-selinux.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/semanagePage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/html_util.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/fcontextPage.py policycoreutils-gui.x86_64: W: no-dependency-on usermode policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/polgengui.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/modulesPage.py policycoreutils-gui.x86_64: E: incorrect-fsf-address /usr/share/system-config-selinux/mappingsPage.py policycoreutils-gui.x86_64: W: no-manual-page-for-binary selinux-polgengui policycoreutils-gui.x86_64: W: no-manual-page-for-binary system-config-selinux policycoreutils-restorecond.x86_64: W: only-non-binary-in-usr-lib policycoreutils-restorecond.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/restorecond.desktop policycoreutils-restorecond.x86_64: E: non-readable /usr/share/dbus-1/services/org.selinux.Restorecond.service 0600L 7 packages and 0 specfiles checked; 78 errors, 23 warnings. Requires -------- policycoreutils-sandbox (rpmlib, GLIBC filtered): /bin/bash /sbin/chkconfig /usr/bin/python /usr/bin/rsync /usr/bin/xmodmap config(policycoreutils-sandbox) libc.so.6()(64bit) libcap-ng.so.0()(64bit) libcgroup.so.1()(64bit) libcgroup.so.1(CGROUP_0.32)(64bit) libcgroup.so.1(CGROUP_0.34)(64bit) libselinux.so.1()(64bit) matchbox-window-manager policycoreutils-python rtld(GNU_HASH) xorg-x11-server-Xephyr policycoreutils-newrole (rpmlib, GLIBC filtered): config(policycoreutils-newrole) libaudit.so.1()(64bit) libc.so.6()(64bit) libcap-ng.so.0()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpam_misc.so.0()(64bit) libpam_misc.so.0(LIBPAM_MISC_1.0)(64bit) libselinux.so.1()(64bit) policycoreutils rtld(GNU_HASH) policycoreutils-python (rpmlib, GLIBC filtered): /usr/bin/python audit-libs-python libapol.so.4()(64bit) libapol.so.4(VERS_4.0)(64bit) libc.so.6()(64bit) libcgroup libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libqpol.so.1()(64bit) libqpol.so.1(VERS_1.2)(64bit) libqpol.so.1(VERS_1.4)(64bit) libselinux-python libsemanage-python policycoreutils python python(abi) python-IPy rtld(GNU_HASH) policycoreutils-restorecond (rpmlib, GLIBC filtered): /bin/sh config(policycoreutils-restorecond) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libglib-2.0.so.0()(64bit) libselinux.so.1()(64bit) rtld(GNU_HASH) policycoreutils (rpmlib, GLIBC filtered): /bin/awk /bin/bash /bin/egrep /bin/mount /bin/sed /bin/sh /usr/bin/diff config(policycoreutils) coreutils libaudit.so.1()(64bit) libc.so.6()(64bit) libselinux-utils libselinux.so.1()(64bit) libsemanage.so.1()(64bit) libsemanage.so.1(LIBSEMANAGE_1.0)(64bit) libsepol libsepol.so.1()(64bit) rpm rtld(GNU_HASH) systemd-sysv systemd-units policycoreutils-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/make /usr/bin/python checkpolicy libc.so.6()(64bit) policycoreutils-python rtld(GNU_HASH) selinux-policy-devel selinux-policy-doc policycoreutils-gui (rpmlib, GLIBC filtered): /usr/bin/python config(policycoreutils-gui) gnome-python2-canvas gnome-python2-gnome policycoreutils-devel pygtk2 pygtk2-libglade python usermode-gtk Provides -------- policycoreutils-sandbox: config(policycoreutils-sandbox) policycoreutils-sandbox policycoreutils-sandbox(x86-64) policycoreutils-newrole: config(policycoreutils-newrole) policycoreutils-newrole policycoreutils-newrole(x86-64) policycoreutils-python: _policy.so()(64bit) default_encoding_utf8.so()(64bit) policycoreutils-python policycoreutils-python(x86-64) policycoreutils-restorecond: config(policycoreutils-restorecond) policycoreutils-restorecond policycoreutils-restorecond(x86-64) policycoreutils: /sbin/fixfiles /sbin/restorecon config(policycoreutils) policycoreutils policycoreutils(x86-64) policycoreutils-devel: policycoreutils-devel policycoreutils-devel(x86-64) policycoreutils-gui: config(policycoreutils-gui) policycoreutils-gui policycoreutils-gui(x86-64) Unversioned so-files -------------------- policycoreutils-python: /usr/lib64/python2.7/site-packages/policycoreutils/default_encoding_utf8.so policycoreutils-python: /usr/lib64/python2.7/site-packages/sepolicy/_policy.so Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn policycoreutils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires