Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Large documentation must go in a -doc subpackage. Note: Documentation size is 1187840 bytes in 65 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in postfix- sysvinit , postfix-perl-scripts [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define postfix_uid 89 %define postfix_user postfix %define postfix_gid 89 %define postfix_group postfix %define maildrop_group postdrop %define maildrop_gid 90 %define postfix_config_dir %{_sysconfdir}/postfix %define postfix_daemon_dir %{_libexecdir}/postfix %define postfix_command_dir %{_sbindir} %define postfix_queue_dir %{_var}/spool/postfix %define postfix_data_dir %{_var}/lib/postfix %define postfix_doc_dir %{_docdir}/%{name}-%{version} %define postfix_sample_dir %{postfix_doc_dir}/samples %define postfix_readme_dir %{postfix_doc_dir}/README_FILES %define pflogsumm_ver 1.1.3 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1576960 bytes in /usr/share 1525760 postfix-2.9.5-2.fc19.x86_64.rpm 51200 postfix-perl- scripts-2.9.5-2.fc19.x86_64.rpm Rpmlint ------- Checking: postfix-2.9.5-2.fc19.x86_64.rpm postfix-sysvinit-2.9.5-2.fc19.noarch.rpm postfix-perl-scripts-2.9.5-2.fc19.x86_64.rpm postfix.x86_64: W: name-repeated-in-summary C Postfix postfix.x86_64: W: only-non-binary-in-usr-lib postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/trace 0700L postfix.x86_64: E: non-standard-dir-perm /var/lib/postfix 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/maildrop 0730L postfix.x86_64: E: setgid-binary /usr/sbin/postqueue postdrop 02755L postfix.x86_64: E: non-standard-executable-perm /usr/sbin/postqueue 02755L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/defer 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/saved 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/incoming 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/corrupt 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/deferred 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/public 0710L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/flush 0700L postfix.x86_64: E: setgid-binary /usr/sbin/postdrop postdrop 02755L postfix.x86_64: E: non-standard-executable-perm /usr/sbin/postdrop 02755L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/private 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/bounce 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/active 0700L postfix.x86_64: E: non-standard-dir-perm /var/spool/postfix/hold 0700L postfix.x86_64: W: no-manual-page-for-binary rmail postfix.x86_64: W: no-manual-page-for-binary rmail.postfix postfix.x86_64: W: install-file-in-docs /usr/share/doc/postfix-2.9.5/README_FILES/INSTALL postfix.x86_64: W: dangerous-command-in-%post mv postfix-sysvinit.noarch: W: spelling-error Summary(en_US) SysV -> Sysop postfix-sysvinit.noarch: W: spelling-error Summary(en_US) initscript -> inscription, postscript postfix-sysvinit.noarch: W: spelling-error %description -l en_US initscript -> inscription, postscript postfix-sysvinit.noarch: W: no-documentation postfix-sysvinit.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/postfix postfix-sysvinit.noarch: W: incoherent-subsys /etc/rc.d/init.d/postfix $prog postfix-perl-scripts.x86_64: W: spelling-error %description -l en_US Pflogsumm postfix-perl-scripts.x86_64: W: spelling-error %description -l en_US summarizer -> summarize, summarizes, summarized postfix-perl-scripts.x86_64: W: obsolete-not-provided postfix 3 packages and 0 specfiles checked; 18 errors, 15 warnings. Requires -------- postfix (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/sbin/alternatives /usr/sbin/groupadd /usr/sbin/useradd config(postfix) libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(OPENSSL_1.0.1)(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdb-5.3.so()(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_16)(64bit) libnsl.so.1()(64bit) libpcre.so.1()(64bit) libresolv.so.2()(64bit) libsasl2.so.2()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) rtld(GNU_HASH) systemd-sysv systemd-units postfix-sysvinit (rpmlib, GLIBC filtered): /bin/bash /bin/sh chkconfig postfix postfix-perl-scripts (rpmlib, GLIBC filtered): /usr/bin/perl perl(Date::Calc) perl(File::Find) perl(Getopt::Long) perl(Getopt::Std) perl(IO::File) perl(locale) perl(strict) perl(vars) postfix Provides -------- postfix: MTA config(postfix) postfix postfix(x86-64) server(smtp) smtpd smtpdaemon postfix-sysvinit: postfix-sysvinit postfix-perl-scripts: postfix-perl-scripts postfix-perl-scripts(x86-64) postfix-pflogsumm MD5-sum check ------------- http://jimsun.linxnet.com/downloads/pflogsumm-1.1.3.tar.gz : CHECKSUM(SHA256) this package : c4df11c2eaef313025e326114d9dea4b0f0f9b978880a29d2ecf075774aa7142 CHECKSUM(SHA256) upstream package : c4df11c2eaef313025e326114d9dea4b0f0f9b978880a29d2ecf075774aa7142 ftp://ftp.porcupine.org/mirrors/postfix-release/official/postfix-2.9.5.tar.gz : CHECKSUM(SHA256) this package : 590381cc0705a6d3fd2279760e79aff625adab6000cb895cf5336ae6a11ee6e4 CHECKSUM(SHA256) upstream package : 590381cc0705a6d3fd2279760e79aff625adab6000cb895cf5336ae6a11ee6e4 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn postfix -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires