Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Package does not contain any libtool archives (.la) Note: proj-static : /usr/lib64/libproj.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in proj-devel , proj-static , proj-nad , proj-epsg [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 92160 bytes in 7 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: The placement of pkgconfig(.pc) files are correct. Note: proj-nad : /usr/lib64/pkgconfig/proj.pc [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5232640 bytes in /usr/share 10240 proj-devel-4.8.0-3.fc19.x86_64.rpm 4464640 proj- nad-4.8.0-3.fc19.x86_64.rpm 665600 proj-epsg-4.8.0-3.fc19.x86_64.rpm 92160 proj-4.8.0-3.fc19.x86_64.rpm Rpmlint ------- Checking: proj-4.8.0-3.fc19.x86_64.rpm proj-devel-4.8.0-3.fc19.x86_64.rpm proj-static-4.8.0-3.fc19.x86_64.rpm proj-nad-4.8.0-3.fc19.x86_64.rpm proj-epsg-4.8.0-3.fc19.x86_64.rpm proj.x86_64: W: spelling-error %description -l en_US cartesian -> Cartesian proj.x86_64: W: spelling-error %description -l en_US selectable -> delectable, electable, s electable proj.x86_64: W: invalid-url URL: http://proj.osgeo.org timed out proj.x86_64: W: shared-lib-calls-exit /usr/lib64/libproj.so.0.7.0 exit@GLIBC_2.2.5 proj.x86_64: W: manual-page-warning /usr/share/man/man1/geod.1.gz 37: warning: can't find special character ```' proj.x86_64: W: manual-page-warning /usr/share/man/man1/geod.1.gz 37: warning: can't find special character `''' proj.x86_64: W: no-manual-page-for-binary nad2bin proj.x86_64: W: no-manual-page-for-binary invproj proj.x86_64: W: no-manual-page-for-binary invgeod proj-devel.x86_64: W: spelling-error %description -l en_US libproj -> libretto proj-devel.x86_64: W: invalid-url URL: http://proj.osgeo.org timed out proj-static.x86_64: W: spelling-error %description -l en_US libproj -> libretto proj-static.x86_64: W: no-documentation proj-nad.x86_64: W: invalid-url URL: http://proj.osgeo.org timed out proj-nad.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/proj.pc proj-nad.x86_64: W: spurious-executable-perm /usr/lib64/pkgconfig/proj.pc proj-epsg.x86_64: W: spelling-error Summary(en_US) dataset -> data set, data-set, database proj-epsg.x86_64: W: spelling-error %description -l en_US dataset -> data set, data-set, database proj-epsg.x86_64: W: invalid-url URL: http://proj.osgeo.org timed out 5 packages and 0 specfiles checked; 0 errors, 19 warnings. Requires -------- proj-nad (rpmlib, GLIBC filtered): /bin/bash /usr/bin/pkg-config proj proj-devel (rpmlib, GLIBC filtered): libproj.so.0()(64bit) proj proj-static (rpmlib, GLIBC filtered): proj-epsg (rpmlib, GLIBC filtered): proj proj (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libm.so.6()(64bit) libproj.so.0()(64bit) rtld(GNU_HASH) Provides -------- proj-nad: pkgconfig(proj) proj-nad proj-nad(x86-64) proj-devel: proj-devel proj-devel(x86-64) proj-static: proj-static proj-static(x86-64) proj-epsg: proj-epsg proj-epsg(x86-64) proj: libproj.so.0()(64bit) proj proj(x86-64) MD5-sum check ------------- http://download.osgeo.org/proj/proj-4.8.0.tar.gz : CHECKSUM(SHA256) this package : 2db2dbf0fece8d9880679154e0d6d1ce7c694dd8e08b4d091028093d87a9d1b5 CHECKSUM(SHA256) upstream package : 2db2dbf0fece8d9880679154e0d6d1ce7c694dd8e08b4d091028093d87a9d1b5 http://download.osgeo.org/proj/proj-datumgrid-1.5.zip : CHECKSUM(SHA256) this package : 723c4017d95d7a8abdf3bda4e18d3c15d79b00f9326d453da5fdf13f96c287db CHECKSUM(SHA256) upstream package : 723c4017d95d7a8abdf3bda4e18d3c15d79b00f9326d453da5fdf13f96c287db Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn proj -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires