Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in protobuf- compiler, protobuf-devel, protobuf-static, protobuf-lite, protobuf-lite- devel, protobuf-lite-static, protobuf-python, protobuf-vim, protobuf-emacs, protobuf-emacs-el, protobuf-java See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: protobuf-emacs-el (description) [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in protobuf- compiler , protobuf-devel , protobuf-static , protobuf-lite , protobuf- lite-devel , protobuf-lite-static , protobuf-python , protobuf-vim , protobuf-emacs , protobuf-emacs-el , protobuf-java , protobuf-javadoc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 112640 bytes in 17 files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()") [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 11294720 bytes in /usr/share 20480 protobuf-compiler-2.4.1-9.fc19.x86_64.rpm 10639360 protobuf- javadoc-2.4.1-9.fc19.x86_64.rpm 20480 protobuf-emacs- el-2.4.1-9.fc19.x86_64.rpm 40960 protobuf-2.4.1-9.fc19.x86_64.rpm 20480 protobuf-python-2.4.1-9.fc19.x86_64.rpm 51200 protobuf- emacs-2.4.1-9.fc19.x86_64.rpm 20480 protobuf- devel-2.4.1-9.fc19.x86_64.rpm 10240 protobuf-vim-2.4.1-9.fc19.x86_64.rpm 471040 protobuf-java-2.4.1-9.fc19.x86_64.rpm Rpmlint ------- Checking: protobuf-2.4.1-9.fc19.x86_64.rpm protobuf-compiler-2.4.1-9.fc19.x86_64.rpm protobuf-devel-2.4.1-9.fc19.x86_64.rpm protobuf-static-2.4.1-9.fc19.x86_64.rpm protobuf-lite-2.4.1-9.fc19.x86_64.rpm protobuf-lite-devel-2.4.1-9.fc19.x86_64.rpm protobuf-lite-static-2.4.1-9.fc19.x86_64.rpm protobuf-python-2.4.1-9.fc19.x86_64.rpm protobuf-vim-2.4.1-9.fc19.x86_64.rpm protobuf-emacs-2.4.1-9.fc19.x86_64.rpm protobuf-emacs-el-2.4.1-9.fc19.x86_64.rpm protobuf-java-2.4.1-9.fc19.x86_64.rpm protobuf-javadoc-2.4.1-9.fc19.x86_64.rpm protobuf-compiler.x86_64: W: no-manual-page-for-binary protoc protobuf-static.x86_64: W: no-documentation protobuf-lite.x86_64: W: spelling-error %description -l en_US libprotobuf -> prototypical protobuf-lite.x86_64: W: no-documentation protobuf-lite-devel.x86_64: W: spelling-error %description -l en_US libprotobuf -> prototypical protobuf-lite-devel.x86_64: W: no-documentation protobuf-lite-static.x86_64: W: spelling-error %description -l en_US libprotobuf -> prototypical protobuf-lite-static.x86_64: W: no-documentation protobuf-vim.x86_64: W: no-documentation protobuf-emacs.x86_64: W: no-documentation protobuf-emacs-el.x86_64: W: spelling-error Summary(en_US) Elisp -> Lisp, Elise, Elisa protobuf-emacs-el.x86_64: W: unexpanded-macro %description -l C %{pkgname} protobuf-emacs-el.x86_64: W: unexpanded-macro %description -l C %{pkgname} protobuf-emacs-el.x86_64: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Ellis protobuf-emacs-el.x86_64: W: spelling-error %description -l en_US pkgname -> pkg name, pkg-name, nickname protobuf-emacs-el.x86_64: W: no-documentation protobuf-java.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment protobuf-java.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment protobuf-javadoc.x86_64: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 13 packages and 0 specfiles checked; 0 errors, 19 warnings. Requires -------- protobuf-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libprotobuf.so.7()(64bit) libprotoc.so.7()(64bit) pkgconfig protobuf protobuf-compiler protobuf-lite-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libprotobuf-lite.so.7()(64bit) protobuf-devel protobuf-lite protobuf (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) protobuf-python (rpmlib, GLIBC filtered): python(abi) protobuf-javadoc (rpmlib, GLIBC filtered): jpackage-utils protobuf-java protobuf-emacs (rpmlib, GLIBC filtered): emacs protobuf-lite-static (rpmlib, GLIBC filtered): protobuf-devel protobuf-java (rpmlib, GLIBC filtered): java jpackage-utils protobuf-vim (rpmlib, GLIBC filtered): vim-enhanced protobuf-lite (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) protobuf-emacs-el (rpmlib, GLIBC filtered): protobuf-emacs protobuf-static (rpmlib, GLIBC filtered): protobuf protobuf-compiler (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libprotobuf.so.7()(64bit) libprotoc.so.7()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) protobuf rtld(GNU_HASH) Provides -------- protobuf-devel: pkgconfig(protobuf) protobuf-devel protobuf-devel(x86-64) protobuf-lite-devel: pkgconfig(protobuf-lite) protobuf-lite-devel protobuf-lite-devel(x86-64) protobuf: libprotobuf.so.7()(64bit) protobuf protobuf(x86-64) protobuf-python: protobuf-python protobuf-python(x86-64) protobuf-javadoc: protobuf-javadoc protobuf-javadoc(x86-64) protobuf-emacs: protobuf-emacs protobuf-emacs(x86-64) protobuf-lite-static: protobuf-lite-static protobuf-lite-static(x86-64) protobuf-java: mvn(com.google.protobuf:protobuf-java) protobuf-java protobuf-java(x86-64) protobuf-vim: protobuf-vim protobuf-vim(x86-64) protobuf-lite: libprotobuf-lite.so.7()(64bit) protobuf-lite protobuf-lite(x86-64) protobuf-emacs-el: protobuf-emacs-el protobuf-emacs-el(x86-64) protobuf-static: protobuf-static protobuf-static(x86-64) protobuf-compiler: libprotoc.so.7()(64bit) protobuf-compiler protobuf-compiler(x86-64) MD5-sum check ------------- http://protobuf.googlecode.com/files/protobuf-2.4.1.tar.bz2 : CHECKSUM(SHA256) this package : cf8452347330834bbf9c65c2e68b5562ba10c95fa40d4f7ec0d2cb332674b0bf CHECKSUM(SHA256) upstream package : cf8452347330834bbf9c65c2e68b5562ba10c95fa40d4f7ec0d2cb332674b0bf Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn protobuf -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires