Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - No %config files under /usr. Note: %config(noreplace) /usr/share/publican/default.db See: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files - update-desktop-database is invoked when required Note: desktop file(s) in publican-doc See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Large documentation must go in a -doc subpackage. Note: Documentation size is 1228800 bytes in 117 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in publican- doc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define RHEL6 %([[ %{?dist}x == .el6[a-z]* ]] && echo 1 || echo 0) %define OTHER 1 %define OTHER 0 %define my_vendor %(test %{OTHER} == 1 && echo "fedora" || echo "redhat") %define TESTS 0 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: publican-2.8-4.fc18.noarch.rpm publican-doc-2.8-4.fc18.noarch.rpm publican.noarch: E: explicit-lib-dependency liberation-mono-fonts publican.noarch: E: explicit-lib-dependency liberation-sans-fonts publican.noarch: E: explicit-lib-dependency liberation-serif-fonts publican.noarch: W: obsolete-not-provided perl-Publican-WebSite publican.noarch: W: obsolete-not-provided publican-WebSite-obsoletes publican.noarch: W: obsolete-not-provided Publican publican.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/share/publican/default.db publican-doc.noarch: W: obsolete-not-provided Publican-doc 2 packages and 0 specfiles checked; 3 errors, 5 warnings. Requires -------- publican-doc (rpmlib, GLIBC filtered): xdg-utils publican (rpmlib, GLIBC filtered): /usr/bin/perl baekmuk-ttf-batang-fonts batik cjkuni-uming-fonts config(publican) cvs docbook-style-xsl fop gettext ipa-gothic-fonts ipa-pgothic-fonts liberation-mono-fonts liberation-sans-fonts liberation-serif-fonts lklug-fonts perl perl(:MODULE_COMPAT_5.16.0) perl(Archive::Tar) perl(Archive::Zip) perl(Carp) perl(Config::Simple) perl(Cwd) perl(DBD::SQLite) perl(DBI) perl(DateTime) perl(DateTime::Format::DateParse) perl(Encode) perl(File::Basename) perl(File::Copy::Recursive) perl(File::Find) perl(File::Find::Rule) perl(File::Path) perl(File::Which) perl(File::pushd) perl(Getopt::Long) perl(HTML::FormatText) perl(HTML::TreeBuilder) perl(I18N::LangTags::List) perl(IO::String) perl(Image::Magick) perl(Image::Size) perl(List::Util) perl(Locale::Language) perl(Locale::Maketext::Gettext) perl(Locale::PO) perl(Makefile::Parser) perl(POSIX) perl(Pod::Usage) perl(Publican) perl(Publican::Builder) perl(Publican::CreateBook) perl(Publican::CreateBrand) perl(Publican::Localise) perl(Publican::Translate) perl(Publican::TreeView) perl(Publican::WebSite) perl(Publican::XmlClean) perl(Syntax::Highlight::Engine::Kate) perl(Template) perl(Template::Constants) perl(Term::ANSIColor) perl(Text::Wrap) perl(Time::localtime) perl(Unicode::Collate) perl(XML::LibXML) perl(XML::LibXSLT) perl(XML::Simple) perl(XML::TreeBuilder) perl(base) perl(strict) perl(utf8) perl(vars) perl(warnings) perl-Template-Toolkit rpm-build Provides -------- publican-doc: publican-doc publican: config(publican) perl(Publican) perl(Publican::Builder) perl(Publican::CreateBook) perl(Publican::CreateBrand) perl(Publican::Localise) perl(Publican::Localise::C) perl(Publican::Localise::as) perl(Publican::Localise::bg) perl(Publican::Localise::bn_in) perl(Publican::Localise::bs) perl(Publican::Localise::ca) perl(Publican::Localise::cs) perl(Publican::Localise::da) perl(Publican::Localise::de) perl(Publican::Localise::el) perl(Publican::Localise::en) perl(Publican::Localise::es) perl(Publican::Localise::fi) perl(Publican::Localise::fr) perl(Publican::Localise::gu) perl(Publican::Localise::he) perl(Publican::Localise::hi) perl(Publican::Localise::hr) perl(Publican::Localise::hu) perl(Publican::Localise::id) perl(Publican::Localise::it) perl(Publican::Localise::ja) perl(Publican::Localise::kn) perl(Publican::Localise::ko) perl(Publican::Localise::lv) perl(Publican::Localise::ml) perl(Publican::Localise::mr) perl(Publican::Localise::ms) perl(Publican::Localise::nb) perl(Publican::Localise::nl) perl(Publican::Localise::or) perl(Publican::Localise::pa) perl(Publican::Localise::pl) perl(Publican::Localise::pt) perl(Publican::Localise::pt_br) perl(Publican::Localise::ru) perl(Publican::Localise::sk) perl(Publican::Localise::sr) perl(Publican::Localise::sr_latn) perl(Publican::Localise::sv) perl(Publican::Localise::ta) perl(Publican::Localise::te) perl(Publican::Localise::uk) perl(Publican::Localise::zh_cn) perl(Publican::Localise::zh_tw) perl(Publican::Translate) perl(Publican::TreeView) perl(Publican::WebSite) perl(Publican::XmlClean) publican MD5-sum check ------------- https://fedorahosted.org/released/publican/Publican-2.8.tar.gz : CHECKSUM(SHA256) this package : 4cebf54937a7f0eae58fcf68e77d0aed62bde734641996df6b91d502b0ea9d07 CHECKSUM(SHA256) upstream package : 4cebf54937a7f0eae58fcf68e77d0aed62bde734641996df6b91d502b0ea9d07 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn publican -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires