Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python-matplotlib : /usr/share/doc/python- matplotlib-1.2.0/CXX/WrapPython.h python3-matplotlib : /usr/share/doc/python3-matplotlib-1.2.0/CXX/WrapPython.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Large documentation must go in a -doc subpackage. Note: Documentation size is 30228480 bytes in 2281 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-matplotlib , python3-matplotlib-tk [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 32532480 bytes in /usr/share 30822400 python-matplotlib-doc-1.2.0-8.fc19.x86_64.rpm 860160 python- matplotlib-1.2.0-8.fc19.x86_64.rpm 849920 python3-matplotlib-1.2.0-8.fc19.x86_64.rpm Rpmlint ------- Checking: python-matplotlib-1.2.0-8.fc19.x86_64.rpm python-matplotlib-qt4-1.2.0-8.fc19.x86_64.rpm python-matplotlib-tk-1.2.0-8.fc19.x86_64.rpm python-matplotlib-wx-1.2.0-8.fc19.x86_64.rpm python-matplotlib-doc-1.2.0-8.fc19.x86_64.rpm python3-matplotlib-1.2.0-8.fc19.x86_64.rpm python3-matplotlib-qt4-1.2.0-8.fc19.x86_64.rpm python3-matplotlib-tk-1.2.0-8.fc19.x86_64.rpm python-matplotlib.x86_64: W: spelling-error %description -l en_US hardcopy -> hard copy, hard-copy, hardcore python-matplotlib.x86_64: W: spelling-error %description -l en_US ipython -> python, i python, Python python-matplotlib.x86_64: W: spelling-error %description -l en_US toolkits -> toolkit, tool kits, tool-kits python-matplotlib.x86_64: W: spelling-error %description -l en_US errorcharts -> error charts, error-charts, charterers python-matplotlib.x86_64: W: spelling-error %description -l en_US scatterplots -> scatter plots, scatter-plots, scatterbrains python-matplotlib.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/mpl_toolkits/mplot3d/axes3d.py 0644L /usr/bin/python python-matplotlib.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/mpl_toolkits/mplot3d/proj3d.py 0644L /usr/bin/python python-matplotlib.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/matplotlib/sankey.py 0644L /usr/bin/env python-matplotlib.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/mpl_toolkits/mplot3d/art3d.py 0644L /usr/bin/python python-matplotlib.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/mpl_toolkits/mplot3d/axis3d.py 0644L /usr/bin/python python-matplotlib.x86_64: W: install-file-in-docs /usr/share/doc/python-matplotlib-1.2.0/INSTALL python-matplotlib-qt4.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end python-matplotlib-qt4.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end python-matplotlib-qt4.x86_64: W: no-documentation python-matplotlib-tk.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end python-matplotlib-tk.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end python-matplotlib-tk.x86_64: W: no-documentation python-matplotlib-wx.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end python-matplotlib-wx.x86_64: W: summary-not-capitalized C wxPython backend for python-matplotlib python-matplotlib-wx.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end python-matplotlib-wx.x86_64: W: no-documentation python-matplotlib-doc.x86_64: W: doc-file-dependency /usr/share/doc/python-matplotlib-doc-1.2.0/pyplots/make.py /usr/bin/env python3-matplotlib.x86_64: W: spelling-error %description -l en_US hardcopy -> hard copy, hard-copy, hardcore python3-matplotlib.x86_64: W: spelling-error %description -l en_US ipython -> python, i python, Python python3-matplotlib.x86_64: W: spelling-error %description -l en_US toolkits -> toolkit, tool kits, tool-kits python3-matplotlib.x86_64: W: spelling-error %description -l en_US errorcharts -> error charts, error-charts, charterers python3-matplotlib.x86_64: W: spelling-error %description -l en_US scatterplots -> scatter plots, scatter-plots, scatterbrains python3-matplotlib.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/mpl_toolkits/mplot3d/proj3d.py 0644L /usr/bin/python python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/backend_tkagg.cpython-33.pyc python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/tkagg.cpython-33.pyc python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/tkagg.cpython-33.pyo python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/backend_qt4agg.cpython-33.pyc python3-matplotlib.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/mpl_toolkits/mplot3d/art3d.py 0644L /usr/bin/python python3-matplotlib.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/mpl_toolkits/mplot3d/axes3d.py 0644L /usr/bin/python python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/backend_qt4agg.cpython-33.pyo python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/backend_qt4.cpython-33.pyc python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/backend_qt4.cpython-33.pyo python3-matplotlib.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/mpl_toolkits/mplot3d/axis3d.py 0644L /usr/bin/python python3-matplotlib.x86_64: W: python-bytecode-without-source /usr/lib64/python3.3/site-packages/matplotlib/backends/__pycache__/backend_tkagg.cpython-33.pyo python3-matplotlib.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/matplotlib/sankey.py 0644L /usr/bin/env python3-matplotlib.x86_64: W: install-file-in-docs /usr/share/doc/python3-matplotlib-1.2.0/INSTALL python3-matplotlib-qt4.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end python3-matplotlib-qt4.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end python3-matplotlib-qt4.x86_64: W: no-documentation python3-matplotlib-tk.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end python3-matplotlib-tk.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end python3-matplotlib-tk.x86_64: W: no-documentation 8 packages and 0 specfiles checked; 10 errors, 37 warnings. Requires -------- python3-matplotlib-tk (rpmlib, GLIBC filtered): libagg.so.2()(64bit) libc.so.6()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython3.3m.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcl8.5.so()(64bit) libtk8.5.so()(64bit) libz.so.1()(64bit) python(abi) python3-matplotlib(x86-64) python3-tkinter rtld(GNU_HASH) python-matplotlib (rpmlib, GLIBC filtered): /usr/bin/env dejavu-sans-fonts dvipng libagg.so.2()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libz.so.1()(64bit) numpy pycairo pygtk2 pyparsing python(abi) python-dateutil pytz rtld(GNU_HASH) python-matplotlib-doc (rpmlib, GLIBC filtered): /usr/bin/env python-matplotlib(x86-64) python-matplotlib-tk (rpmlib, GLIBC filtered): libagg.so.2()(64bit) libc.so.6()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcl8.5.so()(64bit) libtk8.5.so()(64bit) libz.so.1()(64bit) python(abi) python-matplotlib(x86-64) rtld(GNU_HASH) tkinter python-matplotlib-wx (rpmlib, GLIBC filtered): python(abi) python-matplotlib(x86-64) wxPython python3-matplotlib-qt4 (rpmlib, GLIBC filtered): python(abi) python-matplotlib(x86-64) python3-PyQt4 python3-matplotlib (rpmlib, GLIBC filtered): /usr/bin/env libagg.so.2()(64bit) libc.so.6()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) libpython3.3m.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libz.so.1()(64bit) python(abi) python3-cairo python3-dateutil python3-numpy python3-pyparsing python3-pytz rtld(GNU_HASH) python-matplotlib-qt4 (rpmlib, GLIBC filtered): PyQt4 python(abi) python-matplotlib(x86-64) Provides -------- python3-matplotlib-tk: python3-matplotlib-tk python3-matplotlib-tk(x86-64) python-matplotlib: python-matplotlib python-matplotlib(x86-64) python-matplotlib-doc: python-matplotlib-doc python-matplotlib-doc(x86-64) python-matplotlib-tk: python-matplotlib-tk python-matplotlib-tk(x86-64) python-matplotlib-wx: python-matplotlib-wx python-matplotlib-wx(x86-64) python3-matplotlib-qt4: python3-matplotlib-qt4 python3-matplotlib-qt4(x86-64) python3-matplotlib: python3-matplotlib python3-matplotlib(x86-64) python-matplotlib-qt4: python-matplotlib-qt4 python-matplotlib-qt4(x86-64) Unversioned so-files -------------------- python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/_cntr.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/_delaunay.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/_image.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/_path.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/_png.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/_tri.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/backends/_backend_agg.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/backends/_backend_gdk.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/backends/_gtkagg.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/ft2font.so python-matplotlib: /usr/lib64/python2.7/site-packages/matplotlib/ttconv.so python-matplotlib-tk: /usr/lib64/python2.7/site-packages/matplotlib/backends/_tkagg.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/_cntr.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/_delaunay.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/_image.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/_path.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/_png.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/_tri.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/backends/_backend_agg.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/ft2font.cpython-33m.so python3-matplotlib: /usr/lib64/python3.3/site-packages/matplotlib/ttconv.cpython-33m.so python3-matplotlib-tk: /usr/lib64/python3.3/site-packages/matplotlib/backends/_tkagg.cpython-33m.so Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn python-matplotlib -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires