Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- slip-dbus , python-slip-gtk [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 19 files. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python-slip-0.2.24-1.fc19.noarch.rpm python-slip-dbus-0.2.24-1.fc19.noarch.rpm python-slip-gtk-0.2.24-1.fc19.noarch.rpm python-slip.noarch: W: invalid-url URL: http://fedorahosted.org/python-slip The read operation timed out python-slip.noarch: E: incorrect-fsf-address /usr/share/doc/python-slip-0.2.24/COPYING python-slip.noarch: E: zero-length /usr/share/doc/python-slip-0.2.24/dbus/example/import_marker.py python-slip-dbus.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/slip/dbus/polkit.py python-slip-dbus.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/slip/dbus/service.py python-slip-dbus.noarch: E: zero-length /usr/share/doc/python-slip-dbus-0.2.24/example/import_marker.py python-slip-dbus.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/slip/dbus/bus.py python-slip-dbus.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/slip/dbus/constants.py python-slip-dbus.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/slip/dbus/proxies.py python-slip-dbus.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/slip/dbus/mainloop.py python-slip-gtk.noarch: W: spelling-error %description -l en_US autowrap -> auto wrap, auto-wrap, autograph python-slip-gtk.noarch: W: spelling-error %description -l en_US resizing -> residing, re sizing, re-sizing python-slip-gtk.noarch: W: no-documentation 3 packages and 0 specfiles checked; 9 errors, 4 warnings. Requires -------- python-slip (rpmlib, GLIBC filtered): libselinux-python python(abi) python-slip-dbus (rpmlib, GLIBC filtered): dbus-python python(abi) python-decorator python-slip python-slip-gtk (rpmlib, GLIBC filtered): pygtk2 python(abi) python-slip Provides -------- python-slip: python-slip python-slip-dbus: python-slip-dbus python-slip-gtk: python-slip-gtk MD5-sum check ------------- http://fedorahosted.org/released/python-slip/python-slip-0.2.24.tar.bz2 : CHECKSUM(SHA256) this package : ffd4c1beca05b0af9f30923e9304c97e714e2c7e535ff4ccee0486d2d7e7e08b CHECKSUM(SHA256) upstream package : ffd4c1beca05b0af9f30923e9304c97e714e2c7e535ff4ccee0486d2d7e7e08b Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn python-slip -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires