Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Texinfo files are properly installed Note: Texinfo .info file(s) in quagga See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/quagga-0.99.21-4.fc18/quagga/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in quagga- sysvinit , quagga-contrib , quagga-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 972800 bytes in 27 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define with_snmp 1 %define with_vtysh 1 %define with_ospf_te 1 %define with_opaque_lsa 1 %define with_tcp_zebra 0 %define with_pam 0 %define with_ipv6 1 %define with_isisd 1 %define with_ospfclient 1 %define with_ospfapi 1 %define with_rtadv 1 %define with_multipath 64 %define quagga_uid 92 %define quagga_gid 92 %define quagga_user quagga %define vty_group quaggavt %define vty_gid 85 %define _sysconfdir /etc/quagga %define zeb_src %{_builddir}/%{name}-%{version} %define zeb_rh_src %{zeb_src}/redhat %define zeb_docs %{zeb_src}/doc %define _libexecdir %{_exec_prefix}/libexec/quagga %define _includedir %{_prefix}/include %define _libdir %{_exec_prefix}/%{_lib}/quagga %define _localstatedir /var/run/quagga %define __perl_requires %{SOURCE1} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1064960 bytes in /usr/share 10240 quagga-contrib-0.99.21-4.fc18.x86_64.rpm 30720 quagga- sysvinit-0.99.21-4.fc18.x86_64.rpm 993280 quagga-0.99.21-4.fc18.x86_64.rpm 30720 quagga- devel-0.99.21-4.fc18.x86_64.rpm Rpmlint ------- Checking: quagga-0.99.21-4.fc18.x86_64.rpm quagga-sysvinit-0.99.21-4.fc18.x86_64.rpm quagga-contrib-0.99.21-4.fc18.x86_64.rpm quagga-devel-0.99.21-4.fc18.x86_64.rpm quagga.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti quagga.x86_64: E: incorrect-fsf-address /usr/share/doc/quagga-0.99.21/COPYING quagga.x86_64: E: non-standard-dir-perm /etc/quagga 0750L quagga.x86_64: E: non-standard-dir-perm /var/run/quagga 0750L quagga.x86_64: E: non-readable /etc/logrotate.d/quagga 0640L quagga.x86_64: E: non-standard-dir-perm /var/log/quagga 0750L quagga.x86_64: W: no-manual-page-for-binary babeld quagga.x86_64: W: install-file-in-docs /usr/share/doc/quagga-0.99.21/INSTALL quagga.x86_64: W: dangerous-command-in-%post chown quagga-sysvinit.x86_64: W: spelling-error Summary(en_US) SysV -> Sysop quagga-sysvinit.x86_64: W: spelling-error Summary(en_US) initscript -> inscription, postscript quagga-sysvinit.x86_64: W: spelling-error %description -l en_US initscripts -> postscripts, transcripts, inscription quagga-sysvinit.x86_64: E: incorrect-fsf-address /usr/share/doc/quagga-sysvinit-0.99.21/COPYING quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/babeld quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/babeld quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/babeld quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/babeld quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/babeld quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/zebra quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/zebra quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/zebra quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/zebra quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/zebra quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/ospfd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/ospfd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ospfd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ospfd quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ospfd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/ripd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/ripd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ripd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ripd quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ripd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/ospf6d quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/ospf6d quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ospf6d quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ospf6d quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ospf6d quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/ripngd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/ripngd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ripngd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ripngd quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ripngd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/watchquagga quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/watchquagga quagga-sysvinit.x86_64: W: service-default-enabled /etc/rc.d/init.d/watchquagga quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/watchquagga quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/watchquagga quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/watchquagga quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/bgpd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/bgpd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/bgpd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/bgpd quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/bgpd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/isisd quagga-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/isisd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/isisd quagga-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/isisd quagga-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/isisd quagga-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/quagga-contrib-0.99.21/tools 0644L quagga-contrib.x86_64: E: non-standard-dir-perm /usr/share/doc/quagga-contrib-0.99.21 0644L quagga-contrib.x86_64: W: doc-file-dependency /usr/share/doc/quagga-contrib-0.99.21/tools/mrlg.cgi perl(POSIX) quagga-contrib.x86_64: W: doc-file-dependency /usr/share/doc/quagga-contrib-0.99.21/tools/zc.pl /usr/bin/env quagga-contrib.x86_64: W: doc-file-dependency /usr/share/doc/quagga-contrib-0.99.21/tools/mrlg.cgi perl quagga-contrib.x86_64: W: doc-file-dependency /usr/share/doc/quagga-contrib-0.99.21/tools/mrlg.cgi /usr/bin/perl quagga-contrib.x86_64: W: doc-file-dependency /usr/share/doc/quagga-contrib-0.99.21/tools/zc.pl perl(Getopt::Std) quagga-devel.x86_64: W: only-non-binary-in-usr-lib quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/sockunion.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/sigevent.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/share/doc/quagga-devel-0.99.21/COPYING quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/vty.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/vector.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/sockopt.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/command.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_lsa.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/routemap.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/memory.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_lsdb.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_asbr.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_api.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/workqueue.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/distribute.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/getopt.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/smux.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/pqueue.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospfd.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/table.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/filter.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/log.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfapi/ospf_apiclient.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_dump.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/stream.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/privs.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/version.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/buffer.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/plist.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/hash.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/prefix.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/zebra.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/thread.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/keychain.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_nsm.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/zclient.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/network.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/if.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_ism.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/if_rmap.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/ospfd/ospf_opaque.h quagga-devel.x86_64: E: incorrect-fsf-address /usr/include/quagga/linklist.h 4 packages and 0 specfiles checked; 68 errors, 41 warnings. Requires -------- quagga (rpmlib, GLIBC filtered): /bin/sh /sbin/chkconfig /sbin/install-info config(quagga) initscripts libc.so.6()(64bit) libcap.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libm.so.6()(64bit) libnetsnmp.so.30()(64bit) libospf.so.0()(64bit) libospfapiclient.so.0()(64bit) libreadline.so.6()(64bit) librt.so.1()(64bit) libtinfo.so.5()(64bit) libzebra.so.0()(64bit) ncurses net-snmp rtld(GNU_HASH) systemd-units quagga-sysvinit (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/service libc.so.6()(64bit) libcap.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libnetsnmp.so.30()(64bit) librt.so.1()(64bit) libzebra.so.0()(64bit) quagga rtld(GNU_HASH) quagga-devel (rpmlib, GLIBC filtered): libospf.so.0()(64bit) libospfapiclient.so.0()(64bit) libzebra.so.0()(64bit) quagga quagga-contrib (rpmlib, GLIBC filtered): /usr/bin/env /usr/bin/perl perl perl(Getopt::Std) perl(POSIX) Provides -------- quagga: config(quagga) libospf.so.0()(64bit) libospfapiclient.so.0()(64bit) libzebra.so.0()(64bit) quagga quagga(x86-64) routingdaemon quagga-sysvinit: quagga-sysvinit quagga-sysvinit(x86-64) quagga-devel: quagga-devel quagga-devel(x86-64) quagga-contrib: quagga-contrib quagga-contrib(x86-64) MD5-sum check ------------- http://www.quagga.net/download/quagga-0.99.21.tar.xz : CHECKSUM(SHA256) this package : 87329c3d9d4e5c0a74812e725026560c477f610eec9771e67baf513da0357246 CHECKSUM(SHA256) upstream package : dc0d722158f20a9c5f5e09850e74214b199923cfc0bf99902fa6069dcc12c165 diff -r also reports differences Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn quagga -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires