Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rarian- compat , rarian-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 112640 bytes in 7 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: rarian-0.8.1-8.fc18.x86_64.rpm rarian-compat-0.8.1-8.fc18.x86_64.rpm rarian-devel-0.8.1-8.fc18.x86_64.rpm rarian.x86_64: E: explicit-lib-dependency libxslt rarian.x86_64: E: explicit-lib-dependency libxml2 rarian.x86_64: E: explicit-lib-dependency libxml2 rarian.x86_64: W: spelling-error %description -l en_US scrollkeeper -> scroll keeper, scroll-keeper, scorekeeper rarian.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/rarian-example ['/usr/lib64'] rarian.x86_64: E: zero-length /usr/share/doc/rarian-0.8.1/AUTHORS rarian.x86_64: W: no-manual-page-for-binary rarian-example rarian-compat.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/rarian-sk-get-cl ['/usr/lib64'] rarian-compat.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/rarian-sk-gen-uuid ['/usr/lib64'] rarian-compat.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/rarian-sk-migrate ['/usr/lib64'] rarian-compat.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/rarian-sk-preinstall ['/usr/lib64'] rarian-compat.x86_64: W: no-documentation rarian-compat.x86_64: W: devel-file-in-non-devel-package /usr/bin/rarian-sk-config rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-uninstall rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-preinstall rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-install rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-get-scripts rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-extract rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-get-toc-from-id rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-get-extended-content-list rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-get-cl rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-install rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-gen-seriesid rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-extract rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-update rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-update rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-get-cl rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-preinstall rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-gen-uuid rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-config rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-get-content-list rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-rebuild rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-get-toc-from-docpath rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-rebuilddb rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-migrate rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-config rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-get-extended-content-list rarian-compat.x86_64: W: no-manual-page-for-binary scrollkeeper-get-index-from-docpath rarian-compat.x86_64: W: no-manual-page-for-binary rarian-sk-get-content-list rarian-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 9 errors, 31 warnings. Requires -------- rarian-compat (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) librarian.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rarian rtld(GNU_HASH) rarian-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config librarian.so.0()(64bit) pkgconfig rarian rarian (rpmlib, GLIBC filtered): /sbin/ldconfig coreutils gawk libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) librarian.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libxml2 libxslt rtld(GNU_HASH) util-linux Provides -------- rarian-compat: rarian-compat rarian-compat(x86-64) scrollkeeper rarian-devel: pkgconfig(rarian) rarian-devel rarian-devel(x86-64) rarian: librarian.so.0()(64bit) rarian rarian(x86-64) MD5-sum check ------------- http://download.gnome.org/sources/rarian/0.8/rarian-0.8.1.tar.bz2 : CHECKSUM(SHA256) this package : aafe886d46e467eb3414e91fa9e42955bd4b618c3e19c42c773026b205a84577 CHECKSUM(SHA256) upstream package : aafe886d46e467eb3414e91fa9e42955bd4b618c3e19c42c773026b205a84577 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn rarian -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires