Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - update-desktop-database is invoked when required Note: desktop file(s) in rhythmbox See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Static libraries in -static subpackage, if present. Note: Archive *.a files found in rhythmbox See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - Package does not contain any libtool archives (.la) Note: rhythmbox : /usr/lib64/rhythmbox/sample-plugins/sample/libsample.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rhythmbox- lirc , rhythmbox-devel [ ]: glib-compile-schemas is run if required Note: gschema file(s) in rhythmbox [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in rhythmbox [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 153600 bytes in 4 files. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define desktop_file_utils_version 0.9 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 12421120 bytes in /usr/share 962560 rhythmbox-devel-2.98-5.fc19.x86_64.rpm 11458560 rhythmbox-2.98-5.fc19.x86_64.rpm Rpmlint ------- Checking: rhythmbox-2.98-5.fc19.x86_64.rpm rhythmbox-lirc-2.98-5.fc19.x86_64.rpm rhythmbox-devel-2.98-5.fc19.x86_64.rpm rhythmbox.x86_64: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists rhythmbox.x86_64: W: shared-lib-calls-exit /usr/lib64/librhythmbox-core.so.6.0.0 exit@GLIBC_2.2.5 rhythmbox.x86_64: W: devel-file-in-non-devel-package /usr/lib64/librhythmbox-core.so rhythmbox.x86_64: E: incorrect-fsf-address /usr/share/doc/rhythmbox-2.98/COPYING rhythmbox.x86_64: W: devel-file-in-non-devel-package /usr/lib64/rhythmbox/sample-plugins/sample/libsample.a rhythmbox-lirc.x86_64: W: no-documentation rhythmbox-devel.x86_64: W: no-documentation rhythmbox-devel.x86_64: E: incorrect-fsf-address /usr/include/rhythmbox/widgets/rb-alert-dialog.h 3 packages and 0 specfiles checked; 2 errors, 6 warnings. Requires -------- rhythmbox-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(gstreamer-0.10) pkgconfig(gtk+-3.0) pkgconfig(libsoup-2.4) pkgconfig(libsoup-gnome-2.4) pkgconfig(libxml-2.0) pkgconfig(totem-plparser) rhythmbox rhythmbox (rpmlib, GLIBC filtered): /bin/sh GConf2 desktop-file-utils gnome-icon-theme-extras gnome-icon-theme-legacy gstreamer-python gtk3 gvfs-afc libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libbrasero-media3.so.1()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdmapsharing-3.0.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnome-keyring.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgpod.so.4()(64bit) libgrilo-0.2.so.1()(64bit) libgstbase-0.10.so.0()(64bit) libgstcdda-0.10.so.0()(64bit) libgstcontroller-0.10.so.0()(64bit) libgstinterfaces-0.10.so.0()(64bit) libgstpbutils-0.10.so.0()(64bit) libgstreamer-0.10.so.0()(64bit) libgsttag-0.10.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgudev-1.0.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libm.so.6()(64bit) libmtp.so.9()(64bit) libnotify.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpeas-1.0.so.0()(64bit) libpeas-gtk-1.0.so.0()(64bit) libpthread.so.0()(64bit) librhythmbox-core.so.6()(64bit) libsoup-2.4.so.1()(64bit) libsoup-gnome-2.4.so.1()(64bit) libtdb.so.1()(64bit) libtdb.so.1(TDB_1.2.1)(64bit) libtotem-plparser.so.17()(64bit) libusb-1.0.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.6.3)(64bit) libxml2.so.2(LIBXML2_2.6.5)(64bit) libxml2.so.2(LIBXML2_2.6.8)(64bit) libz.so.1()(64bit) media-player-info pygobject3 python-mako rtld(GNU_HASH) rhythmbox-lirc (rpmlib, GLIBC filtered): libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstbase-0.10.so.0()(64bit) libgstcontroller-0.10.so.0()(64bit) libgstinterfaces-0.10.so.0()(64bit) libgstpbutils-0.10.so.0()(64bit) libgstreamer-0.10.so.0()(64bit) libgsttag-0.10.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgudev-1.0.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) liblirc_client.so.0()(64bit) libm.so.6()(64bit) libnotify.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpeas-1.0.so.0()(64bit) libpeas-gtk-1.0.so.0()(64bit) libpthread.so.0()(64bit) librhythmbox-core.so.6()(64bit) libsoup-2.4.so.1()(64bit) libsoup-gnome-2.4.so.1()(64bit) libtdb.so.1()(64bit) libtotem-plparser.so.17()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) rhythmbox rtld(GNU_HASH) Provides -------- rhythmbox-devel: pkgconfig(rhythmbox) rhythmbox-devel rhythmbox-devel(x86-64) rhythmbox: libaudiocd.so()(64bit) libaudioscrobbler.so()(64bit) libcd-recorder.so()(64bit) libdaap.so()(64bit) libdbus-media-server.so()(64bit) libfmradio.so()(64bit) libgeneric-player.so()(64bit) libgrilo.so()(64bit) libipod.so()(64bit) libiradio.so()(64bit) libmmkeys.so()(64bit) libmpris.so()(64bit) libmtpdevice.so()(64bit) libnotification.so()(64bit) libpower-manager.so()(64bit) librhythmbox-core.so.6()(64bit) librhythmbox-itms-detection-plugin.so()(64bit) libsample.so()(64bit) mimehandler(application/ogg) mimehandler(application/x-ogg) mimehandler(audio/mpeg) mimehandler(audio/x-flac) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-scpls) mimehandler(audio/x-vorbis+ogg) mimehandler(x-content/audio-cdda) mimehandler(x-content/audio-player) mimehandler(x-scheme-handler/itms) rhythmbox rhythmbox(x86-64) rhythmbox-upnp rhythmbox-lirc: librblirc.so()(64bit) rhythmbox-lirc rhythmbox-lirc(x86-64) Unversioned so-files -------------------- rhythmbox: /usr/lib64/librhythmbox-core.so rhythmbox: /usr/lib64/mozilla/plugins/librhythmbox-itms-detection-plugin.so rhythmbox: /usr/lib64/rhythmbox/plugins/audiocd/libaudiocd.so rhythmbox: /usr/lib64/rhythmbox/plugins/audioscrobbler/libaudioscrobbler.so rhythmbox: /usr/lib64/rhythmbox/plugins/cd-recorder/libcd-recorder.so rhythmbox: /usr/lib64/rhythmbox/plugins/daap/libdaap.so rhythmbox: /usr/lib64/rhythmbox/plugins/dbus-media-server/libdbus-media-server.so rhythmbox: /usr/lib64/rhythmbox/plugins/fmradio/libfmradio.so rhythmbox: /usr/lib64/rhythmbox/plugins/generic-player/libgeneric-player.so rhythmbox: /usr/lib64/rhythmbox/plugins/grilo/libgrilo.so rhythmbox: /usr/lib64/rhythmbox/plugins/ipod/libipod.so rhythmbox: /usr/lib64/rhythmbox/plugins/iradio/libiradio.so rhythmbox: /usr/lib64/rhythmbox/plugins/mmkeys/libmmkeys.so rhythmbox: /usr/lib64/rhythmbox/plugins/mpris/libmpris.so rhythmbox: /usr/lib64/rhythmbox/plugins/mtpdevice/libmtpdevice.so rhythmbox: /usr/lib64/rhythmbox/plugins/notification/libnotification.so rhythmbox: /usr/lib64/rhythmbox/plugins/power-manager/libpower-manager.so rhythmbox: /usr/lib64/rhythmbox/sample-plugins/sample/libsample.so rhythmbox-lirc: /usr/lib64/rhythmbox/plugins/rblirc/librblirc.so MD5-sum check ------------- http://download.gnome.org/sources/rhythmbox/2.98/rhythmbox-2.98.tar.xz : CHECKSUM(SHA256) this package : a5c0a18a7c76133d36c7dcbdc37e304eae8272703985b17b540d68603b0c76d5 CHECKSUM(SHA256) upstream package : a5c0a18a7c76133d36c7dcbdc37e304eae8272703985b17b540d68603b0c76d5 Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn rhythmbox -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires