Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licensecheck in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 51200 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: rpmdevtools-8.3-2.fc19.noarch.rpm rpmdevtools.noarch: W: spelling-error %description -l en_US rpmdev -> rpm rpmdevtools.noarch: W: spelling-error %description -l en_US setuptree -> setup tree, setup-tree, streetwise rpmdevtools.noarch: W: spelling-error %description -l en_US newspec -> new spec, new-spec, newspaper rpmdevtools.noarch: W: spelling-error %description -l en_US rmdevelrpms -> developments rpmdevtools.noarch: W: spelling-error %description -l en_US checksig -> checkers rpmdevtools.noarch: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring rpmdevtools.noarch: W: spelling-error %description -l en_US executables -> executable, executable s, executrices rpmdevtools.noarch: W: spelling-error %description -l en_US sha -> aha, sh, ha rpmdevtools.noarch: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks rpmdevtools.noarch: W: spelling-error %description -l en_US vercmp -> RCMP rpmdevtools.noarch: W: spelling-error %description -l en_US specfiles -> spec files, spec-files, specifiable rpmdevtools.noarch: W: spelling-error %description -l en_US wipetree -> wipe tree, wipe-tree, tripwire rpmdevtools.noarch: W: spelling-error %description -l en_US dirs -> rids, sirs, firs rpmdevtools.noarch: W: spelling-error %description -l en_US xvf -> xv, xvi, xv f rpmdevtools.noarch: W: spelling-error %description -l en_US bumpspec -> bump spec, bump-spec, bumper rpmdevtools.noarch: W: spelling-error %description -l en_US specfile -> spec file, spec-file, specifiable rpmdevtools.noarch: W: invalid-url URL: https://fedorahosted.org/rpmdevtools/ The read operation timed out rpmdevtools.noarch: E: non-executable-script /etc/rpmdevtools/template.init 0644L /bin/sh rpmdevtools.noarch: E: non-executable-script /usr/share/rpmdevtools/tmpdir.sh 0644L /bin/sh rpmdevtools.noarch: W: non-conffile-in-etc /etc/bash_completion.d/rpmdevtools.bash-completion rpmdevtools.noarch: E: non-executable-script /usr/share/rpmdevtools/trap.sh 0644L /bin/sh rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-bumpspec rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-cksum rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-setuptree rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha384 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha256 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-wipetree rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-md5 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sort rpmdevtools.noarch: W: no-manual-page-for-binary rpminfo rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha1 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-vercmp rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-checksig rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha512 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sum rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha224 rpmdevtools.noarch: W: no-manual-page-for-binary rpmls 1 packages and 0 specfiles checked; 4 errors, 33 warnings. Requires -------- rpmdevtools (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/man /usr/bin/perl /usr/bin/python config(rpmdevtools) curl diffutils emacs-filesystem fakeroot file findutils gawk grep perl(File::Basename) perl(File::Spec) perl(File::Temp) perl(FileHandle) perl(Getopt::Long) perl(strict) perl(warnings) python rpm-build rpm-python sed xemacs-filesystem Provides -------- rpmdevtools: config(rpmdevtools) rpmdevtools spectool MD5-sum check ------------- https://fedorahosted.org/released/rpmdevtools/rpmdevtools-8.3.tar.xz : CHECKSUM(SHA256) this package : 5f03dc5414e485ba8eb6c13480826fe80cc55d04df064a2117e63b4667fc42cf CHECKSUM(SHA256) upstream package : 5f03dc5414e485ba8eb6c13480826fe80cc55d04df064a2117e63b4667fc42cf Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn rpmdevtools -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires