Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 1515520 bytes in 148 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rsyslog-doc , rsyslog-elasticsearch , rsyslog-hiredis , rsyslog-mmjsonparse , rsyslog-mmnormalize , rsyslog-mmaudit , rsyslog-mmsnmptrapd , rsyslog- libdbi , rsyslog-mysql , rsyslog-mongodb , rsyslog-pgsql , rsyslog-gssapi , rsyslog-relp , rsyslog-gnutls , rsyslog-snmp , rsyslog-udpspoof [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define rsyslog_statedir %{_sharedstatedir}/rsyslog %define rsyslog_pkidir %{_sysconfdir}/pki/rsyslog [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1556480 bytes in /usr/share 1024000 rsyslog-doc-7.2.5-2.fc19.x86_64.rpm 10240 rsyslog- pgsql-7.2.5-2.fc19.x86_64.rpm 512000 rsyslog-7.2.5-2.fc19.x86_64.rpm 10240 rsyslog-mysql-7.2.5-2.fc19.x86_64.rpm Rpmlint ------- Checking: rsyslog-7.2.5-2.fc19.x86_64.rpm rsyslog-doc-7.2.5-2.fc19.x86_64.rpm rsyslog-elasticsearch-7.2.5-2.fc19.x86_64.rpm rsyslog-hiredis-7.2.5-2.fc19.x86_64.rpm rsyslog-mmjsonparse-7.2.5-2.fc19.x86_64.rpm rsyslog-mmnormalize-7.2.5-2.fc19.x86_64.rpm rsyslog-mmaudit-7.2.5-2.fc19.x86_64.rpm rsyslog-mmsnmptrapd-7.2.5-2.fc19.x86_64.rpm rsyslog-libdbi-7.2.5-2.fc19.x86_64.rpm rsyslog-mysql-7.2.5-2.fc19.x86_64.rpm rsyslog-mongodb-7.2.5-2.fc19.x86_64.rpm rsyslog-pgsql-7.2.5-2.fc19.x86_64.rpm rsyslog-gssapi-7.2.5-2.fc19.x86_64.rpm rsyslog-relp-7.2.5-2.fc19.x86_64.rpm rsyslog-gnutls-7.2.5-2.fc19.x86_64.rpm rsyslog-snmp-7.2.5-2.fc19.x86_64.rpm rsyslog-udpspoof-7.2.5-2.fc19.x86_64.rpm rsyslog.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti rsyslog.x86_64: W: obsolete-not-provided sysklogd rsyslog.x86_64: W: only-non-binary-in-usr-lib rsyslog.x86_64: E: non-standard-dir-perm /var/lib/rsyslog 0700L rsyslog.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/syslog rsyslog.x86_64: E: non-standard-dir-perm /etc/pki/rsyslog 0700L rsyslog-doc.x86_64: W: spelling-error %description -l en_US subpackage -> sub package, sub-package, package's rsyslog-elasticsearch.x86_64: W: no-documentation rsyslog-hiredis.x86_64: W: spelling-error Summary(en_US) Redis -> Re dis, Re-dis, Rides rsyslog-hiredis.x86_64: W: no-documentation rsyslog-mmjsonparse.x86_64: W: spelling-error %description -l en_US syslog -> slog rsyslog-mmjsonparse.x86_64: W: no-documentation rsyslog-mmnormalize.x86_64: W: spelling-error %description -l en_US liblognorm -> abnormality rsyslog-mmnormalize.x86_64: W: no-documentation rsyslog-mmaudit.x86_64: W: no-documentation rsyslog-mmsnmptrapd.x86_64: W: spelling-error Summary(en_US) snmptrapd -> snapdragon rsyslog-mmsnmptrapd.x86_64: W: spelling-error %description -l en_US snmptrapd -> snapdragon rsyslog-mmsnmptrapd.x86_64: W: no-documentation rsyslog-libdbi.x86_64: W: no-documentation rsyslog-mongodb.x86_64: W: no-documentation rsyslog-gssapi.x86_64: W: no-documentation rsyslog-relp.x86_64: W: spelling-error %description -l en_US syslog -> slog rsyslog-relp.x86_64: W: no-documentation rsyslog-gnutls.x86_64: W: spelling-error %description -l en_US syslog -> slog rsyslog-gnutls.x86_64: W: spelling-error %description -l en_US tls -> ts, ls, tbs rsyslog-gnutls.x86_64: W: no-documentation rsyslog-snmp.x86_64: W: spelling-error %description -l en_US syslog -> slog rsyslog-snmp.x86_64: W: no-documentation rsyslog-udpspoof.x86_64: W: spelling-error Summary(en_US) omudpspoof rsyslog-udpspoof.x86_64: W: no-documentation 17 packages and 0 specfiles checked; 3 errors, 27 warnings. Requires -------- rsyslog-mmaudit (rpmlib, GLIBC filtered): libc.so.6()(64bit) libee.so.0()(64bit) liblognorm.so.0()(64bit) libm.so.6()(64bit) rsyslog rtld(GNU_HASH) rsyslog-mongodb (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmongo-client.so.0()(64bit) rsyslog rtld(GNU_HASH) rsyslog-gssapi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) rsyslog rtld(GNU_HASH) rsyslog-libdbi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdbi.so.0()(64bit) rsyslog rtld(GNU_HASH) rsyslog-pgsql (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpq.so.5()(64bit) rsyslog rtld(GNU_HASH) rsyslog-hiredis (rpmlib, GLIBC filtered): libc.so.6()(64bit) rsyslog rtld(GNU_HASH) rsyslog-mysql (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_16)(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libz.so.1()(64bit) rsyslog rtld(GNU_HASH) rsyslog-relp (rpmlib, GLIBC filtered): libc.so.6()(64bit) librelp.so.0()(64bit) rsyslog rtld(GNU_HASH) rsyslog-mmnormalize (rpmlib, GLIBC filtered): libc.so.6()(64bit) libee.so.0()(64bit) liblognorm.so.0()(64bit) libm.so.6()(64bit) rsyslog rtld(GNU_HASH) rsyslog-mmsnmptrapd (rpmlib, GLIBC filtered): libc.so.6()(64bit) rsyslog rtld(GNU_HASH) rsyslog (rpmlib, GLIBC filtered): /bin/sh bash config(rsyslog) libc.so.6()(64bit) libdl.so.2()(64bit) libee.so.0()(64bit) libestr.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjson.so.0()(64bit) liblognorm.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libz.so.1()(64bit) logrotate rtld(GNU_HASH) systemd rsyslog-doc (rpmlib, GLIBC filtered): rsyslog-elasticsearch (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcurl.so.4()(64bit) libm.so.6()(64bit) rsyslog rtld(GNU_HASH) rsyslog-gnutls (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgnutls.so.26()(64bit) libgnutls.so.26(GNUTLS_1_4)(64bit) rsyslog rtld(GNU_HASH) rsyslog-mmjsonparse (rpmlib, GLIBC filtered): libc.so.6()(64bit) libee.so.0()(64bit) liblognorm.so.0()(64bit) libm.so.6()(64bit) rsyslog rtld(GNU_HASH) rsyslog-snmp (rpmlib, GLIBC filtered): libc.so.6()(64bit) libnetsnmp.so.30()(64bit) rsyslog rtld(GNU_HASH) rsyslog-udpspoof (rpmlib, GLIBC filtered): libc.so.6()(64bit) libnet.so.1()(64bit) rsyslog rtld(GNU_HASH) Provides -------- rsyslog-mmaudit: mmaudit.so()(64bit) rsyslog-mmaudit rsyslog-mmaudit(x86-64) rsyslog-mongodb: ommongodb.so()(64bit) rsyslog-mongodb rsyslog-mongodb(x86-64) rsyslog-gssapi: imgssapi.so()(64bit) lmgssutil.so()(64bit) omgssapi.so()(64bit) rsyslog-gssapi rsyslog-gssapi(x86-64) rsyslog-libdbi: omlibdbi.so()(64bit) rsyslog-libdbi rsyslog-libdbi(x86-64) rsyslog-pgsql: ompgsql.so()(64bit) rsyslog-pgsql rsyslog-pgsql(x86-64) rsyslog-hiredis: omhiredis.so()(64bit) rsyslog-hiredis rsyslog-hiredis(x86-64) rsyslog-mysql: ommysql.so()(64bit) rsyslog-mysql rsyslog-mysql(x86-64) rsyslog-relp: imrelp.so()(64bit) omrelp.so()(64bit) rsyslog-relp rsyslog-relp(x86-64) rsyslog-mmnormalize: mmnormalize.so()(64bit) rsyslog-mmnormalize rsyslog-mmnormalize(x86-64) rsyslog-mmsnmptrapd: mmsnmptrapd.so()(64bit) rsyslog-mmsnmptrapd rsyslog-mmsnmptrapd(x86-64) rsyslog: config(rsyslog) imdiag.so()(64bit) imfile.so()(64bit) imklog.so()(64bit) imkmsg.so()(64bit) immark.so()(64bit) impstats.so()(64bit) imptcp.so()(64bit) imtcp.so()(64bit) imudp.so()(64bit) imuxsock.so()(64bit) lmnet.so()(64bit) lmnetstrms.so()(64bit) lmnsd_ptcp.so()(64bit) lmregexp.so()(64bit) lmstrmsrv.so()(64bit) lmtcpclt.so()(64bit) lmtcpsrv.so()(64bit) lmzlibw.so()(64bit) ommail.so()(64bit) omprog.so()(64bit) omruleset.so()(64bit) omstdout.so()(64bit) omtesting.so()(64bit) omuxsock.so()(64bit) pmaixforwardedfrom.so()(64bit) pmcisconames.so()(64bit) pmlastmsg.so()(64bit) pmrfc3164sd.so()(64bit) pmsnare.so()(64bit) rsyslog rsyslog(x86-64) syslog rsyslog-doc: rsyslog-doc rsyslog-doc(x86-64) rsyslog-elasticsearch: omelasticsearch.so()(64bit) rsyslog-elasticsearch rsyslog-elasticsearch(x86-64) rsyslog-gnutls: lmnsd_gtls.so()(64bit) rsyslog-gnutls rsyslog-gnutls(x86-64) rsyslog-mmjsonparse: mmjsonparse.so()(64bit) rsyslog-mmjsonparse rsyslog-mmjsonparse(x86-64) rsyslog-snmp: omsnmp.so()(64bit) rsyslog-snmp rsyslog-snmp(x86-64) rsyslog-udpspoof: omudpspoof.so()(64bit) rsyslog-udpspoof rsyslog-udpspoof(x86-64) Unversioned so-files -------------------- rsyslog: /lib64/rsyslog/imdiag.so rsyslog: /lib64/rsyslog/imfile.so rsyslog: /lib64/rsyslog/imklog.so rsyslog: /lib64/rsyslog/imkmsg.so rsyslog: /lib64/rsyslog/immark.so rsyslog: /lib64/rsyslog/impstats.so rsyslog: /lib64/rsyslog/imptcp.so rsyslog: /lib64/rsyslog/imtcp.so rsyslog: /lib64/rsyslog/imudp.so rsyslog: /lib64/rsyslog/imuxsock.so rsyslog: /lib64/rsyslog/lmnet.so rsyslog: /lib64/rsyslog/lmnetstrms.so rsyslog: /lib64/rsyslog/lmnsd_ptcp.so rsyslog: /lib64/rsyslog/lmregexp.so rsyslog: /lib64/rsyslog/lmstrmsrv.so rsyslog: /lib64/rsyslog/lmtcpclt.so rsyslog: /lib64/rsyslog/lmtcpsrv.so rsyslog: /lib64/rsyslog/lmzlibw.so rsyslog: /lib64/rsyslog/ommail.so rsyslog: /lib64/rsyslog/omprog.so rsyslog: /lib64/rsyslog/omruleset.so rsyslog: /lib64/rsyslog/omstdout.so rsyslog: /lib64/rsyslog/omtesting.so rsyslog: /lib64/rsyslog/omuxsock.so rsyslog: /lib64/rsyslog/pmaixforwardedfrom.so rsyslog: /lib64/rsyslog/pmcisconames.so rsyslog: /lib64/rsyslog/pmlastmsg.so rsyslog: /lib64/rsyslog/pmrfc3164sd.so rsyslog: /lib64/rsyslog/pmsnare.so rsyslog-elasticsearch: /lib64/rsyslog/omelasticsearch.so rsyslog-hiredis: /lib64/rsyslog/omhiredis.so rsyslog-mmjsonparse: /lib64/rsyslog/mmjsonparse.so rsyslog-mmnormalize: /lib64/rsyslog/mmnormalize.so rsyslog-mmaudit: /lib64/rsyslog/mmaudit.so rsyslog-mmsnmptrapd: /lib64/rsyslog/mmsnmptrapd.so rsyslog-libdbi: /lib64/rsyslog/omlibdbi.so rsyslog-mysql: /lib64/rsyslog/ommysql.so rsyslog-mongodb: /lib64/rsyslog/ommongodb.so rsyslog-pgsql: /lib64/rsyslog/ompgsql.so rsyslog-gssapi: /lib64/rsyslog/imgssapi.so rsyslog-gssapi: /lib64/rsyslog/lmgssutil.so rsyslog-gssapi: /lib64/rsyslog/omgssapi.so rsyslog-relp: /lib64/rsyslog/imrelp.so rsyslog-relp: /lib64/rsyslog/omrelp.so rsyslog-gnutls: /lib64/rsyslog/lmnsd_gtls.so rsyslog-snmp: /lib64/rsyslog/omsnmp.so rsyslog-udpspoof: /lib64/rsyslog/omudpspoof.so MD5-sum check ------------- http://www.rsyslog.com/files/download/rsyslog/rsyslog-7.2.5.tar.gz : CHECKSUM(SHA256) this package : 8cce8c61610bde4eb09dc379281362650cced4c75097c9756acce8bfaac96bfb CHECKSUM(SHA256) upstream package : 8cce8c61610bde4eb09dc379281362650cced4c75097c9756acce8bfaac96bfb Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn rsyslog -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires