Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - GConf schemas are properly installed Note: gconf file(s) in sound-juicer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf - update-desktop-database is invoked when required Note: desktop file(s) in sound-juicer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: The spec file handles locales properly. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in sound-juicer [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 71680 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define glib_version 2.18.0 %define gconf_version 2.14 %define scrollkeeper_version 0.3.5 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3799040 bytes in /usr/share 3799040 sound-juicer-3.5.0-2.fc18.x86_64.rpm Rpmlint ------- Checking: sound-juicer-3.5.0-2.fc18.x86_64.rpm sound-juicer.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer sound-juicer.x86_64: W: spelling-error %description -l en_US vorbis -> Orbison sound-juicer.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/sound-juicer.schemas sound-juicer.x86_64: E: incorrect-fsf-address /usr/share/doc/sound-juicer-3.5.0/COPYING 1 packages and 0 specfiles checked; 1 errors, 3 warnings. Requires -------- sound-juicer (rpmlib, GLIBC filtered): /bin/sh /usr/bin/gtk-update-icon-cache GConf2 desktop-file-utils gstreamer1-plugins-good libatk-1.0.so.0()(64bit) libbrasero-media3.so.1()(64bit) libc.so.6()(64bit) libcanberra-gtk3.so.0()(64bit) libdiscid.so.0()(64bit) libgconf-2.so.4()(64bit) libgdk-3.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstpbutils-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libmusicbrainz5.so.0()(64bit) libpango-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- sound-juicer: mimehandler(x-content/audio-cdda) sound-juicer sound-juicer(x86-64) MD5-sum check ------------- http://download.gnome.org/sources/sound-juicer/3.5/sound-juicer-3.5.0.tar.xz : CHECKSUM(SHA256) this package : ea76703e08e67590af7b8ce5206c343eb01d77cd5023c0bc958a0c2f5a98d2e9 CHECKSUM(SHA256) upstream package : ea76703e08e67590af7b8ce5206c343eb01d77cd5023c0bc958a0c2f5a98d2e9 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn sound-juicer -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires