Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: http://fedoraproject.org/wiki/Packaging:Perl - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 122880 bytes in 11 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: #%%define rhel 4 %{?!rhel:%define rhel 0} %{?!fedora:%define fedora 0} %define fedora 3 %define dist .el4 %define fedora 6 %define dist .el5 %define fedora 12 %define dist .el6 %define fedora 16 %define option_ssl 0 %define perl_devel 0 %define dkim_deps 0 %define require_encode_detect 0 %define use_systemd 0 %define option_ssl 1 %define perl_devel 1 %define require_encode_detect 1 %define dkim_deps 1 %define use_systemd 1 %define real_name Mail-SpamAssassin %{!?perl_vendorlib: %define perl_vendorlib %(eval "`%{__perl} -V:installvendorlib`"; echo $installvendorlib)} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3266560 bytes in /usr/share 3266560 spamassassin-3.3.2-14.fc19.x86_64.rpm Rpmlint ------- Checking: spamassassin-3.3.2-14.fc19.x86_64.rpm spamassassin.x86_64: W: spelling-error %description -l en_US sendmail -> send mail, send-mail, Sendai spamassassin.x86_64: W: spelling-error %description -l en_US postfix -> post fix, post-fix, postbox spamassassin.x86_64: W: spelling-error %description -l en_US spammy -> spam my, spam-my, Spam spamassassin.x86_64: W: spelling-error %description -l en_US procmailrc -> proclamation spamassassin.x86_64: W: obsolete-not-provided perl-Mail-SpamAssassin spamassassin.x86_64: W: only-non-binary-in-usr-lib spamassassin.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/sa-update spamassassin.x86_64: E: non-standard-executable-perm /usr/share/spamassassin/sa-update.cron 0744L spamassassin.x86_64: E: executable-marked-as-config-file /etc/mail/spamassassin/spamassassin-helper.sh spamassassin.x86_64: E: zero-length /usr/share/spamassassin/STATISTICS-set2-72_scores.cf.txt spamassassin.x86_64: W: non-conffile-in-etc /etc/cron.d/sa-update spamassassin.x86_64: E: non-standard-dir-perm /etc/mail/spamassassin/sa-update-keys 0700L spamassassin.x86_64: E: zero-length /usr/share/spamassassin/STATISTICS-set3-72_scores.cf.txt spamassassin.x86_64: W: no-manual-page-for-binary sa-check_spamd spamassassin.x86_64: W: dangerous-command-in-%post cp 1 packages and 0 specfiles checked; 6 errors, 9 warnings. Requires -------- spamassassin (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/chkconfig /sbin/service /usr/bin/perl config(spamassassin) diffutils gnupg libc.so.6()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libz.so.1()(64bit) perl perl(:MODULE_COMPAT_5.16.2) perl(AnyDBM_File) perl(Archive::Tar) perl(Carp) perl(Config) perl(Cwd) perl(DB_File) perl(Data::Dumper) perl(Encode::Detect) perl(Errno) perl(Exporter) perl(ExtUtils::MakeMaker) perl(Fcntl) perl(File::Basename) perl(File::Copy) perl(File::Path) perl(File::Spec) perl(Getopt::Long) perl(HTML::Parser) perl(HTTP::Date) perl(IO::File) perl(IO::Handle) perl(IO::Pipe) perl(IO::Socket) perl(IO::Socket::INET) perl(IO::Socket::INET6) perl(IO::Socket::SSL) perl(IO::Zlib) perl(LWP::UserAgent) perl(Mail::DKIM) perl(Mail::SPF) perl(Mail::SpamAssassin) perl(Mail::SpamAssassin::AICache) perl(Mail::SpamAssassin::ArchiveIterator) perl(Mail::SpamAssassin::AsyncLoop) perl(Mail::SpamAssassin::AutoWhitelist) perl(Mail::SpamAssassin::Bayes) perl(Mail::SpamAssassin::Bayes::CombineChi) perl(Mail::SpamAssassin::BayesStore) perl(Mail::SpamAssassin::BayesStore::DBM) perl(Mail::SpamAssassin::BayesStore::SQL) perl(Mail::SpamAssassin::Conf) perl(Mail::SpamAssassin::Conf::LDAP) perl(Mail::SpamAssassin::Conf::Parser) perl(Mail::SpamAssassin::Conf::SQL) perl(Mail::SpamAssassin::Constants) perl(Mail::SpamAssassin::Dns) perl(Mail::SpamAssassin::DnsResolver) perl(Mail::SpamAssassin::HTML) perl(Mail::SpamAssassin::Locales) perl(Mail::SpamAssassin::Locker) perl(Mail::SpamAssassin::Logger) perl(Mail::SpamAssassin::Logger::Stderr) perl(Mail::SpamAssassin::Message) perl(Mail::SpamAssassin::Message::Metadata) perl(Mail::SpamAssassin::Message::Metadata::Received) perl(Mail::SpamAssassin::Message::Node) perl(Mail::SpamAssassin::NetSet) perl(Mail::SpamAssassin::PerMsgLearner) perl(Mail::SpamAssassin::PerMsgStatus) perl(Mail::SpamAssassin::PersistentAddrList) perl(Mail::SpamAssassin::Plugin) perl(Mail::SpamAssassin::Plugin::OneLineBodyRuleType) perl(Mail::SpamAssassin::PluginHandler) perl(Mail::SpamAssassin::SpamdForkScaling) perl(Mail::SpamAssassin::SubProcBackChannel) perl(Mail::SpamAssassin::Timeout) perl(Mail::SpamAssassin::Util) perl(Mail::SpamAssassin::Util::Progress) perl(Mail::SpamAssassin::Util::RegistrarBoundaries) perl(Mail::SpamAssassin::Util::ScopedTimer) perl(Mail::SpamAssassin::Util::TieOneStringHash) perl(Net::DNS) perl(NetAddr::IP) perl(POSIX) perl(Pod::Usage) perl(Socket) perl(Sys::Hostname) perl(Sys::Syslog) perl(Time::HiRes) perl(Time::Local) perl(XSLoader) perl(base) perl(bytes) perl(constant) perl(lib) perl(re) perl(strict) perl(vars) perl(warnings) perl-HTML-Parser portreserve procmail rtld(GNU_HASH) systemd-sysv systemd-units Provides -------- spamassassin: config(spamassassin) perl(Mail::SpamAssassin) perl(Mail::SpamAssassin::AICache) perl(Mail::SpamAssassin::ArchiveIterator) perl(Mail::SpamAssassin::AsyncLoop) perl(Mail::SpamAssassin::AutoWhitelist) perl(Mail::SpamAssassin::Bayes) perl(Mail::SpamAssassin::Bayes::Combine) perl(Mail::SpamAssassin::Bayes::CombineChi) perl(Mail::SpamAssassin::Bayes::CombineNaiveBayes) perl(Mail::SpamAssassin::BayesStore) perl(Mail::SpamAssassin::BayesStore::BDB) perl(Mail::SpamAssassin::BayesStore::DBM) perl(Mail::SpamAssassin::BayesStore::MySQL) perl(Mail::SpamAssassin::BayesStore::PgSQL) perl(Mail::SpamAssassin::BayesStore::SDBM) perl(Mail::SpamAssassin::BayesStore::SQL) perl(Mail::SpamAssassin::Client) perl(Mail::SpamAssassin::Conf) perl(Mail::SpamAssassin::Conf::LDAP) perl(Mail::SpamAssassin::Conf::Parser) perl(Mail::SpamAssassin::Conf::SQL) perl(Mail::SpamAssassin::Constants) perl(Mail::SpamAssassin::DBBasedAddrList) perl(Mail::SpamAssassin::Dns) perl(Mail::SpamAssassin::DnsResolver) perl(Mail::SpamAssassin::HTML) perl(Mail::SpamAssassin::Locales) perl(Mail::SpamAssassin::Locker) perl(Mail::SpamAssassin::Locker::Flock) perl(Mail::SpamAssassin::Locker::UnixNFSSafe) perl(Mail::SpamAssassin::Locker::Win32) perl(Mail::SpamAssassin::Logger) perl(Mail::SpamAssassin::Logger::File) perl(Mail::SpamAssassin::Logger::Stderr) perl(Mail::SpamAssassin::Logger::Syslog) perl(Mail::SpamAssassin::MailingList) perl(Mail::SpamAssassin::Message) perl(Mail::SpamAssassin::Message::Metadata) perl(Mail::SpamAssassin::Message::Metadata::Received) perl(Mail::SpamAssassin::Message::Node) perl(Mail::SpamAssassin::NetSet) perl(Mail::SpamAssassin::PerMsgLearner) perl(Mail::SpamAssassin::PerMsgStatus) perl(Mail::SpamAssassin::PersistentAddrList) perl(Mail::SpamAssassin::Plugin) perl(Mail::SpamAssassin::Plugin::ASN) perl(Mail::SpamAssassin::Plugin::AWL) perl(Mail::SpamAssassin::Plugin::AccessDB) perl(Mail::SpamAssassin::Plugin::AntiVirus) perl(Mail::SpamAssassin::Plugin::AutoLearnThreshold) perl(Mail::SpamAssassin::Plugin::Bayes) perl(Mail::SpamAssassin::Plugin::BodyEval) perl(Mail::SpamAssassin::Plugin::BodyRuleBaseExtractor) perl(Mail::SpamAssassin::Plugin::Check) perl(Mail::SpamAssassin::Plugin::DCC) perl(Mail::SpamAssassin::Plugin::DKIM) perl(Mail::SpamAssassin::Plugin::DNSEval) perl(Mail::SpamAssassin::Plugin::FreeMail) perl(Mail::SpamAssassin::Plugin::HTMLEval) perl(Mail::SpamAssassin::Plugin::HTTPSMismatch) perl(Mail::SpamAssassin::Plugin::Hashcash) perl(Mail::SpamAssassin::Plugin::HeaderEval) perl(Mail::SpamAssassin::Plugin::ImageInfo) perl(Mail::SpamAssassin::Plugin::MIMEEval) perl(Mail::SpamAssassin::Plugin::MIMEHeader) perl(Mail::SpamAssassin::Plugin::OneLineBodyRuleType) perl(Mail::SpamAssassin::Plugin::PhishTag) perl(Mail::SpamAssassin::Plugin::Pyzor) perl(Mail::SpamAssassin::Plugin::Razor2) perl(Mail::SpamAssassin::Plugin::RelayCountry) perl(Mail::SpamAssassin::Plugin::RelayEval) perl(Mail::SpamAssassin::Plugin::ReplaceTags) perl(Mail::SpamAssassin::Plugin::Reuse) perl(Mail::SpamAssassin::Plugin::Rule2XSBody) perl(Mail::SpamAssassin::Plugin::SPF) perl(Mail::SpamAssassin::Plugin::Shortcircuit) perl(Mail::SpamAssassin::Plugin::SpamCop) perl(Mail::SpamAssassin::Plugin::Test) perl(Mail::SpamAssassin::Plugin::TextCat) perl(Mail::SpamAssassin::Plugin::URIDNSBL) perl(Mail::SpamAssassin::Plugin::URIDetail) perl(Mail::SpamAssassin::Plugin::URIEval) perl(Mail::SpamAssassin::Plugin::VBounce) perl(Mail::SpamAssassin::Plugin::WLBLEval) perl(Mail::SpamAssassin::Plugin::WhiteListSubject) perl(Mail::SpamAssassin::PluginHandler) perl(Mail::SpamAssassin::Reporter) perl(Mail::SpamAssassin::SQLBasedAddrList) perl(Mail::SpamAssassin::SpamdForkScaling) perl(Mail::SpamAssassin::SubProcBackChannel) perl(Mail::SpamAssassin::Timeout) perl(Mail::SpamAssassin::Util) perl(Mail::SpamAssassin::Util::DependencyInfo) perl(Mail::SpamAssassin::Util::Progress) perl(Mail::SpamAssassin::Util::RegistrarBoundaries) perl(Mail::SpamAssassin::Util::ScopedTimer) perl(Mail::SpamAssassin::Util::TieOneStringHash) spamassassin spamassassin(x86-64) MD5-sum check ------------- http://www.apache.org/dist/spamassassin/Mail-SpamAssassin-3.3.2.tar.bz2 : CHECKSUM(SHA256) this package : c7239b4b4ef04ba5e2d5aedb9156850146ed3fa47c88f0a0757f08e22f93a205 CHECKSUM(SHA256) upstream package : c7239b4b4ef04ba5e2d5aedb9156850146ed3fa47c88f0a0757f08e22f93a205 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn spamassassin -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires