Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Large documentation must go in a -doc subpackage. Note: Documentation size is 1198080 bytes in 158 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libsss_idmap , libsss_idmap-devel , libipa_hbac , libipa_hbac-devel , libipa_hbac-python , libsss_sudo , libsss_sudo-devel , libsss_autofs [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define __provides_exclude_from %{python_sitearch}/.*\.so$ %define _hardened_build 1 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2068480 bytes in /usr/share 706560 sssd-1.9.3-1.fc19.x86_64.rpm 71680 sssd-client-1.9.3-1.fc19.x86_64.rpm 276480 libsss_sudo-devel-1.9.3-1.fc19.x86_64.rpm 163840 sssd- tools-1.9.3-1.fc19.x86_64.rpm 327680 libsss_idmap- devel-1.9.3-1.fc19.x86_64.rpm 51200 libsss_idmap-1.9.3-1.fc19.x86_64.rpm 317440 libipa_hbac-devel-1.9.3-1.fc19.x86_64.rpm 51200 libsss_autofs-1.9.3-1.fc19.x86_64.rpm 51200 libsss_sudo-1.9.3-1.fc19.x86_64.rpm 51200 libipa_hbac-1.9.3-1.fc19.x86_64.rpm Rpmlint ------- Checking: sssd-1.9.3-1.fc19.x86_64.rpm libsss_idmap-1.9.3-1.fc19.x86_64.rpm libsss_idmap-devel-1.9.3-1.fc19.x86_64.rpm libipa_hbac-1.9.3-1.fc19.x86_64.rpm libipa_hbac-devel-1.9.3-1.fc19.x86_64.rpm libipa_hbac-python-1.9.3-1.fc19.x86_64.rpm libsss_sudo-1.9.3-1.fc19.x86_64.rpm libsss_sudo-devel-1.9.3-1.fc19.x86_64.rpm libsss_autofs-1.9.3-1.fc19.x86_64.rpm sssd.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged sssd.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end sssd.x86_64: E: non-readable /etc/sssd/sssd.conf 0600L sssd.x86_64: E: non-standard-dir-perm /etc/sssd 0700L sssd.x86_64: E: non-standard-dir-perm /var/lib/sss/pipes/private 0700L sssd.x86_64: E: non-standard-dir-perm /var/lib/sss/db 0700L sssd.x86_64: E: non-standard-dir-perm /var/log/sssd 0750L libsss_idmap.x86_64: W: spelling-error %description -l en_US uids -> yids, ids, aids libsss_idmap.x86_64: W: spelling-error %description -l en_US gids -> digs, gods, ids libsss_idmap-devel.x86_64: W: spelling-error %description -l en_US uids -> yids, ids, aids libsss_idmap-devel.x86_64: W: spelling-error %description -l en_US gids -> digs, gods, ids libipa_hbac-python.x86_64: W: spelling-error %description -l en_US libipa -> alibi libipa_hbac-python.x86_64: W: spelling-error %description -l en_US hbac -> Bach libipa_hbac-python.x86_64: W: no-documentation libsss_sudo.x86_64: E: invalid-soname /usr/lib64/libsss_sudo.so libsss_sudo.so 9 packages and 0 specfiles checked; 6 errors, 9 warnings. Requires -------- libsss_idmap (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) rtld(GNU_HASH) libsss_idmap-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libsss_idmap libsss_idmap.so.0()(64bit) libipa_hbac-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libipa_hbac libipa_hbac.so.0()(64bit) sssd (rpmlib, GLIBC filtered): /bin/sh chkconfig config(sssd) cyrus-sasl-gssapi(x86-64) initscripts krb5-libs(x86-64) libc.so.6()(64bit) libcares.so.2()(64bit) libcollection.so.2()(64bit) libcom_err.so.2()(64bit) libdbus-1.so.3()(64bit) libdhash.so.1()(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libini_config.so.3()(64bit) libipa_hbac(x86-64) libipa_hbac.so.0()(64bit) libk5crypto.so.3()(64bit) libkeyutils.so.1()(64bit) libkeyutils.so.1(KEYUTILS_0.3)(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libldb(x86-64) libldb.so.1()(64bit) libldb.so.1(LDB_0.9.10)(64bit) libm.so.6()(64bit) libndr-krb5pac.so.0()(64bit) libndr-krb5pac.so.0(NDR_KRB5PAC_0.0.1)(64bit) libndr.so.0()(64bit) libndr.so.0(NDR_0.0.1)(64bit) libnl.so.1()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnss3.so(NSS_3.10)(64bit) libnss3.so(NSS_3.2)(64bit) libnss3.so(NSS_3.3)(64bit) libnss3.so(NSS_3.4)(64bit) libnssutil3.so()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpcre.so.1()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpopt.so.0()(64bit) libpopt.so.0(LIBPOPT_0)(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libsamba-util.so.0()(64bit) libsamba-util.so.0(SAMBA_UTIL_0.0.1)(64bit) libselinux.so.1()(64bit) libsemanage.so.1()(64bit) libsemanage.so.1(LIBSEMANAGE_1.0)(64bit) libsmime3.so()(64bit) libssl3.so()(64bit) libsss_idmap(x86-64) libsss_idmap.so.0()(64bit) libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) libtdb(x86-64) libtdb.so.1()(64bit) libtdb.so.1(TDB_1.2.1)(64bit) libtevent.so.0()(64bit) libtevent.so.0(TEVENT_0.9.9)(64bit) libutil.so.1()(64bit) python(abi) rtld(GNU_HASH) sssd-client(x86-64) systemd-units libipa_hbac (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libglib-2.0.so.0()(64bit) rtld(GNU_HASH) libsss_sudo (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) sssd libsss_autofs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libipa_hbac-python (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libipa_hbac libipa_hbac.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libutil.so.1()(64bit) python(abi) rtld(GNU_HASH) libsss_sudo-devel (rpmlib, GLIBC filtered): libsss_sudo Provides -------- libsss_idmap: libsss_idmap libsss_idmap(x86-64) libsss_idmap.so.0()(64bit) libsss_idmap-devel: libsss_idmap-devel libsss_idmap-devel(x86-64) pkgconfig(sss_idmap) libipa_hbac-devel: libipa_hbac-devel libipa_hbac-devel(x86-64) pkgconfig(ipa_hbac) sssd: config(sssd) libsss_ad.so()(64bit) libsss_ipa.so()(64bit) libsss_krb5.so()(64bit) libsss_ldap.so()(64bit) libsss_proxy.so()(64bit) libsss_simple.so()(64bit) memberof.so()(64bit) sssd sssd(x86-64) libipa_hbac: libipa_hbac libipa_hbac(x86-64) libipa_hbac.so.0()(64bit) libsss_sudo: libsss_sudo libsss_sudo(x86-64) libsss_sudo.so()(64bit) libsss_sudo.so(EXPORTED)(64bit) libsss_autofs: libsss_autofs libsss_autofs(x86-64) libsss_autofs.so()(64bit) libsss_autofs.so(EXPORTED)(64bit) libipa_hbac-python: libipa_hbac-python libipa_hbac-python(x86-64) libsss_sudo-devel: libsss_sudo-devel libsss_sudo-devel(x86-64) Unversioned so-files -------------------- sssd: /usr/lib64/ldb/modules/ldb/memberof.so sssd: /usr/lib64/python2.7/site-packages/pysss.so sssd: /usr/lib64/python2.7/site-packages/pysss_murmur.so sssd: /usr/lib64/sssd/libsss_ad.so sssd: /usr/lib64/sssd/libsss_ipa.so sssd: /usr/lib64/sssd/libsss_krb5.so sssd: /usr/lib64/sssd/libsss_ldap.so sssd: /usr/lib64/sssd/libsss_proxy.so sssd: /usr/lib64/sssd/libsss_simple.so libipa_hbac-python: /usr/lib64/python2.7/site-packages/pyhbac.so libsss_sudo: /usr/lib64/libsss_sudo.so libsss_autofs: /usr/lib64/sssd/modules/libsss_autofs.so MD5-sum check ------------- https://fedorahosted.org/released/sssd/sssd-1.9.3.tar.gz : CHECKSUM(SHA256) this package : 4fa3f6ed6c1defb52ac005a86c672db12dab2eb01a14dae666a093a771d9dba6 CHECKSUM(SHA256) upstream package : 4fa3f6ed6c1defb52ac005a86c672db12dab2eb01a14dae666a093a771d9dba6 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn sssd -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires