Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in subscription-manager-gui , subscription-manager-firstboot , subscription- manager-migration [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: update-desktop-database is invoked when required Note: desktop file(s) in subscription-manager-gui [ ]: gtk-update-icon-cache is invoked when required Note: icons in subscription-manager-gui [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 92160 bytes in 4 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define use_systemd (0%{?fedora} && 0%{?fedora} >= 17) || (0%{?rhel} && 0%{?rhel} >= 7) %define el5 1 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3799040 bytes in /usr/share 2703360 subscription-manager-1.8.1-1.fc19.x86_64.rpm 40960 subscription-manager- migration-1.8.1-1.fc19.x86_64.rpm 1013760 subscription-manager- gui-1.8.1-1.fc19.x86_64.rpm 40960 subscription-manager- firstboot-1.8.1-1.fc19.x86_64.rpm Rpmlint ------- Checking: subscription-manager-1.8.1-1.fc19.x86_64.rpm subscription-manager-gui-1.8.1-1.fc19.x86_64.rpm subscription-manager-firstboot-1.8.1-1.fc19.x86_64.rpm subscription-manager-migration-1.8.1-1.fc19.x86_64.rpm subscription-manager.x86_64: W: invalid-url URL: https://fedorahosted.org/subscription-manager/ The read operation timed out subscription-manager.x86_64: W: only-non-binary-in-usr-lib subscription-manager.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/subscription-manager subscription-manager.x86_64: W: non-conffile-in-etc /etc/security/console.apps/subscription-manager subscription-manager.x86_64: W: manual-page-warning /usr/share/man/man8/rct.8.gz 238: warning: macro `...' not defined subscription-manager.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/rct subscription-manager.x86_64: E: non-executable-script /usr/share/rhsm/subscription_manager/certmgr.py 0644L /usr/bin/python subscription-manager.x86_64: W: manual-page-warning /usr/share/man/man8/subscription-manager.8.gz 817: warning: macro `pp' not defined subscription-manager.x86_64: W: non-conffile-in-etc /etc/pam.d/subscription-manager subscription-manager-gui.x86_64: E: explicit-lib-dependency librsvg2 subscription-manager-gui.x86_64: W: non-conffile-in-etc /etc/pam.d/subscription-manager-gui subscription-manager-gui.x86_64: W: no-dependency-on usermode subscription-manager-gui.x86_64: W: non-conffile-in-etc /etc/security/console.apps/subscription-manager-gui subscription-manager-gui.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/rhsm-icon.desktop subscription-manager-firstboot.x86_64: E: explicit-lib-dependency librsvg2 subscription-manager-firstboot.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 3 errors, 13 warnings. Requires -------- subscription-manager-migration (rpmlib, GLIBC filtered): /usr/bin/python subscription-manager subscription-manager (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python chkconfig config(subscription-manager) dbus-python initscripts libc.so.6()(64bit) libglib-2.0.so.0()(64bit) pygobject2 python-dateutil python-dmidecode python-ethtool python-iniparse python-rhsm python-simplejson rtld(GNU_HASH) systemd-units usermode virt-what yum subscription-manager-firstboot (rpmlib, GLIBC filtered): librsvg2 subscription-manager-gui subscription-manager-gui (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python dbus-x11 gnome-python2 gnome-python2-canvas libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgconf-2.so.4()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libnotify.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librsvg2 pygtk2 pygtk2-libglade rtld(GNU_HASH) scrollkeeper subscription-manager usermode-gtk Provides -------- subscription-manager-migration: subscription-manager-migration subscription-manager-migration(x86-64) subscription-manager: config(subscription-manager) subscription-manager subscription-manager(x86-64) subscription-manager-firstboot: subscription-manager-firstboot subscription-manager-firstboot(x86-64) subscription-manager-gui: subscription-manager-gnome subscription-manager-gui subscription-manager-gui(x86-64) Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn subscription-manager -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires