Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 2959360 bytes in 52 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in suitesparse-devel , suitesparse-static , suitesparse-doc [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define amd_version 2.3.1 %define amd_version_major 2 %define btf_version 1.2.0 %define btf_version_major 1 %define camd_version 2.3.1 %define camd_version_major 2 %define ccolamd_version 2.8.0 %define ccolamd_version_major 2 %define cholmod_version 2.0.1 %define cholmod_version_major 2 %define colamd_version 2.8.0 %define colamd_version_major 2 %define csparse_version 3.1.1 %define csparse_version_major 3 %define cxsparse_version 3.1.1 %define cxsparse_version_major 3 %define klu_version 1.2.1 %define klu_version_major 1 %define ldl_version 2.1.0 %define ldl_version_major 2 %define umfpack_version 5.6.1 %define umfpack_version_major 5 %define spqr_version 1.3.1 %define spqr_version_major 1 %define rbio_version 2.1.1 %define rbio_version_major 2 %define SuiteSparse_config_ver 4.2.0 %define SuiteSparse_config_major 4 %define enable_metis 0 %define enable_csparse 0 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: suitesparse-4.0.2-2.fc19.x86_64.rpm suitesparse-devel-4.0.2-2.fc19.x86_64.rpm suitesparse-static-4.0.2-2.fc19.x86_64.rpm suitesparse-doc-4.0.2-2.fc19.noarch.rpm suitesparse.x86_64: W: spelling-error %description -l en_US multithread -> multitude suitesparse.x86_64: W: spelling-error %description -l en_US multifrontal -> multinational suitesparse.x86_64: W: spelling-error %description -l en_US RBio -> R Bio, Rio, Biro suitesparse.x86_64: W: obsolete-not-provided umfpack suitesparse.x86_64: W: no-documentation suitesparse-devel.x86_64: W: obsolete-not-provided umfpack-devel suitesparse-devel.x86_64: W: no-documentation suitesparse-static.x86_64: W: spelling-error %description -l en_US linkable -> likable, sinkable, link able suitesparse-static.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Requires -------- suitesparse-devel (rpmlib, GLIBC filtered): libamd.so.2()(64bit) libbtf.so.1()(64bit) libcamd.so.2()(64bit) libccolamd.so.2()(64bit) libcholmod.so.2()(64bit) libcolamd.so.2()(64bit) libcxsparse.so.3()(64bit) libklu.so.1()(64bit) libldl.so.2()(64bit) librbio.so.2()(64bit) libspqr.so.1()(64bit) libsuitesparseconfig.so.4()(64bit) libumfpack.so.5()(64bit) suitesparse suitesparse-static (rpmlib, GLIBC filtered): suitesparse-devel suitesparse-doc (rpmlib, GLIBC filtered): suitesparse suitesparse (rpmlib, GLIBC filtered): /sbin/ldconfig libamd.so.2()(64bit) libbtf.so.1()(64bit) libc.so.6()(64bit) libcamd.so.2()(64bit) libcblas.so.3()(64bit) libccolamd.so.2()(64bit) libcholmod.so.2()(64bit) libcolamd.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) liblapack.so.3()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsuitesparseconfig.so.4()(64bit) libtbb.so.2()(64bit) libtbbmalloc.so.2()(64bit) rtld(GNU_HASH) Provides -------- suitesparse-devel: suitesparse-devel suitesparse-devel(x86-64) ufsparse-devel suitesparse-static: suitesparse-static suitesparse-static(x86-64) ufsparse-static suitesparse-doc: suitesparse-doc suitesparse: libamd.so.2()(64bit) libbtf.so.1()(64bit) libcamd.so.2()(64bit) libccolamd.so.2()(64bit) libcholmod.so.2()(64bit) libcolamd.so.2()(64bit) libcxsparse.so.3()(64bit) libklu.so.1()(64bit) libldl.so.2()(64bit) librbio.so.2()(64bit) libspqr.so.1()(64bit) libsuitesparseconfig.so.4()(64bit) libumfpack.so.5()(64bit) suitesparse suitesparse(x86-64) ufsparse MD5-sum check ------------- http://www.cise.ufl.edu/research/sparse/SuiteSparse/SuiteSparse-4.0.2.tar.gz : CHECKSUM(SHA256) this package : 93b5928987fe010808b3fdff3e7edef42fb2d8cfd65b09dd6d4c41756acb0050 CHECKSUM(SHA256) upstream package : 93b5928987fe010808b3fdff3e7edef42fb2d8cfd65b09dd6d4c41756acb0050 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn suitesparse -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires