Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in system-config-language See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: The spec file handles locales properly. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in system-config-language [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 1 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: system-config-language-1.3.5-19.fc19.noarch.rpm system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/lang_dict.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/language_gui.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/language_backend.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/system-config-language.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/gui_install.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/doc/system-config-language-1.3.5/COPYING system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/gui_progress.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/gui_detailsDialog.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/tui_install.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/language_tui.py system-config-language.noarch: E: incorrect-fsf-address /usr/share/system-config-language/gui_errors.py system-config-language.noarch: W: no-manual-page-for-binary system-config-language 1 packages and 0 specfiles checked; 11 errors, 1 warnings. Requires -------- system-config-language (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(system-config-language) gtk2 pygtk2 usermode usermode-gtk yum Provides -------- system-config-language: config(system-config-language) system-config-language MD5-sum check ------------- https://fedorahosted.org/releases/s/y/system-config-language/system-config-language-1.3.5.tar.bz2 : CHECKSUM(SHA256) this package : c7aa159dab87005a4e1e6993b66f5e0d14143aef78419e3743bf1549a1daa0ff CHECKSUM(SHA256) upstream package : c7aa159dab87005a4e1e6993b66f5e0d14143aef78419e3743bf1549a1daa0ff Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn system-config-language -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires