Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - update-desktop-database is invoked when required Note: desktop file(s) in system-config-printer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in system- config-printer-udev [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 276480 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5928960 bytes in /usr/share 1525760 system-config-printer-1.3.12-7.fc19.x86_64.rpm 4403200 system-config- printer-libs-1.3.12-7.fc19.x86_64.rpm Rpmlint ------- Checking: system-config-printer-1.3.12-7.fc19.x86_64.rpm system-config-printer-udev-1.3.12-7.fc19.x86_64.rpm system-config-printer.x86_64: E: explicit-lib-dependency libxml2-python(x86-64) system-config-printer.x86_64: E: no-binary system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/ErrorLogCheckpoint.py 0644L /usr/bin/python system-config-printer.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/print-applet.desktop system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/PrintTestPage.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/Welcome.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/serversettings.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/CheckLocalServerPublishing.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/ChoosePrinter.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/xml/validate.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/ErrorLogFetch.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/CheckUSBPermissions.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/CheckPPDSanity.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/QueueNotEnabled.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/SchedulerNotRunning.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/PrinterStateReasons.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/base.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/ErrorLogParse.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/RemoteAddress.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/Shrug.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/CheckPrinterSanity.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/ChooseNetworkPrinter.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/CheckNetworkServerSanity.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/CheckSELinux.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/userdefault.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/QueueRejectingJobs.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/LocalOrRemote.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/NetworkCUPSPrinterShared.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/Locale.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/VerifyPackages.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/DeviceListed.py 0644L /usr/bin/python system-config-printer.x86_64: E: non-executable-script /usr/share/system-config-printer/troubleshoot/ServerFirewalled.py 0644L /usr/bin/python system-config-printer.x86_64: W: dangerous-command-in-%post rm system-config-printer-udev.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 31 errors, 3 warnings. Requires -------- system-config-printer (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python dbus-python(x86-64) dbus-x11 desktop-file-utils desktop-notification-daemon gnome-icon-theme gnome-python2-gnomekeyring(x86-64) libxml2-python(x86-64) notify-python(x86-64) pygobject2(x86-64) pygtk2(x86-64) python-slip-gtk python-smbc(x86-64) system-config-printer-libs systemd-units system-config-printer-udev (rpmlib, GLIBC filtered): /usr/bin/python config(system-config-printer-udev) libc.so.6()(64bit) libcups.so.2()(64bit) libglib-2.0.so.0()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) system-config-printer-libs Provides -------- system-config-printer: system-config-printer system-config-printer(x86-64) system-config-printer-udev: config(system-config-printer-udev) hal-cups-utils system-config-printer-udev system-config-printer-udev(x86-64) MD5-sum check ------------- http://cyberelk.net/tim/data/system-config-printer/1.3/system-config-printer-1.3.12.tar.xz : CHECKSUM(SHA256) this package : 1905bd9fd382730a8eab80fa196b1c43bd19ce79c2169142de899697cbb1e9b1 CHECKSUM(SHA256) upstream package : 1905bd9fd382730a8eab80fa196b1c43bd19ce79c2169142de899697cbb1e9b1 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn system-config-printer -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires